From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 0F0D8431FBF for ; Sun, 6 Jul 2014 13:42:17 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.099 X-Spam-Level: X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FC24r+2I96rU for ; Sun, 6 Jul 2014 13:42:09 -0700 (PDT) Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DB87E431FBD for ; Sun, 6 Jul 2014 13:42:08 -0700 (PDT) Received: from fruiteater.riseup.net (fruiteater-pn.riseup.net [10.0.1.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Gandi Standard SSL CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 1236651B6B; Sun, 6 Jul 2014 13:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=riseup.net; s=squak; t=1404679328; bh=9coxL15bGohwK/5ybyPDb9/lHoXLiO3dIYw2QbNB494=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=qm86V0NKKMN6gCQdt99Zp3j+Ks/5gA7twWzrySiXkxfS/zCvZU+q67EaQnlTvsIXT GZFSFNnaCnoU/nqdvfnxpMSwneGuxV7pUafMXVM8ujsIt7kIjIaN4ewEvczux3E3q3 J6ui/oM34hQYs/ey+v6ib+KHYUheKS8LkUjHF6oA= Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: bacuh@fruiteater.riseup.net) with ESMTPSA id A833C900 From: Sebastian Lipp To: Karl Fogel Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. In-Reply-To: <87d2djr7o1.fsf@floss.red-bean.com> References: <87wqsfik5l.fsf@floss.red-bean.com> <87mwtah2hd.fsf@zancas.localnet> <877gkeau42.fsf@floss.red-bean.com> <8738v1jtzc.fsf@nikula.org> <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov> <87vc7vgbym.fsf@zancas.localnet> <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> <87oax6vt4u.fsf@ktab.red-bean.com> <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> <87d2djr7o1.fsf@floss.red-bean.com> User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1 (i686-pc-linux-gnu) Date: Sun, 06 Jul 2014 22:41:02 +0200 Message-ID: <878uo6dxup.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-Virus-Scanned: clamav-milter 0.98.1 at mx1 X-Virus-Status: Clean Cc: Tomi Ollila , notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jul 2014 20:42:17 -0000 Karl Fogel > In general, supplying a log message with the patch with avoid such > confusion. If there is some prose expressing what the change is > supposed to to, and giving any historical context (such as the mailing > list thread starting from last year), then it will be easy for any > reviewer to understand what the patch is intended to do, and check if it > actually does that. Okay, next time I will provide that information inline. Thought keeping References and In-Reply-To headers would be sufficient reference.