From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 00/11] notmuch insert updates
Date: Thu, 25 Sep 2014 10:13:40 +0200 [thread overview]
Message-ID: <878ul815jf.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <cover.1411379395.git.jani@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> This series refactors and cleans up insert, improves error handling and
> reporting, and adds post-insert hook. I intend to add documentation and
> more tests, but the code is ready for review. Also, at least some of the
> cleanups and fixes in the beginning of the series could go in without
> additional tests or documentation.
The first 4 seem trivial, and I marked them so.
5-8 don't introduce new functionality, and don't break
any existing tests. Subject to a little more review, these could
probably be merged now.
5 is almost trivial; it wouldn't hurt to explicitly document the return
values of sync_dir, while touching this code.
6 and 8 seem ok, but should probably have another pair of eyes.
7 seems ok. At first I worried about the usual issue of races between
name definition and open, but it seems like nothing changes here.
next prev parent reply other threads:[~2014-09-25 8:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 9:54 [PATCH 00/11] notmuch insert updates Jani Nikula
2014-09-22 9:54 ` [PATCH 01/11] lib: actually return failures from notmuch_message_tags_to_maildir_flags Jani Nikula
2014-09-22 9:54 ` [PATCH 02/11] cli/insert: rename check_folder_name to is_valid_folder_name Jani Nikula
2014-09-22 9:54 ` [PATCH 03/11] cli/insert: move add_file_to_database to a better place Jani Nikula
2014-09-22 9:54 ` [PATCH 04/11] cli/insert: rename file copy function Jani Nikula
2014-09-22 9:54 ` [PATCH 05/11] cli/insert: clean up sync_dir Jani Nikula
2014-09-22 9:54 ` [PATCH 06/11] cli/insert: use a single recursive mkdir function Jani Nikula
2014-09-22 9:54 ` [PATCH 07/11] cli/insert: abstract temporary filename generation Jani Nikula
2014-09-22 9:54 ` [PATCH 08/11] cli/insert: rehash file writing functions Jani Nikula
2014-09-22 9:55 ` [PATCH 09/11] cli/insert: add fail path to add_file_to_database Jani Nikula
2014-09-26 20:09 ` David Bremner
2014-09-22 9:55 ` [PATCH 10/11] cli/insert: require succesful message indexing for success status Jani Nikula
2014-09-22 9:55 ` [PATCH 11/11] cli/insert: add post-insert hook Jani Nikula
2014-09-25 8:13 ` David Bremner [this message]
2014-09-25 19:54 ` [PATCH 00/11] notmuch insert updates Tomi Ollila
2014-09-26 6:48 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ul815jf.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).