From: Daniel Schoepe <daniel@schoepe.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/5] cli/count: add --lastmod
Date: Sat, 15 Aug 2015 09:21:49 +0200 [thread overview]
Message-ID: <878u9dyq2a.fsf@schoepe.localhost> (raw)
In-Reply-To: <1439570878-15165-4-git-send-email-david@tethera.net>
On Fri, 14 Aug 2015 18:47 +0200, David Bremner wrote:
> + ``--lastmod``
> + Append lastmod (counter for number of database updates) and UUID
> + to the output. lastmod values are only comparable between databases
> + with the same UUID.
Sorry to keep harping on this, but I'm not entirely happy with the way
we handle notmuch-compact here (and in the other commit that mentions
compacting explicitly). Given that lastmod values (and pretty much
everything else) aren't affected by compacting, would it perhaps make
sense to copy the previous UUID to the newly compacted database?
Given that a compacted database is "indistinguishable" from the previous
non-compacted database, we may want to signal that it's still the "same
database". Is there a case where compacting actually makes a difference
to anything making use of lastmod values?
Best regards,
Daniel
next prev parent reply other threads:[~2015-08-15 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 16:47 revision tracking patches round 4 David Bremner
2015-08-14 16:47 ` [PATCH 1/5] lib: Add per-message last modification tracking David Bremner
2015-08-14 16:47 ` [PATCH 2/5] lib: API to retrieve database revision and UUID David Bremner
2015-08-14 16:47 ` [PATCH 3/5] cli/count: add --lastmod David Bremner
2015-08-15 7:21 ` Daniel Schoepe [this message]
2015-08-15 10:42 ` David Bremner
2015-08-18 11:32 ` Daniel Schoepe
2015-08-14 16:47 ` [PATCH 4/5] cli: add global option "--uuid" David Bremner
2015-08-14 16:47 ` [PATCH 5/5] lib: Add "lastmod:" queries for filtering by last modification David Bremner
2015-08-20 6:22 ` David Bremner
2015-08-20 7:11 ` Gaute Hope
2015-08-15 8:25 ` revision tracking patches round 4 Tomi Ollila
2015-08-15 15:35 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878u9dyq2a.fsf@schoepe.localhost \
--to=daniel@schoepe.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).