* [PÄTCH] notmuch-emacs-mua: set EMACS{,CLIENT} variables to defaults when empty
@ 2015-10-04 18:59 Tomi Ollila
2015-11-19 11:56 ` David Bremner
0 siblings, 1 reply; 2+ messages in thread
From: Tomi Ollila @ 2015-10-04 18:59 UTC (permalink / raw)
To: notmuch; +Cc: tomi.ollila
... in addition to doing this when these variables are unset.
It is more useful to use defaults (emacs or emacsclient) than empty
string as a command name.
---
Without this:
$ EMACS= ./notmuch-emacs-mua
./notmuch-emacs-mua: line 150: exec: --: invalid option
exec: usage: exec [-cl] [-a name] [command [arguments ...]] [redirection ...]
zsh: exit 2 EMACS= ./notmuch-emacs-mua
notmuch-emacs-mua | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/notmuch-emacs-mua b/notmuch-emacs-mua
index 016fa12613c4..4404cd7c33b8 100755
--- a/notmuch-emacs-mua
+++ b/notmuch-emacs-mua
@@ -30,8 +30,8 @@ escape ()
printf -v $2 '%s' "${__escape_arg__//\"/\\\"}"
}
-EMACS=${EMACS-emacs}
-EMACSCLIENT=${EMACSCLIENT-emacsclient}
+EMACS=${EMACS:-emacs}
+EMACSCLIENT=${EMACSCLIENT:-emacsclient}
PRINT_ONLY=
NO_WINDOW=
--
2.0.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PÄTCH] notmuch-emacs-mua: set EMACS{,CLIENT} variables to defaults when empty
2015-10-04 18:59 [PÄTCH] notmuch-emacs-mua: set EMACS{,CLIENT} variables to defaults when empty Tomi Ollila
@ 2015-11-19 11:56 ` David Bremner
0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2015-11-19 11:56 UTC (permalink / raw)
To: Tomi Ollila, notmuch; +Cc: tomi.ollila
Tomi Ollila <tomi.ollila@iki.fi> writes:
> ... in addition to doing this when these variables are unset.
>
> It is more useful to use defaults (emacs or emacsclient) than empty
> string as a command name.
Pushed,
d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-19 11:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-04 18:59 [PÄTCH] notmuch-emacs-mua: set EMACS{,CLIENT} variables to defaults when empty Tomi Ollila
2015-11-19 11:56 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).