[PATCH] test/crypto: hard code fingerprint

[PATCH] test/crypto: hard code fingerprint

[David Bremner]

Originally the intent was to make the test more robust against changing
test keys. It turns out that (unscientifically) gpg --with-colons output
changes more often than our test key. Rather than making the script more
complex, just hard code the fingerprint.

This fixes Debian bug #847013; I expect similar test failures as other
distros adopt gnupg 2.1.15
---

I plan to release 0.22.2 with this fix, and cf8aabdd375 (already
pushed to debian, but not debian specific).

test/T350-crypto.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh
index 3656cce..96349fa 100755
--- a/test/T350-crypto.sh
+++ b/test/T350-crypto.sh
@@ -25,8 +25,8 @@ add_gnupg_home ()
 ##################################################
 
 add_gnupg_home
-# get key fingerprint
-FINGERPRINT=$(gpg --no-tty --list-secret-keys --with-colons --fingerprint | grep '^fpr:' | cut -d: -f10)
+# Change this if we ship a new test key
+FINGERPRINT="5AEAB11F5E33DCE875DDB75B6D92612D94E46381"
 
 test_expect_success 'emacs delivery of signed message' \
 'emacs_fcc_message \
-- 
2.9.3

Re: [PATCH] test/crypto: hard code fingerprint

[Tomi Ollila]

On Thu, Sep 08 2016, David Bremner <david@tethera.net> wrote:

> Originally the intent was to make the test more robust against changing
> test keys. It turns out that (unscientifically) gpg --with-colons output
> changes more often than our test key. Rather than making the script more
> complex, just hard code the fingerprint.
>
> This fixes Debian bug #847013; I expect similar test failures as other
> distros adopt gnupg 2.1.15

looks tolerable to me...

> ---
>
> I plan to release 0.22.2 with this fix, and cf8aabdd375 (already
> pushed to debian, but not debian specific).
>
> test/T350-crypto.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh
> index 3656cce..96349fa 100755
> --- a/test/T350-crypto.sh
> +++ b/test/T350-crypto.sh
> @@ -25,8 +25,8 @@ add_gnupg_home ()
>  ##################################################
>  
>  add_gnupg_home
> -# get key fingerprint
> -FINGERPRINT=$(gpg --no-tty --list-secret-keys --with-colons --fingerprint | grep '^fpr:' | cut -d: -f10)
> +# Change this if we ship a new test key
> +FINGERPRINT="5AEAB11F5E33DCE875DDB75B6D92612D94E46381"
>  
>  test_expect_success 'emacs delivery of signed message' \
>  'emacs_fcc_message \
> -- 
> 2.9.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test/crypto: hard code fingerprint

[David Bremner]

David Bremner <david@tethera.net> writes:

> Originally the intent was to make the test more robust against changing
> test keys. It turns out that (unscientifically) gpg --with-colons output
> changes more often than our test key. Rather than making the script more
> complex, just hard code the fingerprint.

pushed

d