From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 568866DE0AF4 for ; Fri, 21 Oct 2016 00:01:45 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.305 X-Spam-Level: X-Spam-Status: No, score=-0.305 tagged_above=-999 required=5 tests=[AWL=0.265, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KK0Pd9qy6uWV for ; Fri, 21 Oct 2016 00:01:43 -0700 (PDT) Received: from mail-qk0-f179.google.com (mail-qk0-f179.google.com [209.85.220.179]) by arlo.cworth.org (Postfix) with ESMTPS id 4CD266DE0173 for ; Fri, 21 Oct 2016 00:01:43 -0700 (PDT) Received: by mail-qk0-f179.google.com with SMTP id f128so128617937qkb.1 for ; Fri, 21 Oct 2016 00:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=TLZ82lkQxMU3y2yrVbqxsSZJaxml1op1Tm2PTZlryCM=; b=QUqY6MFLMqIpFiBViyu1Ab+H6XKCQjeksXk8vl2lswRqXCjvqHexK2qW/o68e48HRi iYS/9UMLh9Si4nSeUSrG97IR+UzrJaNQ7LOh170kmWbLB2weXJ/dCkxNf23x9aMavR8Q E7qpMYAXyhfsFpdWEBdHMy0nd036BTiSf0yij3dbQ/+g5knkX052jbY3D4Utst0z2fWd uGX9xyx5dRdkpAgXh9RNlbJBnooGNirHaRvpBPeHzQH/iFea0GbS3wPavrxyxZaUIyO7 hTvppjR6lfJD1j/T5Idjb/qgngYGNLRSQG3kUD9h+zlXaTB1jUiAh0yX5ui5/N4SLQu5 KWtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=TLZ82lkQxMU3y2yrVbqxsSZJaxml1op1Tm2PTZlryCM=; b=IXWBphGmK22L6iMfWTSk/asHc56z1qhLZPOtBVTdqxWHj9mLM6KbtQ3XznTa8HqW2N B6VdRXkPdUE0dK8yH4SPktMxhK3tAtLBwkGZ9Rq72Bk6pec21PAN1Spy5bra/7iKD2PV 6pUKIEq+7WG49VN9A6oTRS2m71j+7SEMNwkije1pCze12qs1ZlrYdMHstk47hUIpMxw2 1VLueIiiM55vSDglZ4pVGuAKgSrO9hqDO0uPJVYXdWt/Y3SCgSL4J7nL0PhGwMtM92Ab rNAOkLC41FGP3bbpIjtY0HNaRxARLIeFHhPPNBqJ6CjGkCE2HSJukf2Gr+xNTF9EtWh/ edEQ== X-Gm-Message-State: AA6/9Rn4KYxRKwGsfloeqtTioQtTrdr3gnw7hvW3EOui/Dp3FiIuAXPqyjyx0JnTXb3Ivw== X-Received: by 10.194.85.193 with SMTP id j1mr2717221wjz.23.1477033302062; Fri, 21 Oct 2016 00:01:42 -0700 (PDT) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id n131sm2521851wmd.13.2016.10.21.00.01.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Oct 2016 00:01:41 -0700 (PDT) From: Mark Walters To: Franz Fellner , David Bremner , Tomi Ollila , notmuch@notmuchmail.org Cc: tomi.ollila@iki.fi Subject: Re: [PATCH] lib/database.cc: fix misleading indentation In-Reply-To: <1.477.032.157-ner-5.771@TP_L520> References: <1474988812-21365-1-git-send-email-tomi.ollila@iki.fi> <1.476.968.079-ner-1.779@TP_L520> <87funrrmqb.fsf@tesseract.cs.unb.ca> <1.476.988.252-ner-1.022@TP_L520> <87h986k2kj.fsf@tethera.net> <1.477.032.157-ner-5.771@TP_L520> Date: Fri, 21 Oct 2016 08:01:40 +0100 Message-ID: <878tti5gob.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 07:01:45 -0000 Hi > * the first line in the first for loop is indented by only one TAB (IMHO should be > two, because it is one leven down): this is a pattern you can find throughout the > codebase. I think this is the key confusion -- the notmuch convention is that 1 tab = 8 spaces The only other rule is that you should prefer tabs to spaces so you should never have more than 7 spaces -- for example an indentation of 12 would be 1 tab + 4 spaces. Best wishes Mark > * the next two lines are indented by four spaces > * the first line of the second for-loop is indented by one TAB. > * and so on... > > Am I misinterpreting something here? Is this intended to be done that way? > I also get confused by the different lengths of TAB/space-indenting. But probably > that's because I never used it... > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch