From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 7B57F6DE2980 for ; Thu, 29 Mar 2018 04:19:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.554 X-Spam-Level: X-Spam-Status: No, score=-0.554 tagged_above=-999 required=5 tests=[AWL=-0.544, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m8KHrWhml_Jq for ; Thu, 29 Mar 2018 04:19:21 -0700 (PDT) X-Greylist: delayed 571 seconds by postgrey-1.36 at arlo; Thu, 29 Mar 2018 04:19:21 PDT Received: from cerokez-230.feld.cvut.cz (cerokez-230.feld.cvut.cz [147.32.210.230]) by arlo.cworth.org (Postfix) with ESMTP id 0CD256DE297E for ; Thu, 29 Mar 2018 04:19:20 -0700 (PDT) Received: from smtpx.feld.cvut.cz (smtpx.feld.cvut.cz [147.32.192.33]) by cerokez-230.feld.cvut.cz (Postfix) with ESMTP id 9782017A7; Thu, 29 Mar 2018 13:09:45 +0200 (CEST) Received: from localhost (unknown [192.168.200.7]) by smtpx.feld.cvut.cz (Postfix) with ESMTP id 963FDDC2A9; Thu, 29 Mar 2018 13:09:45 +0200 (CEST) X-Virus-Scanned: IMAP STYX AMAVIS Received: from smtpx.feld.cvut.cz ([192.168.200.6]) by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, port 10054) with ESMTP id eRx1_eIIp9CY; Thu, 29 Mar 2018 13:09:44 +0200 (CEST) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by smtpx.feld.cvut.cz (Postfix) with ESMTP id 27DB5DC216; Thu, 29 Mar 2018 13:09:44 +0200 (CEST) Received: from wsh by steelpick.2x.cz with local (Exim 4.90_1) (envelope-from ) id 1f1VR9-0007Oc-E6; Thu, 29 Mar 2018 13:09:43 +0200 From: Michal Sojka To: bugs@gnus.org Cc: notmuch@notmuchmail.org Subject: Failure to report send errors Date: Thu, 29 Mar 2018 13:09:43 +0200 Message-ID: <878tab2l54.fsf@steelpick.2x.cz> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2018 11:19:22 -0000 Dear Gnus developers, (CCing notmuch, because their users can be affected too) When message-interactive is nil, message-send can falsely report success even when sending fails and there is no way for the user to learn about the failure, expect from angry peers complaining about not receiving replies. The function responsible for this problematic behavior is message-send-mail-with-sendmail. It works in two modes: interactive and non-interactive depending on the value of message-interactive. The problem happens in the non-interactive mode (which is not the default). It executes sendmail with -odb -oem, which means that delivery should happen in background and errors should be reported to the user via email. sendmail is executed via call-process-region called without BUFFER argument, meaning that the return value is always nil. If sendmail fails to execute at all, perhaps due to corrupted configuration file, neither the message nor any error email is ever sent, but the user sees false "Sending...done" message. I think that call-process-region should be always called with a BUFFER so that sendmail exit code is returned and communicated to the user. Best regards, -Michal