From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A80796DE0083 for ; Mon, 9 Apr 2018 04:54:07 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gnw6UclILTdS for ; Mon, 9 Apr 2018 04:54:06 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 171BE6DE0068 for ; Mon, 9 Apr 2018 04:54:05 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1f5VN4-0005C7-Tr; Mon, 09 Apr 2018 07:54:02 -0400 Received: (nullmailer pid 13889 invoked by uid 1000); Mon, 09 Apr 2018 11:54:01 -0000 From: David Bremner To: "Naveen N. Rao" , notmuch@notmuchmail.org Subject: Re: 'notmuch search thread:<>' lists multiple threads In-Reply-To: <87sh86v1oc.fsf@tethera.net> References: <1523007700.l8xm6nm6af.naveen@linux.ibm.com> <87sh86v1oc.fsf@tethera.net> Date: Mon, 09 Apr 2018 08:54:01 -0300 Message-ID: <878t9wvbmu.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 11:54:07 -0000 David Bremner writes: > At least some of this mail data is public, but I'm not sure if the bad > threading is reproducible or not; I want to run a complete census > overnight before I reindex. > > Even if the bug is non-deterministic, it probably lives in lib/add-message.cc I have a reproducible test for this bug now http://pivot.cs.unb.ca/git?p=notmuch.git;a=shortlog;h=refs/heads/fix/thread-search I still need to analyze the mails a bit more, but it looks like at least one of the strange results is caused by multiple mail files sharing the same message-id, but with different References headers (and no In-Reply-To headers). d