From: David Bremner <david@tethera.net>
To: Pierre Neidhardt <mail@ambrevar.xyz>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree
Date: Wed, 08 May 2019 08:00:59 -0300 [thread overview]
Message-ID: <878svhfbx0.fsf@tethera.net> (raw)
In-Reply-To: <20190409164745.13497-1-mail@ambrevar.xyz>
Thanks for contributing to Notmuch. Some generic comments:
1) Please consider a more comprehensive commit message [1]. The "why"
here is maybe obvious, but consider pointing out whether this makes
it more consistent with other parts of the UI (or not). Also, a (bit
more extended) of the changes is always helpful, both to help read
the diff and to warn of any potential breaking changes.
2) Please update doc/notmuch-emacs.rst. You can re-use docstrings; let
me know if you need help doing that. We haven't been strict about
this is in the past, but the emacs docs are really lagging.
3) We generally want at least one test for a new
feature. test/T460-emacs-tree.sh has the existing tree related
tests. Again, if you need help with the test suite, let us know.
4) Please use notmuch-tree-- as a prefix for new private symbols that
users should not rely on. I'm not sure about which symbols that applies
to here.
[1] https://notmuchmail.org/contributing/#index5h2
Pierre Neidhardt <mail@ambrevar.xyz> writes:
> +(defun notmuch-tree-foreach-result (beg end fn)
> + (lexical-let ((pos (notmuch-tree-result-beginning beg))
As an aside, I'm curious if we can profitably start to use
file level lexical-binding for parts of notmuch-emacs.
> + (notmuch-tree-foreach-result beg end
> + (lambda (pos)
> + (save-mark-and-excursion
I did wonder if notmuch-tree-foreach-result should be a macro. I'm not
sure if the small gain in code compactness from just passing a "body" in
the style of notmuch-show--with-currently-shown-message is worth it.
next prev parent reply other threads:[~2019-05-08 11:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 16:47 [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region Pierre Neidhardt
2019-04-09 16:47 ` [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree Pierre Neidhardt
2019-05-08 11:00 ` David Bremner [this message]
2019-05-14 10:40 ` Pierre Neidhardt
2019-05-25 11:13 ` David Bremner
2019-05-25 11:41 ` Pierre Neidhardt
2019-05-25 13:42 ` David Bremner
2019-05-07 9:35 ` [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region David Bremner
2019-05-20 12:35 ` Leo Vivier
2019-05-20 17:11 ` Tomi Ollila
2019-05-22 14:56 ` Leo Vivier
2019-05-23 11:14 ` David Bremner
2019-05-23 11:19 ` Leo Vivier
2019-05-23 17:07 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878svhfbx0.fsf@tethera.net \
--to=david@tethera.net \
--cc=mail@ambrevar.xyz \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).