From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 61CCB6DE1509 for ; Mon, 10 Jun 2019 04:20:55 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 1.99 X-Spam-Level: * X-Spam-Status: No, score=1.99 tagged_above=-999 required=5 tests=[AWL=-0.113, DATE_IN_PAST_12_24=0.804, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SORBS_WEB=1.5, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qkEFoTRy9W94 for ; Mon, 10 Jun 2019 04:20:54 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 696DF6DE1447 for ; Mon, 10 Jun 2019 04:20:39 -0700 (PDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1560165637; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=D6GzNMT+ENA0aPiBnNiiVYIAMCmw4Uvn9CDG1i1QusA=; b=SuouMUWr7S5RmycO61R3s4TmgVZKzc+47LVQfo2QRAM26JNO8YUiUrnm sEFa0F0vlB9gTK27idWW5vhJnRXFDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1560165636; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=D6GzNMT+ENA0aPiBnNiiVYIAMCmw4Uvn9CDG1i1QusA=; b=ZYrax4PILWiIcX57pqesgqUC21x2elqhU68VHRvUqbJgTMz7HBaMup0F /p/jD86U1g/sHHfeQCBFTkg5Z6OTt+U0HwsswCEcdaRu+ArmgaIkHX4HB1 /D13IQLANLnF/6c0Bx3Od3hr0flcMwYT7lz7Dk2IX7gdB9kYyWLBN0n/8f JRulig3+S37kFxzsvVA6sFfzlXQJyWCuGC0FlwfqZDe/n1dd/6hXWEms43 4dDhiTHZ7BfFm/8oRAFYSKf3IfhJ+2WE4Q1U/uXoG+8XG99ni8KD5xIbjA 7DqgZDIyOJ7MFUyLTPvuaUv+7iUkeQuG1dZ6ylrEMQpHGNyIPOgl+Q== Received: from fifthhorseman.net (unknown [41.226.24.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 06EC5F99D; Mon, 10 Jun 2019 07:20:36 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 9EC452080D; Sun, 9 Jun 2019 16:18:32 -0400 (EDT) From: Daniel Kahn Gillmor To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH] append _unused to the expression defined using unused() macro In-Reply-To: <20190530195614.7745-1-tomi.ollila@iki.fi> References: <20190530195614.7745-1-tomi.ollila@iki.fi> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEXEK/AhYJKwYBBAHaRw8BAQdAr/gSROcn+6m8ijTN0DV9AahoHGafy52RRkhCZVwxhEe0K0Rh bmllbCBLYWhuIEdpbGxtb3IgPGRrZ0BmaWZ0aGhvcnNlbWFuLm5ldD6ImQQTFggAQQIbAQUJA8Jn AAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBMS8Lds4zOlkhevpwvIGkReQOOXGBQJcQsbzAhkB AAoJEPIGkReQOOXG4fkBAO1joRxqAZY57PjdzGieXLpluk9RkWa3ufkt3YUVEpH/AP9c+pgIxtyW +FwMQRjlqljuj8amdN4zuEqaCy4hhz/1DbgzBFxCv4sWCSsGAQQB2kcPAQEHQERSZxSPmgtdw6nN u7uxY7bzb9TnPrGAOp9kClBLRwGfiPUEGBYIACYWIQTEvC3bOMzpZIXr6cLyBpEXkDjlxgUCXEK/ iwIbAgUJAeEzgACBCRDyBpEXkDjlxnYgBBkWCAAdFiEEyQ5tNiAKG5IqFQnndhgZZSmuX/gFAlxC v4sACgkQdhgZZSmuX/iVWgD/fCU4ONzgy8w8UCHGmrmIZfDvdhg512NIBfx+Mz9ls5kA/Rq97vz4 z48MFuBdCuu0W/fVqVjnY7LN5n+CQJwGC0MIA7QA/RyY7Sz2gFIOcrns0RpoHr+3WI+won3xCD8+ sVXSHZvCAP98HCjDnw/b0lGuCR7coTXKLIM44/LFWgXAdZjm1wjODbg4BFxCv50SCisGAQQBl1UB BQEBB0BG4iXnHX/fs35NWKMWQTQoRI7oiAUt0wJHFFJbomxXbAMBCAeIfgQYFggAJhYhBMS8Lds4 zOlkhevpwvIGkReQOOXGBQJcQr+dAhsMBQkB4TOAAAoJEPIGkReQOOXGe/cBAPlek5d9xzcXUn/D kY6jKmxe26CTws3ZkbK6Aa5Ey/qKAP0VuPQSCRxA7RKfcB/XrEphfUFkraL06Xn/xGwJ+D0hCw== Date: Sun, 09 Jun 2019 16:18:32 -0400 Message-ID: <878suapl5z.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jun 2019 11:20:55 -0000 --=-=-= Content-Type: text/plain On Thu 2019-05-30 22:56:14 +0300, Tomi Ollila wrote: > This way if variables defined using unused() macro are actually > used then code will not compile... > > - removed unused usage around one argc and one argv since those > were used > > - changed one unused (char *argv[]) to unused (char **argv) to > work with modified unused() macro definition lgtm. i've tested it against the master branch, and it works fine. I like the belt-and-suspenders approach. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQTJDm02IAobkioVCed2GBllKa5f+AUCXP1pmAAKCRB2GBllKa5f +MXbAQC514qGjwH45HedQDAXI0zXjTmyBy2VELwDtBnZX4w6RQD/VCbvEWFCp/Mg 7dADzmjb2dfLhat/45542qujVfb/pwg= =KRwP -----END PGP SIGNATURE----- --=-=-=--