From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id ACB4C6DE1055 for ; Thu, 14 Nov 2019 15:09:50 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.203 X-Spam-Level: X-Spam-Status: No, score=-0.203 tagged_above=-999 required=5 tests=[AWL=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TI5yO-myIs28 for ; Thu, 14 Nov 2019 15:09:49 -0800 (PST) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by arlo.cworth.org (Postfix) with ESMTPS id B6ED06DE1050 for ; Thu, 14 Nov 2019 15:09:49 -0800 (PST) Received: by mail-wm1-f45.google.com with SMTP id u18so7745985wmc.3 for ; Thu, 14 Nov 2019 15:09:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:in-reply-to:references:date:message-id :mime-version; bh=+4SFArILtygYs/oU8Kip8NWVARHQYNyzgWjim6WmG0A=; b=ERwPEEL1N+9tzXKCtTSm2/nmfePD1GDdpdTZe04fFv00s+exYyKHS7h10b1QvIW9cp 8u52/y6Z7jzr/YYhUV7Gt13OdHVVgUUyx/jHo3XFX56ZAvKaOoZw+Ou23ihCgfxv2np+ 28x87uVGj6vbRMtviaHUfXUzTgnmCxIrzY/jFwiP/h5zestwaDFGq0mUs1EsXkCh7XxR iVPt812UjHNiFxJ1LQ87qOU9vRkkfemZmHQminzmi1WqjeaONip58nph07DGqD2GAa9y wH2JBoHfOXxmAFZnDAR+2R1LNThUEKkRgEk3AdFq0MbaHmAQn0Zp1DrndAjpkahfmUFi S5Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:in-reply-to:references :date:message-id:mime-version; bh=+4SFArILtygYs/oU8Kip8NWVARHQYNyzgWjim6WmG0A=; b=BHVpA5M6XkKMeAla/w9p6C8EB4tsaUr4GF5ZT4zD7crKO/tmjTmhIIbe/cwjzoib0P lDpPGpoi/GOL5/8ly4cYZE60PykCmniOrW8kM5jSFwyzWue/iNlPPmxngp9D+3xNxPsI 8t3rV18O2zAmZXkU7XVquIy6jmkdrVoPJIsPg9x0DqTj9p7qAX0kzPFZh3tnYZXhZvpJ r8kcDf6ZqQUc9EnXwnhr1r0OoGtwO0Dmzb2eo3NADFq4RlkaMtPeatUCclgYRkuYhPaj EvnMfFBmbwUboJBOUL2/SbGnyPAK6YGaD+OLGJJ6iM/bKUOj8kOUKSyI0iPtLrarB/HC EpTg== X-Gm-Message-State: APjAAAWEgmO3Ab1O7iUoK/nEa4Ga4ntnv7qLVq80wgmfChlExkuvpWFU UPq6aC27v4HH3Ahjhf9PcCs= X-Google-Smtp-Source: APXvYqyXifpVEsOQENml5bLBapteWDeuZiWWe/hQg+F46o/BKBZerupZEQCr6IYJ4ES1oxuqmvtlTg== X-Received: by 2002:a1c:720b:: with SMTP id n11mr10230092wmc.60.1573772987985; Thu, 14 Nov 2019 15:09:47 -0800 (PST) Received: from powell.devork.be ([2a02:168:58d0::7a3]) by smtp.gmail.com with ESMTPSA id w19sm7676697wmk.36.2019.11.14.15.09.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Nov 2019 15:09:47 -0800 (PST) Sender: Floris Bruynooghe Received: (nullmailer pid 32153 invoked by uid 1000); Thu, 14 Nov 2019 23:09:46 -0000 From: Floris Bruynooghe To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: python CFFI bindings integration into notmuch build/test In-Reply-To: <878soi2j1p.fsf@powell.devork.be> References: <20191104013927.17037-1-david@tethera.net> <87eeylspzo.fsf@tethera.net> <87blte2su3.fsf@powell.devork.be> <878soi2j1p.fsf@powell.devork.be> Date: Fri, 15 Nov 2019 00:09:46 +0100 Message-ID: <878soiqclh.fsf@powell.devork.be> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2019 23:09:50 -0000 On Thu 14 Nov 2019 at 23:24 +0100, Floris Bruynooghe wrote: > On Thu 14 Nov 2019 at 22:20 +0200, Tomi Ollila wrote: >> In git://notmuchmail.org/git/notmuch David has ref origin/wip/cffi >> which contains related changes -- You can fetch the code while waiting >> for more collaboration instructions from David. > > Aha, thanks! So I can run the tests using `make` and `cd tests; ./T-391-pytest-cffi.sh`. I can also run the tests still individually using something like: make set PATH (pwd) $PATH # I use fish pushd bindings/python-cffi pew workon notmuch # how I manage python virtualenvs pip install -e . pip install pytest pytest-cov pytest test/test_base.py And all works. I added a little function to the conftest.py to show which notmuch it's testing with: def pytest_report_header(): vers = subprocess.run(['notmuch', '--version'], capture_output=True, text=True) which = subprocess.run(['which', 'notmuch'], capture_output=True, text=True) return ['{} ({})'.format(vers.stdout.strip(), which.stdout.strip())] Maybe you find that useful too. Anyway, this looks good. Would you like some changes, e.g. the rename to notmuch2 or so as patches? What's the next step. Kind of unrelated, but in my attempt to run the full notmuch test suite (cd tests; make test) I somehow ended up with lots of weird tags in my notmuch database and made the emacs UI pretty horrible - though it seems I haven't lost any email. I'm sure that was my fault somehow even though I was just trying to follow the readme. But if anyone has any hints how to recover from this that could save me some time :) Cheers, Floris