From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GBS+M6Di2mEhFgEAgWs5BA (envelope-from ) for ; Sun, 09 Jan 2022 14:26:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UJcFMaDi2mEfVwEA9RJhRA (envelope-from ) for ; Sun, 09 Jan 2022 14:26:56 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 733A93916F for ; Sun, 9 Jan 2022 14:26:56 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E37E15F468; Sun, 9 Jan 2022 13:26:51 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 7209F5F3FE for ; Sun, 9 Jan 2022 13:26:49 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 7090B5FC42; Sun, 9 Jan 2022 08:26:48 -0500 (EST) Received: (nullmailer pid 3554417 invoked by uid 1000); Sun, 09 Jan 2022 13:26:47 -0000 From: David Bremner To: Floris Bruynooghe , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] python-cffi: returned OwnedMessage objects from Message.replies In-Reply-To: <87a6g6aw9w.fsf@powell.devork.be> References: <87o84nu23h.fsf@tethera.net> <20220108140316.3022887-1-david@tethera.net> <20220108140316.3022887-2-david@tethera.net> <87a6g6aw9w.fsf@powell.devork.be> Date: Sun, 09 Jan 2022 09:26:47 -0400 Message-ID: <878rvpt4yw.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 5G6EEYRFXTG5A4NLU5J6ZWCM4B2FYQX7 X-Message-ID-Hash: 5G6EEYRFXTG5A4NLU5J6ZWCM4B2FYQX7 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641734816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=gMiUjbNN81nsQdh45vNed7y997slVxLWCjasJ9KEXUA=; b=dIRx8yCbYdPjQ6HJjhiHOR6dAuRTVOFVsxVqUczJ/I8bNADlCZMyl7iMcTvz3/+DPjCe+I gqCgOOQtSpVA5fdpNZUJbkwjS/sVKCJ+2zX5BpySXMnhahInW3G99frfeg3njYjjU4SVGI +xXWKBu84Hy3DPbpMwhBi4BmrKfq5U0Pl1gPjVOuGh37HehT/0yj6/ckNef8Vb0xaZ8F+o V1cE/Ml3u3aEzY2LpPfjYCeUlIeV97EoPiesU+F6ka6xuGlmQ3zaLtApBIkAXrXy/S8DDV uUfQkz1Gjo4SoLO3V6wt1MjfttJLf7WB0VOXMIPyNX9e6phk0baRDecnSQvKxQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641734816; a=rsa-sha256; cv=none; b=KBDOEgh7B55AnD2NJjTCniqFOmr90fq+P/h5Ky5yZiF3V1PgWP7GMlFZkCObeRNJMz70aQ rYefdHhgKYCteeAUB6e2J0sGrnh32W2BTmu8nMdSgMk+xDNMCNOVkC5EZP4eNTqd0mZKLZ PRcVCDj/awLYltz2swEuSFNkFd1Xv7OWWs8cdFsppDdcXginyrYXNTxTV4PKWmwdSsC0Kz 55KNE+ZU2w2kSKm9G6GK9zJr57DqE7zvFVgCjuYg3qCiWpFEpfmcqCnKO7+yjLEqsLH5u4 +S/6MIPR98DpEvR49qL4QJRC7oRpL1+hnHwvASw88quSjigoZac4PqhJ7tJXvQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -3.29 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 733A93916F X-Spam-Score: -3.29 X-Migadu-Scanner: scn0.migadu.com X-TUID: PUy4aB6izBjt Floris Bruynooghe writes: > oh, nice debugging! And yes, this seems like the right fix, glad the > mechanism was at least already in place. > > With respect to the docs, they seem clear enough. Probably I missed > this or I simply didn't realise that the replies iter is basically a > thread owning it. > Thanks for the review. > Only thing I'd do different is write a pytest test for this as well, but > than I wouldn't have written the notmuch tests. So I don't think this > matters that much. We can always add a pytest test later. One thing I would like to think about is the length of time it takes to run the pytests. It is not currently the bottleneck in running the parallel tests for me, but it is among the slower T*.sh. So it might be nice at some point to split into several invocations for pytest, assuming multiple invocations of pytest can run in parallel. d