unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Floris Bruynooghe <flub@devork.be>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] python-cffi: returned OwnedMessage objects from Message.replies
Date: Sun, 09 Jan 2022 09:26:47 -0400	[thread overview]
Message-ID: <878rvpt4yw.fsf@tethera.net> (raw)
In-Reply-To: <87a6g6aw9w.fsf@powell.devork.be>

Floris Bruynooghe <flub@devork.be> writes:

> oh, nice debugging!  And yes, this seems like the right fix, glad the
> mechanism was at least already in place.
>
> With respect to the docs, they seem clear enough.  Probably I missed
> this or I simply didn't realise that the replies iter is basically a
> thread owning it.
>

Thanks for the review.

> Only thing I'd do different is write a pytest test for this as well, but
> than I wouldn't have written the notmuch tests. So I don't think this
> matters that much.

We can always add a pytest test later. One thing I would like to think
about is the length of time it takes to run the pytests. It is not
currently the bottleneck in running the parallel tests for me, but it is
among the slower T*.sh. So it might be nice at some point to split into
several invocations for pytest, assuming multiple invocations of pytest
can run in parallel.

d

  reply	other threads:[~2022-01-09 13:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-02 13:51 use after free in python notmuch2 bindings David Bremner
2022-01-07 13:06 ` David Bremner
2022-01-08 14:03   ` [PATCH 1/2] test: add known broken tests for recursive traversal of replies David Bremner
2022-01-08 14:03     ` [PATCH 2/2] python-cffi: returned OwnedMessage objects from Message.replies David Bremner
2022-01-08 18:59       ` Floris Bruynooghe
2022-01-09 13:26         ` David Bremner [this message]
2022-01-11 22:02           ` Floris Bruynooghe
2022-01-12  0:55             ` David Bremner
2022-01-09 13:27     ` [PATCH 1/2] test: add known broken tests for recursive traversal of replies David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878rvpt4yw.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=flub@devork.be \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).