From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cP6PAXhy62Ez5wAAgWs5BA (envelope-from ) for ; Sat, 22 Jan 2022 03:56:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 2HJ/Ondy62G4sgAA9RJhRA (envelope-from ) for ; Sat, 22 Jan 2022 03:56:55 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7567B15776 for ; Sat, 22 Jan 2022 03:56:55 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id D871D5F70E; Sat, 22 Jan 2022 02:56:50 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 63DFC5E016 for ; Sat, 22 Jan 2022 02:56:48 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 5D7F05FC01; Fri, 21 Jan 2022 21:56:47 -0500 (EST) Received: (nullmailer pid 1339609 invoked by uid 1000); Sat, 22 Jan 2022 02:56:46 -0000 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 2/4] test: define test_expect_equal_message_body In-Reply-To: References: <20220120123354.3999579-1-david@tethera.net> <20220120123354.3999579-3-david@tethera.net> Date: Fri, 21 Jan 2022 22:56:46 -0400 Message-ID: <878rv8fpg1.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: KYOXBRKFTP6BDHUSYSQH2I2IW7RL26ZO X-Message-ID-Hash: KYOXBRKFTP6BDHUSYSQH2I2IW7RL26ZO X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642820215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=RsDyXU7EeojTTZXJvJYq2apBFk2T4dT7wE64D+sKe7A=; b=AL0yuBSJVdLmvenHJyxZgoaeyqk+Fv6KgbivaowR3pnb16VYu9fgkoCvEe5pXuB1x/Mt5H F2kCAqZUHeFbcoiHIOoH47QC57NoWBTc8BrW8QoDgfGZuCvJCS/kac3iQWT8FjiIGPxKgN mWirT8Zgma7ZphgR/ybDO5UPDvqjqg+axc3mGyOwvUzPshNK01+a+0ho4YsKBgkaYZbLJq OFyF5ntBgWb2P2Ad8wJ1D2D2hcH5DU7hI9oBnBt0bu9M/NbgMrLImDl58G5MzfhnYfcjAM qG31mGMWNVBVsan1B45cQtZYnRDZRgndhIplH3RrdEwOE4+RyLTALOBYGpxm5Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642820215; a=rsa-sha256; cv=none; b=GZZPxvVTpkwMwsIkWDXtRBJvVY38K92eO/yVSquF4ojYHZVskTP+n+8h+9t7xID/IS0HJb XQvV6PzowNRIQ9cOx6WetGI68c38VRqZ87UnX07V5ei1wp4D6f2x03oaaa7zN2Fxg0wdtg QiG8X0jYIa3yKAWTPLMSHobZmaVCDv+hxC+Tk5hcwHzkSRDvuuvXIBFLtob/xxT0Pcb3H5 qMCovK5b75ZaMJOGHvokXVN3k05dzpafWgwIWr0oT82odoQkXh8C5s/3TSiwRKJH7/EF6K CEHhLSfCdUpWsCG5V5/81sEy6uDzzXvcooDbwBi34z1I2/5ZEeTS35nvQOPUDg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 7567B15776 X-Spam-Score: -2.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1W4MPloJgnx7 Tomi Ollila writes: > The above works, as we don't have whitespace ($IFS characters to be > precise) in the filenames. However, for better example, "$1" and "$2" > should be used (as is used in many of the functions in test-lib.sh > already. Makes sense, done (in private git) > The above prints out also the leading newline (which is OK), but if > one wanted those w/o the leading newline, the sed lines would be: > sed '1,/^$/d' Yeah, this a tougher call, but I decided to go with your version since I was editing the function anyway. It is (maybe) slightly easier to understand without sed -n. d