From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yO2oBclgCmJaQgEAgWs5BA (envelope-from ) for ; Mon, 14 Feb 2022 15:01:45 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eMNiAslgCmLdHAAAauVa8A (envelope-from ) for ; Mon, 14 Feb 2022 15:01:45 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9F5392A805 for ; Mon, 14 Feb 2022 15:01:39 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 44CF35F6DD; Mon, 14 Feb 2022 14:01:37 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id B43985F3FE for ; Mon, 14 Feb 2022 14:01:34 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id DE8025FBD2; Mon, 14 Feb 2022 09:01:33 -0500 (EST) Received: (nullmailer pid 3336160 invoked by uid 1000); Mon, 14 Feb 2022 14:01:10 -0000 From: David Bremner To: Tomi Ollila , Michael J Gruber Subject: Re: Test suite timing issues? In-Reply-To: References: <164458773197.3086.16103597141743611268.git@grubix.eu> <87k0e1x87f.fsf@tethera.net> <164467277576.6467.13919733764427871872.git@grubix.eu> <874k54xfuw.fsf@tethera.net> <87v8xjx048.fsf@tethera.net> Date: Mon, 14 Feb 2022 10:01:10 -0400 Message-ID: <878rudwnrt.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: ED2TMY6OB7GLPBW2LKMABV7IZYV6EE7F X-Message-ID-Hash: ED2TMY6OB7GLPBW2LKMABV7IZYV6EE7F X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644847299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=m+eITX82Gv3fZr8nkD87ly2+tYSOfR9viMT8YHDJ8hM=; b=qYFuEVRRv8klw+CJ23kNus2EeipS1KyKhgYundVfwtWT+DmXkQCbWjlajLHjRRxzGyoIDi nIdqojAhG90beIRDB5WE3kVkSPIggI2zor71ut1Me+ZJ6yA39ATo4LqbakB2JIZI434s8N H4bo+cMF166hE6P/Kt2+WyiiPiHkFxXMoitxz331IR8B5F2Eou0Kf7O2L4KrJcyub+NaM+ PRBBUBoF//G7GmNfKhSvq+wUpsKFT+69TgS8McFb7fjDAVDjmnWjkmWFTLyN9joj9T/h7j sppv1UiyGj2tciG7EeJptvvD9ZOjvo0BtxqPIMS9JaiR2B+Jhxy/pwiXspY8VQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644847299; a=rsa-sha256; cv=none; b=OshnTNOkrHvTf1+4UTK1l7oxQxI1/Q+dKyQp+UsGnksZD5nCdeGna4I8/Nikid7M2UiWPc 4CibjXhLikivYRWvK6tgw1692CgbpxhL4zAMzlgQk1RWN0tfMV8BBCxXUlfP/z1hxYD9la m7U88BNSP6HAft7hMc8IKXL0khB31VRTz8dIm/e0AAtHhMOcWGEbOuIvsdawrkKzJK8PZD JQ/PdJTDhZryAXBQivK+EBZNTwEbifG41uMIAckPo3xhWYK9ihvW48akEN5E121YdpwYCg HhbO7uvZHBnl5kreRQMjpn7ClrGbjGj+voEeOB0mju1vBTQ2c3f5vsJ+z8Y4Pw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 9F5392A805 X-Spam-Score: -1.34 X-Migadu-Scanner: scn1.migadu.com X-TUID: fHbE8US4Bt4i Tomi Ollila writes: > > Looked notmuch-new.c -- time_t (seconds since epoch) is used as timestamp > comparisons (which would indicate the subsecond resolution most fs' provide > is not used)... > > ... and if so, I wonder why some of our tests are not failing all the time > for everyone...? Not claiming everything is fine, but there is code there targetted at the failure mode you mentioned: /* If the directory's mtime is the same as the wall-clock time * when we stat'ed the directory, we skip updating the mtime in * the database because a message could be delivered later in this * same second. This may lead to unnecessary re-scans, but it * avoids overlooking messages. */ if (fs_mtime != stat_time) _filename_list_add (state->directory_mtimes, path)->mtime = fs_mtime; BTW, I have so far run the test suite 68 times in a row without failures on a Debian s390x host. The file system is ext4, mounted relatime. It would be interesting to know what file system is yielding the failures Michael is seeing.