From: Kevin Boulain <kevin@boula.in>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] test: showcase thread-unsafe s-expression query parser
Date: Sun, 06 Aug 2023 12:05:07 +0200 [thread overview]
Message-ID: <878rao32r0.fsf@boula.in> (raw)
In-Reply-To: <87ilabg4u1.fsf@tethera.net>
On 2023-07-22 at 15:48 -03, David Bremner <david@tethera.net> wrote:
>
> I can't get this test to fail at all. I'm not sure what to conclude from
> that. This is on a 20 core system running linux.
I can't really remember what I did at the time but I believe only the
test is instrumented and not the Notmuch library.
The test fails reliably when compiled like this:
./configure
make -j CFLAGS=-fsanitize=thread LDFLAGS=-fsanitize=thread
./test/T810-tsan.sh
# ...
# WARNING: ThreadSanitizer: data race (pid=35836)
# ...
I would say it would be best to run all the tests with the different
instrumentations enabled (for the best coverage) but I don't know if
there's a CI. Or if out-of-tree compilation is supported, I guess the
ASan and TSan tests could recompile the library with the instrumentation
enabled... What do you think?
next prev parent reply other threads:[~2023-08-06 10:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 20:31 [PATCH 1/2] test: showcase thread-unsafe s-expression query parser Kevin Boulain
2023-04-03 20:31 ` [PATCH 2/2] lib: thread-safe " Kevin Boulain
2023-07-22 19:06 ` David Bremner
2023-08-27 12:31 ` [PATCH v2 1/2] test: showcase thread-unsafe " Kevin Boulain
2023-09-19 10:30 ` David Bremner
2023-08-27 12:31 ` [PATCH v2 2/2] lib: thread-safe " Kevin Boulain
2024-07-25 10:23 ` David Bremner
2023-08-27 12:33 ` [PATCH " Kevin Boulain
2023-07-22 18:48 ` [PATCH 1/2] test: showcase thread-unsafe " David Bremner
2023-07-23 13:23 ` Michael J Gruber
2023-07-23 14:03 ` David Bremner
2023-08-06 10:05 ` Kevin Boulain [this message]
2023-08-06 12:01 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rao32r0.fsf@boula.in \
--to=kevin@boula.in \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).