[PATCH] Error out if no query is supplied to search instead of going into an infinite loop

[PATCH] Error out if no query is supplied to search instead of going into an infinite loop

[Alex Botero-Lowry]

[-- Attachment #1.1: Type: text/plain, Size: 1290 bytes --]

In this case error out when no query is supplied. There seems to be an
infinite-loop casued by i think notmuch_query_search_threads having
an exception:

A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>
A Xapian exception occurred: Syntax: <expression> AND <expression>

I'll look into that bug specifically a bit later.

It might be better to do a usage instead of just throwing an error here?

alex

[-- Attachment #1.2: Type: text/html, Size: 1553 bytes --]

[-- Attachment #2: 0001-Error-out-if-no-query-is-supplied-to-search-instead-.patch --]
[-- Type: application/octet-stream, Size: 794 bytes --]

From 3f9431f74a5ff66c84c869a3e26c2bad42bed1b1 Mon Sep 17 00:00:00 2001
From: Alexander Botero-Lowry <alex.boterolowry@gmail.com>
Date: Tue, 17 Nov 2009 16:20:28 -0800
Subject: [PATCH] Error out if no query is supplied to search instead of going into an infinite loop

---
 notmuch-search.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/notmuch-search.c b/notmuch-search.c
index 8db09c7..d94fccd 100644
--- a/notmuch-search.c
+++ b/notmuch-search.c
@@ -66,6 +66,11 @@ notmuch_search_command (void *ctx, int argc, char *argv[])
     argc -= i;
     argv += i;
 
+    if (argc == 0) {
+        fprintf (stderr, "No query provided\n");
+        return 1;
+    }
+
     config = notmuch_config_open (ctx, NULL, NULL);
     if (config == NULL)
 	return 1;
-- 
1.6.5.2

Re: [PATCH] Error out if no query is supplied to search instead of going into an infinite loop

[Carl Worth]

On Tue, 17 Nov 2009 16:23:53 -0800, Alex Botero-Lowry <alex.boterolowry@gmail.com> wrote:
> In this case error out when no query is supplied. There seems to be an
> infinite-loop casued by i think notmuch_query_search_threads having
> an exception:
> A Xapian exception occurred: Syntax: <expression> AND <expression>
> A Xapian exception occurred: Syntax: <expression> AND <expression>
> A Xapian exception occurred: Syntax: <expression> AND <expression>
> 
> I'll look into that bug specifically a bit later.
> 
> It might be better to do a usage instead of just throwing an error here?

Definitely.

Priit Laes reported the same thing in IRC and I've just committed a
patch to give a nice error message:

$ ./notmuch search
Error: notmuch search requires at least one search term.

Thanks for the report!

-Carl