[PATCH] Nuke the remainings of _notmuch_message_add_thread_id.

[PATCH] Nuke the remainings of _notmuch_message_add_thread_id.

[Fernando Carrijo]

The function _notmuch_message_add_thread_id has been removed
from the private interface of notmuch. There's no reason for
one to keep a declaration of its prototype in the code base.
Also, lets update a commentary that referenced that function
and escaped from previous scrutiny.

Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
---
 lib/database.cc       |    9 ++++-----
 lib/notmuch-private.h |    4 ----
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/lib/database.cc b/lib/database.cc
index 23ddd4a..b6c4d07 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -855,12 +855,11 @@ _notmuch_database_link_message_to_children (notmuch_database_t *notmuch,
  *
  * We first look at 'message_file' and its link-relevant headers
  * (References and In-Reply-To) for message IDs. We also look in the
- * database for existing message that reference 'message'.p
+ * database for existing message that reference 'message'.
  *
- * The end result is to call _notmuch_message_add_thread_id with one
- * or more thread IDs to which this message belongs, (including
- * generating a new thread ID if necessary if the message doesn't
- * connect to any existing threads).
+ * The end result is to call _notmuch_message_ensure_thread_id which
+ * generates a new thread ID if the message doesn't connect to any
+ * existing threads.
  */
 static notmuch_status_t
 _notmuch_database_link_message (notmuch_database_t *notmuch,
diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
index 0c340a7..116f63d 100644
--- a/lib/notmuch-private.h
+++ b/lib/notmuch-private.h
@@ -194,10 +194,6 @@ _notmuch_message_set_filename (notmuch_message_t *message,
 			       const char *filename);
 
 void
-_notmuch_message_add_thread_id (notmuch_message_t *message,
-				const char *thread_id);
-
-void
 _notmuch_message_ensure_thread_id (notmuch_message_t *message);
 
 void
-- 
1.5.6.3

Re: [PATCH] Nuke the remainings of _notmuch_message_add_thread_id.

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

On Wed, 09 Dec 2009 17:09:01 -0200, Fernando Carrijo <fcarrijo@yahoo.com.br> wrote:
> The function _notmuch_message_add_thread_id has been removed
> from the private interface of notmuch. There's no reason for
> one to keep a declaration of its prototype in the code base.
> Also, lets update a commentary that referenced that function
> and escaped from previous scrutiny.
> 
> Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>

Thanks, as always, for your careful cleanup.

This is now pushed.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]