unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Fernando Carrijo <fcarrijo@yahoo.com.br>
To: notmuch@notmuchmail.org
Subject: [PATCH] Nuke the remainings of _notmuch_message_add_thread_id.
Date: Wed, 09 Dec 2009 17:09:01 -0200	[thread overview]
Message-ID: <877hswyng2.fsf@yahoo.com.br> (raw)


The function _notmuch_message_add_thread_id has been removed
from the private interface of notmuch. There's no reason for
one to keep a declaration of its prototype in the code base.
Also, lets update a commentary that referenced that function
and escaped from previous scrutiny.

Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
---
 lib/database.cc       |    9 ++++-----
 lib/notmuch-private.h |    4 ----
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/lib/database.cc b/lib/database.cc
index 23ddd4a..b6c4d07 100644
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -855,12 +855,11 @@ _notmuch_database_link_message_to_children (notmuch_database_t *notmuch,
  *
  * We first look at 'message_file' and its link-relevant headers
  * (References and In-Reply-To) for message IDs. We also look in the
- * database for existing message that reference 'message'.p
+ * database for existing message that reference 'message'.
  *
- * The end result is to call _notmuch_message_add_thread_id with one
- * or more thread IDs to which this message belongs, (including
- * generating a new thread ID if necessary if the message doesn't
- * connect to any existing threads).
+ * The end result is to call _notmuch_message_ensure_thread_id which
+ * generates a new thread ID if the message doesn't connect to any
+ * existing threads.
  */
 static notmuch_status_t
 _notmuch_database_link_message (notmuch_database_t *notmuch,
diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h
index 0c340a7..116f63d 100644
--- a/lib/notmuch-private.h
+++ b/lib/notmuch-private.h
@@ -194,10 +194,6 @@ _notmuch_message_set_filename (notmuch_message_t *message,
 			       const char *filename);
 
 void
-_notmuch_message_add_thread_id (notmuch_message_t *message,
-				const char *thread_id);
-
-void
 _notmuch_message_ensure_thread_id (notmuch_message_t *message);
 
 void
-- 
1.5.6.3

             reply	other threads:[~2009-12-09 19:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-09 19:09 Fernando Carrijo [this message]
2009-12-09 20:10 ` [PATCH] Nuke the remainings of _notmuch_message_add_thread_id Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877hswyng2.fsf@yahoo.com.br \
    --to=fcarrijo@yahoo.com.br \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).