From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dme@dme.org>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 6CFEE4196F4
	for <notmuch@notmuchmail.org>; Mon,  5 Apr 2010 09:59:58 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
	tests=[BAYES_00=-1.9] autolearn=ham
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id FPxht8eTGzUz for <notmuch@notmuchmail.org>;
	Mon,  5 Apr 2010 09:59:56 -0700 (PDT)
Received: from mail-ww0-f53.google.com (mail-ww0-f53.google.com [74.125.82.53])
	by olra.theworths.org (Postfix) with ESMTP id 8D27E4196F0
	for <notmuch@notmuchmail.org>; Mon,  5 Apr 2010 09:59:56 -0700 (PDT)
Received: by wwb22 with SMTP id 22so2644269wwb.26
	for <notmuch@notmuchmail.org>; Mon, 05 Apr 2010 09:59:55 -0700 (PDT)
Received: by 10.216.86.3 with SMTP id v3mr520446wee.190.1270486795610;
	Mon, 05 Apr 2010 09:59:55 -0700 (PDT)
Received: from ut.hh.sledj.net (host83-217-165-81.dsl.vispa.com
	[83.217.165.81])
	by mx.google.com with ESMTPS id t12sm25558000gvd.21.2010.04.05.09.59.53
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Mon, 05 Apr 2010 09:59:54 -0700 (PDT)
Received: by ut.hh.sledj.net (Postfix, from userid 1000)
	id C63415941EC; Mon,  5 Apr 2010 17:59:51 +0100 (BST)
To: david@tethera.net, notmuch@notmuchmail.org
In-Reply-To: <1270485976-12776-1-git-send-email-david@tethera.net>
References: <1267015920-8999-1-git-send-email-david@tethera.net>
	<1270485976-12776-1-git-send-email-david@tethera.net>
From: David Edmondson <dme@dme.org>
Date: Mon, 05 Apr 2010 17:59:51 +0100
Message-ID: <877holal88.fsf@ut.hh.sledj.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Bremner <bremner@unb.ca>
Subject: Re: [PATCH v3] notmuch-query.el: new file to support access to the
 notmuch database.
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2010 16:59:58 -0000

On Mon,  5 Apr 2010 13:46:16 -0300, david@tethera.net wrote:
> diff --git a/emacs/notmuch-query.el b/emacs/notmuch-query.el
> new file mode 100644
> index 0000000..3f1a7b3
> --- /dev/null
> +++ b/emacs/notmuch-query.el
> @@ -0,0 +1,90 @@
> +; notmuch-query.el --- provide an emacs api to query notmuch

Should this comment prefix be ';;'? A single ';' is indented way over to
the right by default.

> +(defun notmuch-query-map-aux  (mapper function seq)
> +  "private function to do the actual mapping and flattening"
> +
> +  (apply 'append
> +	 (mapcar
> +	   (lambda (tree)
> +	     (funcall mapper fn tree))
> +	   seq)))
> +
> +

There are a bunch of spurious blank lines in various places.

dme.
-- 
David Edmondson, http://dme.org