unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Matthias Guedemann <Matthias.Guedemann@ovgu.de>
To: Dirk Hohndel <hohndel@infradead.org>,
	"notmuch\@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Re: problems with multipart/mixed
Date: Mon, 23 May 2011 15:39:07 +0200	[thread overview]
Message-ID: <877h9hmt8k.fsf@pc44es141.cs.uni-magdeburg.de> (raw)
In-Reply-To: <m3oc2tmzfp.fsf@x201s.gr8dns.org>


> If you did then I'm in the same boat. Notmuch/emacs used to display both

welcome to the boat!

I found the reason why that happens. Basically it appears because of a
bug in the ongoing multipart development.

In my example, the problem is as follows: currently the outer multipart
message gets ID 1, the first html part ID 2, and the attachment ID 3.

This seems to be correct in the JSON output. But for whatever reason,
show in emacs does not display the html part at all and the attachment
as text/html (it is text/plain). So it seems that the show is off by 1
somewhere.

Now a quick-and-dirty way around this:

reset to c51d5b3cdb5ca0816816e88ca6f7136a24e74eee

and apply this patch:


----8<---------
diff --git a/show-message.c b/show-message.c
index ff9146e..6913d7f 100644
--- a/show-message.c
+++ b/show-message.c
@@ -30,8 +30,8 @@ show_message_part (GMimeObject *part, int *part_count,
        GMimeMultipart *multipart = GMIME_MULTIPART (part);
        int i;
 
-       *part_count = *part_count + 1;
-       (*show_part) (part, part_count);
+       //*part_count = *part_count + 1;
+       //(*show_part) (part, part_count);
 
        for (i = 0; i < g_mime_multipart_get_count (multipart); i++) {
            show_message_part (g_mime_multipart_get_part (multipart, i),
----8<---------

current master is already some steps further, so probably this will be
fixed in a correct way soon, but for now I'll use this.

regards
Matthias

  reply	other threads:[~2011-05-23 13:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21  6:35 problems with multipart/mixed Matthias Guedemann
2011-05-23 11:25 ` Dirk Hohndel
2011-05-23 13:39   ` Matthias Guedemann [this message]
2011-05-23 21:38     ` Carl Worth
2011-05-24  2:46       ` Dirk Hohndel
2011-05-24 19:50         ` Carl Worth
2011-05-24 21:01           ` Dirk Hohndel
2011-05-24 22:06             ` Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877h9hmt8k.fsf@pc44es141.cs.uni-magdeburg.de \
    --to=matthias.guedemann@ovgu.de \
    --cc=hohndel@infradead.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).