From: Thomas Jost <schnouki@schnouki.net>
To: Ivy Foster <joyfulgirl@archlinux.us>, notmuch@notmuchmail.org
Subject: Re: [Patch] Fix Emacs interface bug dealing with invisible text
Date: Sun, 30 Oct 2011 10:58:55 +0100 [thread overview]
Message-ID: <877h3mhkbk.fsf@schnouki.net> (raw)
In-Reply-To: <878vo47i82.fsf@nausicaa.localdomain>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On Fri, 28 Oct 2011 20:29:49 -0400, Ivy Foster <joyfulgirl@archlinux.us> wrote:
> Hey, folks,
>
> I'm new to notmuch, but like much of what I've tried so far.
> Thanks to all the contributors!
>
> The following patch fixes a bug I've noticed in Emacs's
> notmuch-show mode. Specifically, if you:
>
> - have certain kinds of washing turned on (I've noticed
> it with signature hiding), and
>
> - are looking at the last or only message in a thread
>
> If you then hit Space (`notmuch-show-advance-or-archive') to
> move on, Emacs will fail to advance and/or archive the
> message, due to being kicked out of area of the invisible
> text before it can do what it's gotta do.
>
> The patch should fix the problem at the root, which seems to
> be with notmuch-show-move-past-invisible-[forward|backward].
Hi Ivy,
Thanks for this patch. I haven't tested it, but I will!
However, I'm wondering something: wasn't this issue already addressed in
Dmitry's patch series that I rebased and reposted almost a month ago,
specifically patches 9/13 to 12/13?
Patch 9/13 of the rebased series is
id:"1317660447-27520-10-git-send-email-schnouki@schnouki.net".
Regards,
--
Thomas/Schnouki
[-- Attachment #2: Type: application/pgp-signature, Size: 489 bytes --]
next prev parent reply other threads:[~2011-10-30 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-29 0:29 [Patch] Fix Emacs interface bug dealing with invisible text Ivy Foster
2011-10-30 9:58 ` Thomas Jost [this message]
2011-10-30 15:44 ` Ivy Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877h3mhkbk.fsf@schnouki.net \
--to=schnouki@schnouki.net \
--cc=joyfulgirl@archlinux.us \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).