From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bremner@unb.ca>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 30947431FAF
	for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 11:00:28 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -2.3
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6HOdnzvXR6LG for <notmuch@notmuchmail.org>;
	Sat, 21 Jan 2012 11:00:26 -0800 (PST)
Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 1F0D6431FAE
	for <notmuch@notmuchmail.org>; Sat, 21 Jan 2012 11:00:26 -0800 (PST)
Received: from zancas.localnet
	(fctnnbsc36w-156034071197.pppoe-dynamic.High-Speed.nb.bellaliant.net
	[156.34.71.197]) (authenticated bits=0)
	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q0LJ0NQm004319
	(version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
	Sat, 21 Jan 2012 15:00:24 -0400
Received: from bremner by zancas.localnet with local (Exim 4.77)
	(envelope-from <bremner@unb.ca>)
	id 1RogAp-0002Ps-3E; Sat, 21 Jan 2012 15:00:23 -0400
From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify
In-Reply-To: <20120112152652.GA18625@mit.edu>
References: <1324135695-15487-1-git-send-email-david@tethera.net>
	<1326197228-10356-1-git-send-email-david@tethera.net>
	<1326197228-10356-3-git-send-email-david@tethera.net>
	<20120112035739.GW20796@mit.edu> <87r4z56pbx.fsf@zancas.localnet>
	<20120112152652.GA18625@mit.edu>
User-Agent: Notmuch/0.11+89~g85665a2 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 21 Jan 2012 15:00:22 -0400
Message-ID: <877h0kdgop.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jan 2012 19:00:28 -0000

On Thu, 12 Jan 2012 10:26:52 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth David Bremner on Jan 12 at  9:08 am:
> > @@ -425,7 +420,7 @@ notmuch_search_command (void *ctx, int argc, char *argv[])
> >      int limit = -1; /* unlimited */
> >  
> >      enum { NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT }
> > -	format_sel = NOTMUCH_FORMAT_TEXT;
> > +    format_sel = NOTMUCH_FORMAT_TEXT;
> 
> This is unfortunate, but other than the format structure flattening,
> the remaining changes look reasonable to me.

I guess we have to accept that this is a big pile of heuristics, as long
as there are not too many cases to be overriden, it should still be a
net win.

FWIW An alternative formatting that does not confuse the indenter is

enum format_enum {
     NOTMUCH_FORMAT_JSON, NOTMUCH_FORMAT_TEXT
} format_sel = NOTMUCH_FORMAT_TEXT;