Re: [PATCH 1/2] test: emacs mailto: URI handling

[Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>]

Jameson Graef Rollins <jrollins@finestructure.net> writes:

> This adds a test for proposed rfc6068 "mailto:" URI handling.  The
> proposed function would be called 'notmuch-mua-mailto'.  The test
> provides an example mailto: string that should test some subset of the
> rfc6068 specification: http://tools.ietf.org/html/rfc6068

Hi! Just going through the patch queue. This test, at least, looks
sane, so why not apply it?

As for the mailto: handler itself, you wrote in
id:"87vcin2fo6.fsf@servo.finestructure.net" that you would add something
to the next version, thereby implying that there would be a next
version. Do you still intend to release such a new version soon? I would
love to review it. This version looks fine to me, with one minor concern.

> +	   ;; FIXME: need to decode all html encodings in uri.
> +	   (mailto (replace-regexp-in-string "&amp;" "&" mailto))

This is odd. Shouldn't the navigator be decoding all that stuff while
parsing, before you even get to it? How often do you get mailto links
with &amp; in them? You obviously wouldn't have put it in there if it
weren't necessary.

I would be +1 on merging this patch or the next version.

Ethan