From: Austin Clements <amdragon@MIT.EDU>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/7] emacs: Centralize notmuch command error handling
Date: Sat, 15 Dec 2012 14:45:47 -0500 [thread overview]
Message-ID: <877gojxfo4.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <m2obhvp9rl.fsf@guru.guru-group.fi>
On Sat, 15 Dec 2012, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Sat, Dec 15 2012, Austin Clements <amdragon@MIT.EDU> wrote:
>
>> This provides library functions for unified handling of errors from
>> the notmuch CLI. Follow-up patches will convert some scattered error
>> handling to use this and add error handling where we currently ignore
>> errors.
>> ---
>
> The series looks pretty good, some hardcoded patchs Mark noticed
> and it looks to me (after viewing id:8738z7hd6x.fsf@qmul.ac.uk
> that err -> nil could be done.
Fixed.
> Would (goto-char (point-min)) be needed before (insert msg) in
> this patch -- what If user has moved cursor while viewing old
> error messages but not pressed q (dismissed) on the buffer.
Good idea. Actually, I had intended to *append* the error to the buffer
so it would be in chronological order. I tweaked things a bit so
messages should always be appended and point will be left at the end of
the error log.
> Also, what about (unless (eobp) (insert "\n")) to add empty
> line between error messages ?
Done.
> Tomi
next prev parent reply other threads:[~2012-12-15 19:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 5:15 [PATCH 0/7] Improve Emacs CLI error handling Austin Clements
2012-12-15 5:15 ` [PATCH 1/7] emacs: Centralize notmuch command " Austin Clements
2012-12-15 16:20 ` Tomi Ollila
2012-12-15 19:45 ` Austin Clements [this message]
2012-12-15 5:15 ` [PATCH 2/7] emacs: Use unified error handling in notmuch-call-notmuch-process Austin Clements
2012-12-15 9:30 ` Mark Walters
2012-12-15 19:51 ` Austin Clements
2012-12-15 5:15 ` [PATCH 3/7] emacs: Factor out synchronous notmuch JSON invocations Austin Clements
2012-12-15 5:15 ` [PATCH 4/7] emacs: Improve error handling for notmuch-call-notmuch-json Austin Clements
2012-12-15 5:15 ` [PATCH 5/7] test: Test show's handling of subprocess errors Austin Clements
2012-12-15 5:15 ` [PATCH 6/7] emacs: Use unified error handling in search Austin Clements
2012-12-15 9:33 ` Mark Walters
2012-12-15 19:52 ` Austin Clements
2012-12-15 5:15 ` [PATCH 7/7] test: Test search's handling of subprocess errors Austin Clements
2012-12-15 9:48 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gojxfo4.fsf@awakening.csail.mit.edu \
--to=amdragon@mit.edu \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).