From: David Bremner <david@tethera.net>
To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/5] configure, test: Added variables for paths to true and false.
Date: Fri, 09 May 2014 07:14:15 +0900 [thread overview]
Message-ID: <877g5vvryg.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <m238gkpb7s.fsf@jane.lan>
Charles Celerier <cceleri@cs.stanford.edu> writes:
> I will be the first too admit that I do not know much about configure
> scripts, but adding a TRUE variable seemed straightforward.
configure is already big enough, I'd prefer not to add new things unless
they are needed. This is not likely to be something the user wants to
change, and (as you note below) it's pretty easy for the the Makefile or
tests to guess.
> You could use `$(which true)` in test/Makefile.local, but I felt the
> code repetition there was unecessary since you could just create a
> TRUE variable in the configure script.
well, it's not really code repetition because it is only used in that
one place.
> An alternative is to change the tests so that the location of true
> (and false) is no longer an issue.
Sure, that would be fine too.
d
next prev parent reply other threads:[~2014-05-08 22:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 17:02 [PATCH 0/5] Improving portability to Mac OS X Charles Celerier
2014-05-06 17:02 ` [PATCH 1/5] test/Makefile.local: Added configured TALLOC_LDFLAGS Charles Celerier
2014-05-06 17:02 ` [PATCH 2/5] configure, test: Added variables for paths to true and false Charles Celerier
2014-05-06 17:02 ` [PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later Charles Celerier
2014-05-06 17:02 ` [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Charles Celerier
2014-05-06 17:02 ` [PATCH 5/5] T360-symbol-hiding: Use nm instead of objdump Charles Celerier
2014-05-06 18:21 ` [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Tomi Ollila
2014-05-06 18:35 ` Charles Celerier
2014-05-06 19:09 ` Tomi Ollila
2014-05-06 18:26 ` [PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later Tomi Ollila
2014-05-08 12:32 ` [PATCH 2/5] configure, test: Added variables for paths to true and false David Bremner
2014-05-08 15:00 ` Charles Celerier
2014-05-08 22:14 ` David Bremner [this message]
2014-05-17 21:46 ` [PATCH 1/5] test/Makefile.local: Added configured TALLOC_LDFLAGS David Bremner
2014-05-07 3:50 ` [PATCH v2 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X Charles Celerier
2014-05-07 3:50 ` [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump Charles Celerier
2014-05-08 13:06 ` David Bremner
2014-05-08 15:03 ` Charles Celerier
2014-05-08 22:07 ` David Bremner
2014-05-09 1:20 ` Charles Celerier
2014-05-10 9:49 ` David Bremner
2014-05-10 14:55 ` Charles Celerier
2014-07-12 19:00 ` David Bremner
2014-07-13 15:36 ` [PATCH v2 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g5vvryg.fsf@maritornes.cs.unb.ca \
--to=david@tethera.net \
--cc=cceleri@cs.stanford.edu \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).