From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 5F5FD6DE1994
 for <notmuch@notmuchmail.org>; Fri,  3 Apr 2015 16:03:47 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 1.23
X-Spam-Level: *
X-Spam-Status: No, score=1.23 tagged_above=-999 required=5 tests=[AWL=0.426,
 DATE_IN_PAST_12_24=0.804] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id pM3q-5TGm5q9 for <notmuch@notmuchmail.org>;
 Fri,  3 Apr 2015 16:03:45 -0700 (PDT)
Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
 [87.98.215.224])
 by arlo.cworth.org (Postfix) with ESMTPS id AE7F56DE1992
 for <notmuch@notmuchmail.org>; Fri,  3 Apr 2015 16:03:45 -0700 (PDT)
Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
 4.80) (envelope-from <david@tethera.net>)
 id 1YdXGE-0003SI-Vg; Thu, 02 Apr 2015 05:01:47 +0000
Received: (nullmailer pid 22244 invoked by uid 1000); Wed, 01 Apr 2015
 06:59:29 -0000
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: show: hide large text attachments by default
In-Reply-To: <1427540939-10055-1-git-send-email-markwalters1009@gmail.com>
References: <1427540939-10055-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1
 (x86_64-pc-linux-gnu)
Date: Wed, 01 Apr 2015 08:59:29 +0200
Message-ID: <877ftw49m6.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Apr 2015 23:03:47 -0000

Mark Walters <markwalters1009@gmail.com> writes:

>
> This code is getting a little fragile -- there are quite a lot of
> factors in deciding whether to show or hide a part and the code is
> called from both show and reply -- but it seems to work. For testing I
> suggest setting notmuch-show-max-text-part-size to something small
> like 100 or 1000.

The change looks ok, and as I mentioned it in a previous mail, it seems
to work well, at least for the notmuch-show bottleneck I know how to
test.

d