From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 05/14] cli/reply: reorganize create_reply_message()
Date: Sat, 10 Sep 2016 13:21:19 -0300 [thread overview]
Message-ID: <877faj20ao.fsf@zancas.localnet> (raw)
In-Reply-To: <b56dcdd19ee572f1b895ba634644e0f3bfb69e11.1471088022.git.jani@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> Again, in preparation for later unification, reorganize
> create_reply_message() to be more similar to the open coded version in
> the headers-only format reply code. Due to "pretty" header ordering,
> there should be no change in output. There should be no functional
> changes.
The patch looks ok. The term "open coded" might be a little too jargony
/ technical.
d
next prev parent reply other threads:[~2016-09-10 16:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 11:37 [PATCH v2 00/14] reply refactor, fixes Jani Nikula
2016-08-13 11:37 ` [PATCH v2 01/14] test: add known broken test for reply to message with multiple Cc headers Jani Nikula
2016-09-10 0:43 ` David Bremner
2016-09-10 22:17 ` David Bremner
2016-09-11 11:49 ` Jani Nikula
2016-08-13 11:37 ` [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack Jani Nikula
2016-09-10 0:53 ` David Bremner
2016-09-10 6:20 ` Jani Nikula
2016-08-13 11:37 ` [PATCH v2 03/14] cli/reply: reuse show_reply_headers() in headers-only format Jani Nikula
2016-08-13 11:37 ` [PATCH v2 04/14] cli/reply: unify reply format functions Jani Nikula
2016-09-10 1:38 ` David Bremner
2016-09-10 6:26 ` Jani Nikula
2016-08-13 11:37 ` [PATCH v2 05/14] cli/reply: reorganize create_reply_message() Jani Nikula
2016-09-10 16:21 ` David Bremner [this message]
2016-08-13 11:37 ` [PATCH v2 06/14] cli/reply: make references header creation easier to follow Jani Nikula
2016-09-10 16:23 ` David Bremner
2016-08-13 11:37 ` [PATCH v2 07/14] cli/reply: reuse create_reply_message() also for headers-only format Jani Nikula
2016-08-13 11:37 ` [PATCH v2 08/14] cli/reply: reduce the reply format abstractions Jani Nikula
2016-09-10 16:33 ` David Bremner
2016-08-13 11:37 ` [PATCH v2 09/14] cli/reply: use dedicated functions for reply to mapping Jani Nikula
2016-08-13 11:37 ` [PATCH v2 10/14] cli/reply: check for NULL list first in scan_address_list() Jani Nikula
2016-08-13 11:37 ` [PATCH v2 11/14] cli/reply: return internet address list from get header funcs Jani Nikula
2016-09-10 22:46 ` David Bremner
2016-08-13 11:37 ` [PATCH v2 12/14] cli/reply: pass internet address list to munge detect Jani Nikula
2016-09-10 22:51 ` David Bremner
2016-08-13 11:37 ` [PATCH v2 13/14] cli/reply: pass gmime message to munge detection Jani Nikula
2016-09-10 22:58 ` David Bremner
2016-08-13 11:37 ` [PATCH v2 14/14] cli/reply: only pass gmime message to add recipients to reply message Jani Nikula
2016-09-10 23:00 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877faj20ao.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).