unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Subject: Re: [PATCH] emacs: reply: remove wrong sig/enc status buttons
Date: Sun, 11 Sep 2016 22:11:44 -0300	[thread overview]
Message-ID: <877fahq5v3.fsf@zancas.localnet> (raw)
In-Reply-To: <1473610121-4450-1-git-send-email-markwalters1009@gmail.com>

Mark Walters <markwalters1009@gmail.com> writes:

> This stopps the (usually incorrect) sigstatus and encstatus buttons
> appearing when replying in emacs, and updates the test suite to match.
>
> Overriding the status button functions is a little unusual but much
> less intrusive than passing an argument all the way down the call
> chain. It also makes it clear exactly what it does.
> ---
>
> I dont't have any encrypted messages for testing but it seems to work
> on signed messages (but even that is very lightly tested). 

In replies encrypted messages there is an extra line saying Version:
1. This is from the first part part of the multipart encrypted

└┬╴multipart/encrypted 6845 bytes
 ├─╴application/pgp-encrypted attachment [PGPMIME version identification] 11 bytes
 └─╴application/octet-stream inline [encrypted.asc] 2708 bytes

I'm not really sure it's useful to display in notmuch-show mode
either. If not, that would fix it here also. Perhaps Daniel can comment
on whether it makes sense to just drop it.

d

  reply	other threads:[~2016-09-12  1:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-11 16:08 [PATCH] emacs: reply: remove wrong sig/enc status buttons Mark Walters
2016-09-12  1:11 ` David Bremner [this message]
2016-09-12 16:57   ` Daniel Kahn Gillmor
2016-09-12 22:12   ` [PATCH v2] " Mark Walters
2016-09-12 23:30     ` Daniel Kahn Gillmor
2016-09-13  7:35       ` Mark Walters
2016-09-13 10:41       ` David Bremner
2016-09-13  1:45     ` David Bremner
2016-09-13  1:45       ` [PATCH 1/2] test/crypto: test reply to encrypted message in emacs David Bremner
2016-09-18 14:08         ` David Bremner
2016-09-13  1:45       ` [PATCH 2/2] emacs: reply: remove wrong sig/enc status buttons David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fahq5v3.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=dkg@fifthhorseman.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).