[PATCH] test/emacs: add broken test for message replying to msg to self

[PATCH] test/emacs: add broken test for message replying to msg to self

[David Bremner]

This is a strange corner case where the removing of the user's address
from the To: header does the wrong thing. If we think it is
worth (eventually) fixing, this test can serve as a reminder.
---
 test/T310-emacs.sh | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
index 21675b6..01385ae 100755
--- a/test/T310-emacs.sh
+++ b/test/T310-emacs.sh
@@ -521,6 +521,30 @@ Notmuch Test Suite <test_suite@notmuchmail.org> writes:
 EOF
 test_expect_equal_file OUTPUT EXPECTED
 
+test_begin_subtest "Reply within emacs to message from self"
+test_subtest_known_broken
+add_message '[from]="test_suite@notmuchmail.org"' \
+	    '[to]="test_suite@notmuchmail.org"'
+test_emacs "(let ((message-hidden-headers '()))
+	    (notmuch-show \"id:${gen_msg_id}\")
+	    (notmuch-show-reply)
+	    (test-output))"
+sed -i -e 's/^In-Reply-To: <.*>$/In-Reply-To: <XXX>/' OUTPUT
+sed -i -e 's/^References: <.*>$/References: <XXX>/' OUTPUT
+cat <<EOF >EXPECTED
+From: Notmuch Test Suite <test_suite@notmuchmail.org>
+To: test_suite@notmuchmail.org
+Subject: Re: Reply within emacs to message from self
+In-Reply-To: <XXX>
+Fcc: ${MAIL_DIR}/sent
+References: <XXX>
+--text follows this line--
+test_suite@notmuchmail.org writes:
+
+> This is just a test message (#7)
+EOF
+test_expect_equal_file EXPECTED OUTPUT
+
 test_begin_subtest "Quote MML tags in reply"
 message_id='test-emacs-mml-quoting@message.id'
 add_message [id]="$message_id" \
-- 
2.9.3

Re: [PATCH] test/emacs: add broken test for message replying to msg to self

[Mark Walters]

On Tue, 13 Sep 2016, David Bremner <david@tethera.net> wrote:
> This is a strange corner case where the removing of the user's address
> from the To: header does the wrong thing. If we think it is
> worth (eventually) fixing, this test can serve as a reminder.

Hi I haven't tested the patch, but I think it worth having as a
reminder.  Presumably you ran into the bug yourself, and I think I have
at some point, so people probably are hitting it.

Best wishes

Mark



> ---
>  test/T310-emacs.sh | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/test/T310-emacs.sh b/test/T310-emacs.sh
> index 21675b6..01385ae 100755
> --- a/test/T310-emacs.sh
> +++ b/test/T310-emacs.sh
> @@ -521,6 +521,30 @@ Notmuch Test Suite <test_suite@notmuchmail.org> writes:
>  EOF
>  test_expect_equal_file OUTPUT EXPECTED
>  
> +test_begin_subtest "Reply within emacs to message from self"
> +test_subtest_known_broken
> +add_message '[from]="test_suite@notmuchmail.org"' \
> +	    '[to]="test_suite@notmuchmail.org"'
> +test_emacs "(let ((message-hidden-headers '()))
> +	    (notmuch-show \"id:${gen_msg_id}\")
> +	    (notmuch-show-reply)
> +	    (test-output))"
> +sed -i -e 's/^In-Reply-To: <.*>$/In-Reply-To: <XXX>/' OUTPUT
> +sed -i -e 's/^References: <.*>$/References: <XXX>/' OUTPUT
> +cat <<EOF >EXPECTED
> +From: Notmuch Test Suite <test_suite@notmuchmail.org>
> +To: test_suite@notmuchmail.org
> +Subject: Re: Reply within emacs to message from self
> +In-Reply-To: <XXX>
> +Fcc: ${MAIL_DIR}/sent
> +References: <XXX>
> +--text follows this line--
> +test_suite@notmuchmail.org writes:
> +
> +> This is just a test message (#7)
> +EOF
> +test_expect_equal_file EXPECTED OUTPUT
> +
>  test_begin_subtest "Quote MML tags in reply"
>  message_id='test-emacs-mml-quoting@message.id'
>  add_message [id]="$message_id" \
> -- 
> 2.9.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test/emacs: add broken test for message replying to msg to self

[David Bremner]

David Bremner <david@tethera.net> writes:

> This is a strange corner case where the removing of the user's address
> from the To: header does the wrong thing. If we think it is
> worth (eventually) fixing, this test can serve as a reminder.
> ---
>  test/T310-emacs.sh | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)

pushed,

d