From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH] test: verify test database v1 checksum in more portable way
Date: Sun, 12 Mar 2017 19:33:01 -0300 [thread overview]
Message-ID: <877f3up1lu.fsf@tethera.net> (raw)
In-Reply-To: <20170312183155.12481-1-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> Replaced use of sha256 (gnu coreutils binary) with more portable
> openssl sha256 execution.
> ---
>
> Works on Linux and also on my FreeBSD KVM environment.
There's a tradeoff here. In a minimal GNU/Linux environment coreutils is
there but not openssl. So I don't mind the substitution (for the test
suite), but I think you need to add a
"test_require_external prereq openssl" or equivalent to T530-upgrade.sh
This will also require adding openssl as a debian build dependency; I
can also live with that, although it might inconvenience some people
building the debian-snapshot target.
There's something aesthetically displeasing about hardcoding the
checksum into the test script but I think I'm just grumbling at this
point.
next prev parent reply other threads:[~2017-03-12 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 12:59 [PATCH] test-databases: use wget or curl to download test databases Tomi Ollila
2017-03-12 18:31 ` [PATCH] test: verify test database v1 checksum in more portable way Tomi Ollila
2017-03-12 22:33 ` David Bremner [this message]
2017-03-13 19:32 ` Tomi Ollila
2017-03-14 15:39 ` [PATCH] test-databases: use wget or curl to download test databases David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877f3up1lu.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).