From: William Casarin <jb55@jb55.com>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments
Date: Sat, 14 Oct 2017 12:39:46 -0700 [thread overview]
Message-ID: <877evx34e5.fsf@jb55.com> (raw)
In-Reply-To: <20171014131608.17587-1-jani@nikula.org>
Hey Jani,
Patches look good so far, concept ack for sure.
Jani Nikula <jani@nikula.org> writes:
> For example, you can use --no-exclude instead of --exclude=false in
> notmuch show. If we had keyword flag arguments with some flags
> defaulting to on, say --include=tags in notmuch dump/restore, this
> would allow --no-include=tags to switch that off while not affecting
> other flags.
I've been testing it a bit, I can't seem to make this work in this example:
./notmuch count --no-exclude
After some brief investigation it might be because count is using
EXCLUDE_true(1) and EXCLUDE_false(0) which are not equal to
NOTMUCH_EXCLUDE_TRUE(1) and NOTMUCH_EXCLUDE_FALSE(2), but I'm not sure.
Cheers,
William
--
https://jb55.com
next prev parent reply other threads:[~2017-10-14 19:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 13:16 [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments Jani Nikula
2017-10-14 13:16 ` [PATCH 2/3] cli: use the negating boolean support for new and insert --no-hooks Jani Nikula
2017-10-14 13:16 ` [PATCH 3/3] test: expand argument parsing sanity checks Jani Nikula
2017-12-13 12:34 ` David Bremner
2017-10-14 19:39 ` William Casarin [this message]
2017-10-14 20:21 ` [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments Jani Nikula
2017-10-14 21:11 ` William Casarin
2017-10-14 21:16 ` William Casarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877evx34e5.fsf@jb55.com \
--to=jb55@jb55.com \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).