Re: [PATCH v2 1/2] emacs: Optionally check for missing attachments in outgoing messages

[David Bremner <david@tethera.net>]

David Edmondson <dme@dme.org> writes:

> Query the user if the message text indicates that an attachment is
> expected but no MML referencing an attachment is found.
>
> This is not enabled by default - see the documentation for
> `notmuch-mua-attachment-check'.
> ---
>  emacs/notmuch-mua.el | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index fc8ac687..13759c73 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -115,8 +115,45 @@ multiple parts get a header."
>  		(function :tag "Other"))
>    :group 'notmuch-reply)
>  
> +(defcustom notmuch-mua-attachment-regexp
> +  "\\b\\(attache\?ment\\|attached\\|attach\\|pi[èe]ce\s+jointe?\\)\\b"
> +  "Message body text indicating that an attachment is expected.
> +
> +This is not used unless `notmuch-mua-attachment-check' is added
> +to `notmuch-mua-send-hook'.")
> +
>  ;;

notmuch-mua-send-hook is not firing for me. I ran the following test

./devel/try-emac-mua -q

(add-hook 'notmuch-mua-send-hook (lambda () (error "boo!"))) C-x C-e
(notmuch-hello) C-x C-e
m
delete Fcc header
C-c C-c
select trasport

Nothing in messages from my hook, no traceback.

This is not caused by your patches, but seems like we should figure out
what's going on?