From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id BBFA66DE106F
 for <notmuch@notmuchmail.org>; Thu, 23 May 2019 04:40:20 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.039
X-Spam-Level: 
X-Spam-Status: No, score=-0.039 tagged_above=-999 required=5
 tests=[AWL=-0.038, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 8P9hfoC-ascU for <notmuch@notmuchmail.org>;
 Thu, 23 May 2019 04:40:19 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id CEECC6DE106B
 for <notmuch@notmuchmail.org>; Thu, 23 May 2019 04:40:19 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>) id 1hTm55-00017Y-22
 for notmuch@notmuchmail.org; Thu, 23 May 2019 07:40:19 -0400
Received: (nullmailer pid 25956 invoked by uid 1000);
 Thu, 23 May 2019 11:40:29 -0000
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] n_m_remove_indexed_terms: reduce number of Xapian
 API calls.
In-Reply-To: <20190416014616.31623-3-david@tethera.net>
References: <20190416014616.31623-1-david@tethera.net>
 <20190416014616.31623-3-david@tethera.net>
Date: Thu, 23 May 2019 08:40:29 -0300
Message-ID: <877eahpff6.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 23 May 2019 11:40:20 -0000

David Bremner <david@tethera.net> writes:

> Previously this functioned scanned every term attached to a given
> Xapian document. It turns out we know how to read only the terms we
> need to preserve (and we might have already done so). This commit
> replaces many calls to Xapian::Document::remove_term with one call to
> ::clear_terms, and a (typically much smaller) number of calls to
> ::add_term. Roughly speaking this is based on the assumption that most
> messages have more text than they have tags.

pushed to master.

d