Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region

[Leo Vivier <leo.vivier@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 393 bytes --]

Hello,

David Bremner <david@tethera.net> writes:

[...]

> I would mention the actual function name in the subject.

Done.  

> I think 0.28.1 should be 0.29, no?

Changed it to 0.29.  I wasn’t sure whether to use the version number or
the commit ID.

Best,

-- 
Leo Vivier
English Studies & General Linguistics
Master Student, English Department
Université Rennes 2

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emacs-make-notmuch-search-interactive-region-obsolet.patch --]
[-- Type: text/x-patch, Size: 1117 bytes --]

From a74a1cf358a768d89b68698fd3eeea198bf92b0d Mon Sep 17 00:00:00 2001
From: Leo Vivier <leo.vivier@gmail.com>
Date: Mon, 20 May 2019 14:21:13 +0200
Subject: [PATCH] emacs: make notmuch-search-interactive-region obsolete

`notmuch-search-interactive-region' was moved to notmuch-lib.el in
f3cba19f882471a396a6b6175a709ccd1f6f34a0 and renamed to
`notmuch-interactive-region' without making the old function
obsolete, thereby breaking user-commands which made use of it.

This commit marks the function as obsolete and makes it an alias for
the new function.
---
 emacs/notmuch-lib.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 7fc342a5..8acad267 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -1017,6 +1017,11 @@ region if the region is active, or both `point' otherwise."
       (list (region-beginning) (region-end))
     (list (point) (point))))
 
+(define-obsolete-function-alias
+    'notmuch-search-interactive-region
+    'notmuch-interactive-region
+  "notmuch 0.29")
+
 (provide 'notmuch-lib)
 
 ;; Local Variables:
-- 
2.21.0