From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 5B3186DE0EC6 for ; Tue, 28 May 2019 04:10:23 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.043 X-Spam-Level: X-Spam-Status: No, score=-0.043 tagged_above=-999 required=5 tests=[AWL=-0.042, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PF_KoyTk1gbc for ; Tue, 28 May 2019 04:10:22 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 92E916DE0EB5 for ; Tue, 28 May 2019 04:10:22 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hVZzp-0003w9-HY; Tue, 28 May 2019 07:10:21 -0400 Received: (nullmailer pid 16276 invoked by uid 1000); Tue, 28 May 2019 11:10:35 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH v4 06/17] cli/show: add information about which headers were protected In-Reply-To: <20190527221416.9708-1-dkg@fifthhorseman.net> References: <871s0kkxy3.fsf@tethera.net> <20190527221416.9708-1-dkg@fifthhorseman.net> Date: Tue, 28 May 2019 08:10:35 -0300 Message-ID: <877eaavnpw.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 May 2019 11:10:23 -0000 Daniel Kahn Gillmor writes: > decrypted?: { > status: msgdecstatus, > + # map encrypted headers that differed from the outside headers. > + # the value of each item in the map is what that field showed externally > + # (maybe null if it was not present in the external headers). > + header-mask: { header_name: string|null,*} > } Apologies for not catching this before (and for fussing so much about the schemata file), but this notation for repeated key-value pairs doesn't seem ideal to me. I would say either header-mask: { (header_name: string|null)* } header-mask: { header_name*: string|null } Either would need a brief explanation above, as this the first map defined with an arbitrary number of members.