From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 0B0276DE0F3E
 for <notmuch@notmuchmail.org>; Tue, 23 Jul 2019 07:57:26 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.051
X-Spam-Level: 
X-Spam-Status: No, score=-0.051 tagged_above=-999 required=5
 tests=[AWL=-0.050, SPF_PASS=-0.001] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id sMB_2UxAy3Vp for <notmuch@notmuchmail.org>;
 Tue, 23 Jul 2019 07:57:25 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 0ADBA6DE0F22
 for <notmuch@notmuchmail.org>; Tue, 23 Jul 2019 07:57:24 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1hpwED-00068V-Ed; Tue, 23 Jul 2019 10:57:21 -0400
Received: (nullmailer pid 29194 invoked by uid 1000);
 Tue, 23 Jul 2019 14:57:14 -0000
From: David Bremner <david@tethera.net>
To: Ralph Seichter <abbot@monksofcool.net>, notmuch@notmuchmail.org
Subject: Re: Bug: SIGABRT if "notmuch dump" output file is not writeable
In-Reply-To: <87blxlmyjf.fsf@ra.horus-it.com>
References: <877e8929g8.fsf@ra.horus-it.com> <87d0i1u36h.fsf@tethera.net>
 <87blxlmyjf.fsf@ra.horus-it.com>
Date: Tue, 23 Jul 2019 11:57:14 -0300
Message-ID: <877e88u7cl.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Jul 2019 14:57:26 -0000

Ralph Seichter <abbot@monksofcool.net> writes:

> * David Bremner:
>
>> I agree it's a bit ugly to look at.
>
> Ah, euphemisms. ;-) Personally, I associate "double free or corruption
> (!prev)" with memory trouble or situations where a library cannot
> recover from an error state and needs to bail out using abort(). Not
> being able to (over)write an existing file is not that serious, IMO.

Yes, but that's a message / abort from deep within libz. So odds of our
being able to fix it are pretty small. Checking for permissions before
hand would just introduce a race condition (I _think_).

>
>> Do you see any database corruption or more serious issues?
>
> No, and I don't expect any, as I am assuming that "notmuch dump" will
> only ever read the DB.

That's true, but it does take write lock on the database so that
one dumps a consistent state.

d