From: David Bremner <david@tethera.net>
To: Ralph Seichter <abbot@monksofcool.net>, notmuch@notmuchmail.org
Subject: Re: Bug: SIGABRT if "notmuch dump" output file is not writeable
Date: Tue, 23 Jul 2019 11:57:14 -0300 [thread overview]
Message-ID: <877e88u7cl.fsf@tethera.net> (raw)
In-Reply-To: <87blxlmyjf.fsf@ra.horus-it.com>
Ralph Seichter <abbot@monksofcool.net> writes:
> * David Bremner:
>
>> I agree it's a bit ugly to look at.
>
> Ah, euphemisms. ;-) Personally, I associate "double free or corruption
> (!prev)" with memory trouble or situations where a library cannot
> recover from an error state and needs to bail out using abort(). Not
> being able to (over)write an existing file is not that serious, IMO.
Yes, but that's a message / abort from deep within libz. So odds of our
being able to fix it are pretty small. Checking for permissions before
hand would just introduce a race condition (I _think_).
>
>> Do you see any database corruption or more serious issues?
>
> No, and I don't expect any, as I am assuming that "notmuch dump" will
> only ever read the DB.
That's true, but it does take write lock on the database so that
one dumps a consistent state.
d
next prev parent reply other threads:[~2019-07-23 14:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:47 Bug: SIGABRT if "notmuch dump" output file is not writeable Ralph Seichter
2019-07-22 22:15 ` David Bremner
2019-07-22 23:37 ` Ralph Seichter
2019-07-23 14:57 ` David Bremner [this message]
2019-07-23 17:38 ` Ralph Seichter
2019-07-23 18:53 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e88u7cl.fsf@tethera.net \
--to=david@tethera.net \
--cc=abbot@monksofcool.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).