From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MLsABcNyzV5BEwAA0tVLHw (envelope-from ) for ; Tue, 26 May 2020 19:49:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YDuvAMNyzV55DwAAbx9fmQ (envelope-from ) for ; Tue, 26 May 2020 19:49:23 +0000 Received: from arlo.cworth.org (arlo.cworth.org [50.126.95.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 754239402D1 for ; Tue, 26 May 2020 19:49:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 2D0F86DE13A5; Tue, 26 May 2020 12:49:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LVvbhJZah-FW; Tue, 26 May 2020 12:49:15 -0700 (PDT) Received: from arlo.cworth.org (localhost [IPv6:::1]) by arlo.cworth.org (Postfix) with ESMTP id 0B0BF6DE13BE; Tue, 26 May 2020 12:49:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id EEA736DE13BE for ; Tue, 26 May 2020 12:49:13 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Mq3tTwy7Z8pc for ; Tue, 26 May 2020 12:49:12 -0700 (PDT) Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) by arlo.cworth.org (Postfix) with ESMTPS id 3B4466DE13A5 for ; Tue, 26 May 2020 12:49:10 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id CCAF01668B; Tue, 26 May 2020 21:49:06 +0200 (CEST) X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10124) with ESMTP id gFJZ_0X4_Nen; Tue, 26 May 2020 21:49:06 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 645A416660; Tue, 26 May 2020 21:49:06 +0200 (CEST) From: Jonas Bernoulli To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests In-Reply-To: <87v9kl3sq4.fsf@tethera.net> References: <20200415182822.10841-1-jonas@bernoul.li> <20200425201809.16503-1-jonas@bernoul.li> <20200425201809.16503-2-jonas@bernoul.li> <87v9kl3sq4.fsf@tethera.net> Date: Tue, 26 May 2020 21:49:00 +0200 Message-ID: <877dwyv5n7.fsf@bernoul.li> MIME-Version: 1.0 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: notmuch-bounces@notmuchmail.org Sender: "notmuch" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 50.126.95.6 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -1.01 X-TUID: 6YDwLPiSF3tN David Bremner writes: > Jonas Bernoulli writes: > >> +compile-elisp-tests: >> + $(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \ >> + batch-byte-compile test/*.el >> + > > Can you explain a bit (perhaps in an updated commit message) why we need > this target? The tests might have issues that can be detected by the byte-compiler. The only issue that I actually did detect was the one fixed by 3/3, which is a very minor cosmetic issue. However if someone modified the tests, then they might of course add more serious issues. If they ran this target, then they might detect that. But they might forget to do so. They might also forget to re-run this target after making changes. Therefore I retract this commit at least in the current form. I might include an improved more thoroughly described version of this in a later patch series. For now please just apply 3/3. Jonas