From: Jonas Bernoulli <jonas@bernoul.li>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests
Date: Tue, 26 May 2020 21:49:00 +0200 [thread overview]
Message-ID: <877dwyv5n7.fsf@bernoul.li> (raw)
In-Reply-To: <87v9kl3sq4.fsf@tethera.net>
David Bremner <david@tethera.net> writes:
> Jonas Bernoulli <jonas@bernoul.li> writes:
>
>> +compile-elisp-tests:
>> + $(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \
>> + batch-byte-compile test/*.el
>> +
>
> Can you explain a bit (perhaps in an updated commit message) why we need
> this target?
The tests might have issues that can be detected by the byte-compiler.
The only issue that I actually did detect was the one fixed by 3/3,
which is a very minor cosmetic issue.
However if someone modified the tests, then they might of course add
more serious issues. If they ran this target, then they might detect
that. But they might forget to do so. They might also forget to re-run
this target after making changes.
Therefore I retract this commit at least in the current form. I might
include an improved more thoroughly described version of this in a later
patch series. For now please just apply 3/3.
Jonas
next prev parent reply other threads:[~2020-05-26 19:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 18:28 [PATCH 0/4] Use cl-lib instead of deprecated cl Jonas Bernoulli
2020-04-15 18:28 ` [PATCH 1/4] gitignore: Ignore generated python-cffi files Jonas Bernoulli
2020-04-15 18:28 ` [PATCH 2/4] emacs: Declare function notmuch-show-get-message-id Jonas Bernoulli
2020-04-16 11:11 ` David Bremner
2020-04-15 18:28 ` [PATCH 3/4] emacs: Explicitly depend on Emacs 24 Jonas Bernoulli
2020-04-15 18:28 ` [PATCH 4/4] emacs: Use `cl-lib' instead of deprecated `cl' Jonas Bernoulli
2020-04-16 11:27 ` David Edmondson
2020-04-16 17:27 ` [PATCH] " William Casarin
2020-04-17 11:06 ` David Bremner
2020-04-17 15:05 ` Jonas Bernoulli
2020-04-21 14:22 ` David Bremner
2020-04-25 20:24 ` Jonas Bernoulli
2020-04-27 10:43 ` David Bremner
2020-04-17 15:00 ` [PATCH v2] " Jonas Bernoulli
2020-04-25 20:18 ` [PATCH v3 1/3] " Jonas Bernoulli
2020-04-25 20:18 ` [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests Jonas Bernoulli
2020-05-24 21:53 ` David Bremner
2020-05-26 19:49 ` Jonas Bernoulli [this message]
2020-04-25 20:18 ` [PATCH v3 3/3] emacs: Use `dolist' instead of `mapcar' for side-effects Jonas Bernoulli
2020-05-24 19:27 ` Tomi Ollila
2020-05-26 23:40 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dwyv5n7.fsf@bernoul.li \
--to=jonas@bernoul.li \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).