From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 0HCRGctYh2IGoAAAbAwnHQ (envelope-from ) for ; Fri, 20 May 2022 11:00:59 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 4NGxGctYh2KXkAAA9RJhRA (envelope-from ) for ; Fri, 20 May 2022 11:00:59 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 91DA530ED7 for ; Fri, 20 May 2022 11:00:58 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 75DAB5F775; Fri, 20 May 2022 09:00:55 +0000 (UTC) X-Greylist: delayed 473 seconds by postgrey-1.36 at yantan; Fri, 20 May 2022 09:00:51 UTC Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by mail.notmuchmail.org (Postfix) with ESMTPS id C48C85F6DA for ; Fri, 20 May 2022 09:00:51 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 1055F2B007D8; Fri, 20 May 2022 04:52:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 20 May 2022 04:52:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eliza.sh; h=cc :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1653036775; x=1653040375; bh=iAEzWBXrVyHr8UNm796qmdtRcahg8gaZpd0 E7e72Xw4=; b=b+jcr/Atu8gOojBs3BmB+MfgYWbSXeVmIJ96wRQo9gIZDlOmbhv vMmzAx8crLJL6Xm8PvIfYG4IoQVT3lJbTVt1dbjbiA8fFMS4RS3nq28Sy2KRcUtx tfkpZMzHceepHt81g7BmEOL4LF51PVmEG3ShL/1Y/BRQg1nXX5mCUNBFarFc5oyZ F3fijqhe7f6110q0a3g7v/L8jrKlY5oWuA/hN2YKkG8hYuD1Up8ki+iH+aR1eou5 l2E9o1K/QEyHTBlSb7RA/9VDjSEMqiF/ydKFx+Yng1u29WijPA4pfOX+5Ct/eguV i/gDe5ExalJp3rWp/stMKHJ+BKq5Oc74BmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653036775; x= 1653040375; bh=iAEzWBXrVyHr8UNm796qmdtRcahg8gaZpd0E7e72Xw4=; b=K nhRiMxgzHK8YK/koeDdjeVatE/usa8ur/crJWEKpGQ8XNylaQYUCW2XKW/hoTZhr bVxk+XYhh09RpAgl5ymaZg0uqHGU1UBUNHaKzcrIOulnqAXGAH6Vy7UPIEzHiXCE 0UXgw+ICgDfDidH0LKR6S1VQyax3M5gpokH8AJXZvcvBpL+g/Z54/fHbjdnsDSfX bIHj4A9sWYwQH/YPtPEp1qon8oT9D51Uf3wb+8L0TD5RELR0FXEbyeWJ30mmAO/S K50A6Jvzmyq5J00hn/PkrFzgv63Bw4yZIafFTAgIQ2O9ElL/dWmgk7kV2PP3SaMI 4O75A2vpdyLL7a5f/PI4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrieefgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesthdtredttddttd enucfhrhhomhepgfhlihiirgcugggvlhgrshhquhgviicuoegvlhhiiigrsegvlhhiiigr rdhshheqnecuggftrfgrthhtvghrnhephfeltdfhffejheeiheekudffgfffhfduieegge dtgffhjeffudegueevueejkeeunecuffhomhgrihhnpehgihhthhhusgdrtghomhenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegvlhhiiigrse gvlhhiiigrrdhshh X-ME-Proxy: Feedback-ID: i87c446d8:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 20 May 2022 04:52:54 -0400 (EDT) From: Eliza Velasquez To: notmuch@notmuchmail.org Subject: [BUG] notmuch_message_tags_to_maildir_flags does not always invalidate filenames_list Date: Fri, 20 May 2022 01:52:53 -0700 Message-ID: <877d6g1t7e.fsf@eliza.sh> MIME-Version: 1.0 Message-ID-Hash: JI4SABKI6V3C5VPRMJMAQ74YRBAXKFSN X-Message-ID-Hash: JI4SABKI6V3C5VPRMJMAQ74YRBAXKFSN X-MailFrom: eliza@eliza.sh X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653037259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=7V1YQlbiUUYd8Hqze+I6qQzrI2+KXMh0X6iyRwlX6xU=; b=fttcRYxjhorn8WotZ9Xa75JjkHJXiZBg+N28Dh/DRgJPNvkqZrB1axBBHV6900jSPLwdOy pKmqQfE7jNodDZTVST5GTwRsuI7vx4i0sm5tzPGksXbHofI5UZZKI6S9osAdgxDFc21qOL IVzBq08K5LcDc6BxJkrPL2+yL7lSrno546/QsoPwexEmgdZEO2tv4eNo6YHi1VJVdVP2OV bfvF64s7YoN+/TxcNxROjUQLTSj08nehbJ8NUpgjiHy3Ok+FKewPPz9BpOPNjlXykdFei6 4dyeP6Sj1E5P6KRcX+Q1XQ4IApDwD34FEmF0yW3DKuulvZUOEhe6ryJGyWtnkQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653037259; a=rsa-sha256; cv=none; b=TNKz0WECzAnn7JsQ86FEHg+SilKesRAOpdjJakkXO3SYfJ9KRFqWQPWK9pwjQBHBtVJC5b +qvxoso7tWyNp1zoTsRA/e07oa9rqkCi4Pa3DdFasTYyvWtUPcapm9eX2Ut5Jw3eXuXmLi uU3UVTqMcbGcot0kwFhHVxjcZ+dbOENqIMvtnsJPttKruNoI5mWfnp0CWakpZm7Zeg+jAr WPXmWw9+E590GP8B/05XYn5F/RBksH9RA/ilS9suQ+PBZE4o0V2kGZiJKNei940T+NlC8J mTtqBOp2wBVu8hwQW+sy2AYhbxREYP3GPKkBRd9+wU8CSx/FS6DvIAVhJkHpwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=eliza.sh header.s=fm1 header.b="b+jcr/At"; dkim=fail ("body hash did not verify") header.d=messagingengine.com header.s=fm1 header.b="K nhRiMx"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 1.95 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=eliza.sh header.s=fm1 header.b="b+jcr/At"; dkim=fail ("body hash did not verify") header.d=messagingengine.com header.s=fm1 header.b="K nhRiMx"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 91DA530ED7 X-Spam-Score: 1.95 X-Migadu-Scanner: scn1.migadu.com X-TUID: 4Q5VCjFiiHLE Hello notmuch, As the subject says, it seems like the filename cache for a message is not reliably invalidated when notmuch_message_tags_to_maildir_flags is called, causing the following series of function calls to behave unexpectedly. - notmuch_database_index_file - notmuch_message_get_filenames - notmuch_message_tags_to_maildir_flags - notmuch_message_get_filenames (stale list returned) According to the investigator [1], this happens about 10% of the time, but it's possible that this is just because there is some quirk in the client-side code causing it to trigger only sometimes. [1] https://github.com/elizagamedev/mujmap/pull/10#issuecomment-1131587169 -- Eliza