From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id UP0lFEf/KWSIWgAASxT56A (envelope-from ) for ; Mon, 03 Apr 2023 00:18:47 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id KCTwE0f/KWQVegEAauVa8A (envelope-from ) for ; Mon, 03 Apr 2023 00:18:47 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 84E3D299A9 for ; Mon, 3 Apr 2023 00:18:46 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E89165F35E; Sun, 2 Apr 2023 22:18:43 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 7B1325E54A for ; Sun, 2 Apr 2023 22:18:40 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 539AA5FB82; Sun, 2 Apr 2023 18:18:39 -0400 (EDT) Received: (nullmailer pid 3715047 invoked by uid 1000); Sun, 02 Apr 2023 22:18:37 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 0/3] ruby: get rid of Tags object In-Reply-To: <20230322234346.70537-1-felipe.contreras@gmail.com> References: <20230322234346.70537-1-felipe.contreras@gmail.com> Date: Sun, 02 Apr 2023 19:18:37 -0300 Message-ID: <877cuu2aiq.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 3VNIPCZRE4HFFPVJXOHHG3PYP27O7VQV X-Message-ID-Hash: 3VNIPCZRE4HFFPVJXOHHG3PYP27O7VQV X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: arcnmx X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680473926; a=rsa-sha256; cv=none; b=agDlR3nul0ugLUtRjw+YjhOQS3o7cwuw6oQiSjr9ULHZHIEYg+9MqoTxX0VeLKqjp0tuTS Wy7CMsbEVNaobKRniyWWG9otH5WXTLeUQRD0U9ANDtK95MVypRUPeAiKhEFLdrM5EQ+ojw ia/nFL5S+B7ubYhk+mdAJ+xh8l77LEuxLHODnJizZOV8NrNYZgdA0xBS5xHUZAd37yzB3m LR4unuYkL8HBuAl2wJS6qtCuUW4DcyBUynrTC1Uhh1ymBVVfPbo4fqH71MrcqmnX+L7c6Q AEPzC2IFbkN/zp3WnbIssjCSALTqCXpAGYROTr93Dwfhkix1An0312KE/1Ea6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680473926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=M2FMyRApIREgAjSqfBVjY4NEcdIoq8wSvNMexvbINr0=; b=BXV5WowiQdG3wj82RLePlDSCrKkP4rRSegmbpj2zqjd63rsqMx2Y55aCJ1OMHpxTVv51PH KbuzJwOT4fSMvbJ28sa/7rKGQlrgDt+GPQLDb8xWO+SwHeN1QpEWtGt04m8UQ2XoOQpY2a zeRTzRUSeJDeWftn+OEOBM/JBra/W9qxtbqQ4QoN70WGpquVI10azse1f50nC9ptbLoOzM PHcapDlgLUDsHW3MKReVKVTYMiUUMHZkSbSAS18B81T8+S1HmMhPlgmauR/QGyA6BxE+hi +81SfAbklpOb4euJVNIJqA2chPz/VGKl2UbKrrWZBIlssO0DV1dyA1ZdXG5GHA== X-Migadu-Spam-Score: -2.07 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -2.07 X-Migadu-Queue-Id: 84E3D299A9 X-TUID: j+2K7m2LkPs0 Felipe Contreras writes: > We don't need a Tags enumerable object only for a small number of strings, we > can just get them directly. > > This fixes an interaction problem where we might request two tags iterables > from the same message: > > tags_0 = notmuch_message_get_tags(message); I have applied this series to master. By the way I noticed that the formatting of the old bindings code does not match the output of uncrustify -c ./devel/uncrustify/cfg $file. This is not a serious problem, but it does make the review process a bit noisy (since my clumsy script reformats every file touched by a given commit). Do you have any objection to my just going through and reformatting the bindings code with uncrustify at some point? It can be done as patches also, but it's a bit silly because there can be many small diffs. d