[PATCH -v2] notmuch.el: Use variable notmuch-search-oldest-first to decide the search order

[PATCH -v2] notmuch.el: Use variable notmuch-search-oldest-first to decide the search order

[Aneesh Kumar K.V]

Make sure we use notmuch-search-oldest-first to decide the how
the search result should be displayed. This helps to set the
value to nil and have latest mail shown first. This also fix the
notmuch-folder mode to use the right search order when we select
a folder. Also the notmuch command is fixed to use the right ordering.


Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
 notmuch.el |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/notmuch.el b/notmuch.el
index 5737f77..45c3dc6 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -817,7 +817,8 @@ thread from that buffer can be show when done with this one)."
 (fset 'notmuch-search-mode-map notmuch-search-mode-map)
 
 (defvar notmuch-search-query-string)
-(defvar notmuch-search-oldest-first)
+(defvar notmuch-search-oldest-first t
+  "Show the oldest mail first in the search-mode")
 
 
 (defun notmuch-search-scroll-up ()
@@ -1129,7 +1130,7 @@ current search results AND that are tagged with the given tag."
 (defun notmuch ()
   "Run notmuch to display all mail with tag of 'inbox'"
   (interactive)
-  (notmuch-search "tag:inbox" t))
+  (notmuch-search "tag:inbox" notmuch-search-oldest-first))
 
 (setq mail-user-agent 'message-user-agent)
 
@@ -1199,7 +1200,7 @@ results for the search terms in that line.
       (setq folder (notmuch-folder-find-name)))
   (let ((search (assoc folder notmuch-folders)))
     (if search
-	(notmuch-search (cdr search) t))))
+	(notmuch-search (cdr search) notmuch-search-oldest-first))))
 
 (defun notmuch-folder ()
   "Show the notmuch folder view and update the displayed counts."
-- 
1.6.5.2.74.g610f9

Re: [PATCH -v2] notmuch.el: Use variable notmuch-search-oldest-first to decide the search order

[Carl Worth]

On Wed, 25 Nov 2009 10:28:13 +0530, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> Make sure we use notmuch-search-oldest-first to decide the how
> the search result should be displayed. This helps to set the
> value to nil and have latest mail shown first. This also fix the
> notmuch-folder mode to use the right search order when we select
> a folder. Also the notmuch command is fixed to use the right ordering.

Thanks for the updated commit message. Unfortunately, I'd already
committed the earlier version of this patch.

I generally make passes over my queue of patches to review in
chronological order, (by thread of course). So when anyone has an
updated version of an earlier patch, it will help if the later patches
are sent as replies to the earlier patches.

Thanks,

-Carl