From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6F138431FBC for ; Fri, 22 Jan 2010 21:48:43 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.853 X-Spam-Level: X-Spam-Status: No, score=-1.853 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1.8, AWL=-0.054, BAYES_50=0.001] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qm6kUnb7K8nW; Fri, 22 Jan 2010 21:48:42 -0800 (PST) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8B0A2431FAE; Fri, 22 Jan 2010 21:48:42 -0800 (PST) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id AFE3025409D; Sat, 23 Jan 2010 18:48:41 +1300 (NZDT) From: Carl Worth To: Geo Carncross , notmuch@notmuchmail.org In-Reply-To: <1264104618.3941.108.camel@dwarf> References: <1264104618.3941.108.camel@dwarf> Date: Sat, 23 Jan 2010 18:48:35 +1300 Message-ID: <87636tz80c.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Subject: Re: [PATCH] d_type fix X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2010 05:48:43 -0000 --=-=-= On Thu, 21 Jan 2010 15:10:18 -0500, Geo Carncross wrote: > A review of notmuch-new.c shows three uses of ->d_type: Excellent, thank you. > Near line 153, in _entries_resemble_maildir() we can simply allow for > DT_UNKNOWN. This would fail if people have MH-style folders which have > three folders called "new" "cur" and "tmp", but that seems unlikely, in > which case the "tmp" folder would simply not be scanned. The check will also fail if someone happens to have two regular files named "cur" and "new" next to a directory named "tmp", (which would then be ignored). But I agree this seems very unlikely. > [snip] The rest of your analysis looks good to me. And it's nice to see how simple the final patch is. > Attached is a patch which was tested with reiserfs. It should also work > with xfs. I had been waiting to apply the previous patch until I could test it on a filesystem returning DT_UNKNOWN. But this one looks clean enough to apply immediately. One thing that would have made that easier would be a commit message, (such as making a commit with "git commit" then using "git format-patch" and "git send-email" to send it). But I'll go ahead and make one up. Thanks again! -Carl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFLWo2z6JDdNq8qSWgRAry8AJ0eftnGesu7wGTK5KjQSOGAHqL9swCfSzIQ si3ucTxP72CWo48oubhKBGA= =G2XC -----END PGP SIGNATURE----- --=-=-=--