unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: James Vasile <james@hackervisions.org>
To: "Sebastian Spaeth" <Sebastian@SSpaeth.de>
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] add notmuch-show-delete keybinding 'd'
Date: Thu, 25 Feb 2010 09:21:33 -0500	[thread overview]
Message-ID: <87635ll7ki.wl%james@hackervisions.org> (raw)
In-Reply-To: <87eik9bn8l.fsf@SSpaeth.de>

At Thu, 25 Feb 2010 11:53:14 +0100,
Sebastian Spaeth wrote:
> 
> On Wed, 24 Feb 2010 14:01:18 -0500, Jameson Rollins <jrollins@finestructure.net> wrote:
> > > 2. It removes the "inbox" and "unread" tags while adding the tag to
> > >    indicate deletion.
> > 
> > Hey, Carl.  Why is this last point important? [...]Why should it modify any other
> > tags?  A message/thread should be allowed to be both deleted and in the
> > inbox.
> 
> As long as deleted threads/messages show up in the default views, I
> don't want them to show up in my inbox or show up as unread. I agree
> that it might be possible to have "unread" yet "delete"d emails. But in
> reality, if I delete a message I don't want it to pop up in my inbox.
> 
> Feel free to apply patches however you want though, thanks to emacs,
> I'll be able to get my desired behavior nonetheless :).
> 
> > As for "unread", I think that should be handled by actually reading the
> > message, not by manually applying a state to it.
> 
> I agree, but deleting a message in my world view resets the unread tag
> (as in, I don't want to read it anymore).

This elisp might help.  I run these when deleting messages in search
or show modes.  Basically, this means I never see deleted threads
again.  I also use these to mark spam.

(defun notmuch-tags-strip-properties (tags)
  "return list of tags with emacs text properties removed

tags is a list of tags where each tag is a string with emacs text
properties
"
  (mapcar '(lambda (tag)
	    (set-text-properties 0 (length tag) nil tag)
	    tag)
	  tags))

(defun notmuch-show-remove-all-tags ()
  "Remove all tags from the currently selected thread."
  (apply 'notmuch-show-remove-tag
	 (notmuch-tags-strip-properties (notmuch-show-get-tags))))

(defun notmuch-search-remove-tags (&rest tags)
  "Remove multiple tags from the currently selected thread."
  (mapc 'notmuch-search-remove-tag tags))

(defun notmuch-search-remove-all-tags ()
  "Remove all tags from the currently selected thread."
  (apply 'notmuch-search-remove-tags
	 (notmuch-tags-strip-properties (notmuch-search-get-tags))))

      reply	other threads:[~2010-02-25 14:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 10:32 [PATCH] add notmuch-show-delete keybinding 'd' Sebastian Spaeth
2010-01-20 10:56 ` racin
2010-02-24 18:53   ` Carl Worth
2010-02-24 19:01     ` Jameson Rollins
2010-02-24 19:28       ` Carl Worth
2010-02-24 19:46         ` Jameson Rollins
2010-02-25 10:53       ` Sebastian Spaeth
2010-02-25 14:21         ` James Vasile [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87635ll7ki.wl%james@hackervisions.org \
    --to=james@hackervisions.org \
    --cc=Sebastian@SSpaeth.de \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).