From: Carl Worth <cworth@cworth.org>
To: Michal Sojka <sojkam1@fel.cvut.cz>, Andy Wingo <wingo@oblong.com>
Cc: notmuch@notmuchmail.org
Subject: Re: ./configure with CC="ccache gcc" doesn't work
Date: Wed, 26 Jan 2011 23:38:29 +1000 [thread overview]
Message-ID: <8762tb23ai.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <87mxmv4p3k.fsf@steelpick.2x.cz>
[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]
On Thu, 20 Jan 2011 15:38:39 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> On Thu, 20 Jan 2011, Andy Wingo wrote:
> > Sure. But the ccache thing is fairly common, AFAIK, and IMO notmuch's
> > configure should either handle spaces in a non-absolute-path $CC or exit
> > with an error in that case.
Hi Andy,
Thanks for pointing out the bug. I didn't notice this because I get
ccache by putting a symlink in ~/bin/cc -> /usr/bin/ccache.
I hadn't expected the IFS change to cause any problem like this, but
there it is.
> I went through configure in notmuch and it seems that there is only one
> place where the value of IFS matters (the call to ldconfig), so we may
> want to apply the patch bellow. On the other hand, a brief look at
> Makefile reveals that there are many things that wont work if there are
> spaces in filanames[1], so I'm not sure whether to care about that
> single case at all.
Thanks for the analysis. I've committed this change now.
> [1] For example most commands in install targets contain unquoted
> parameters so if DESTDIR contains a space, it wont work.
I've run through and fixed all of these that I saw. And I did a quick
test with:
make DESTDIR="/tmp/bar baz" install
and it at least seems to work.
I agree that this kind of thing is probably not likely to happen
often. But since I did decide to invent my own build system, I feel I
have an obligation to make it as "correct" as possible.
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2011-01-26 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 16:24 ./configure with CC="ccache gcc" doesn't work Andy Wingo
2011-01-20 9:50 ` Michal Sojka
2011-01-20 12:40 ` Andy Wingo
2011-01-20 14:38 ` Michal Sojka
2011-01-26 13:38 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762tb23ai.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
--cc=wingo@oblong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).