From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 235C7431FD0 for ; Wed, 20 Jul 2011 11:13:11 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.09 X-Spam-Level: X-Spam-Status: No, score=-0.09 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pEViGbu2L7kX for ; Wed, 20 Jul 2011 11:13:09 -0700 (PDT) Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222]) by olra.theworths.org (Postfix) with ESMTP id 61D99431FB6 for ; Wed, 20 Jul 2011 11:13:09 -0700 (PDT) Received: from odin.local (nancy.schnouki.net [78.238.0.45]) by ks3536.kimsufi.com (Postfix) with ESMTPSA id 4D2256A06A9; Wed, 20 Jul 2011 20:21:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net; s=key-schnouki; t=1311186114; bh=0y5HG3RAA8EUpYiQtz+QEHxq6TyHUWB35qmUnwovjGE=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=SjUpu/rmFc2w+zcVb1I110YmB61lq3nKRUXt0/Bfnd6Iw3bLzCdjTZeHuMekM1SeE cOcAcknBOe3YWeJuOxLw5P62a/u9eCsjlGXgq9Hjr+JnaaSqVLEz3h4EtsmjM8K7cP NpEXgoEHiCQMSO7bnGS1sx9hF3qevIzDbIaNSbcE= From: Thomas Jost To: Jameson Graef Rollins , Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH] test: run emacs inside tmux if screen is not available In-Reply-To: <87k4bc275l.fsf@servo.factory.finestructure.net> References: <1309496122-4965-2-git-send-email-dmitry.kurochkin@gmail.com> <1311165396-12268-1-git-send-email-schnouki@schnouki.net> <87d3h5ul7k.fsf@gmail.com> <87k4bc275l.fsf@servo.factory.finestructure.net> User-Agent: Notmuch/0.6.1-84-gc2f6c66 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) Date: Wed, 20 Jul 2011 20:12:55 +0200 Message-ID: <8762mw7rdk.fsf@schnouki.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2011 18:13:11 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 20 Jul 2011 10:28:38 -0700, Jameson Graef Rollins wrote: Non-text part: multipart/signed > On Wed, 20 Jul 2011 17:37:35 +0400, Dmitry Kurochkin wrote: > > On Wed, 20 Jul 2011 14:36:36 +0200, Thomas Jost = wrote: > > > Before this change, the test suite reported many failed tests on mach= ines where > > > screen is not installed (which is the case of many *BSD systems). Thi= s patch > > > makes the test suite try to use tmux, another terminal multiplexer, i= f screen is > > > not available. > >=20 > > This is a nice improvement. But I think we should make it even better = :) > > There are more terminal emulators besides screen and tmux (dtach comes > > to mind). We need a more general mechanism for trying them. There > > should be a list of commands for running terminal emulators in the order > > of preference (I think that is dtach, tmux, screen), and we should try > > each one in a loop (this would also avoid repeating the long emacs > > command). >=20 > Hi, guys. I suppose you can go down this route if you want, but I worry > that it just adds a lot of extra code to the test suite that will > ultimately make it less robust. What's wrong with just depending on > screen for the tests? I'm sure screen is available on every operating > system that we currently support. >=20 > It makes me wary that we would be starting a precedent for making a > bunch of conditionals for all of the possible alternative tools we use > in the test suite. Maybe that's an overblown concern, though. >=20 > jamie. You're right, just depending on screen would be enough (the package is just 864 kB on Arch Linux...), and supporting alternative tools would make the test suite more complicated and less robust. But the dependency on screen should be more *explicit*: if it's not available, the test suite should skip all the emacs tests and display a message about screen. Apparently test-lib.sh includes some things about prerequisites. I'll try to use these to implement the explicit dependency on screen. Regards, =2D-=20 Thomas/Schnouki --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQEcBAEBAgAGBQJOJxqnAAoJEMPdciX+bh5IMyQH/iOqvAMk3LiOT1QYRiW63mSp NRHo1RIdZaDHhahnQdVC2e3pV+bu4j8E5EFvs2xcJw9w1kaSnZcvWHJ14K/B7bL4 LlPXMSCV+hgrGvVubSUC3S5usz4N6XAELGoLCb3yKG0RtCtmicBaCnoCgOGvYTA7 04pOalWTcAargk1/JvQhlI7pqMpzWRDHQdd6AnPkZtMkmq+VbRpfcIuZ3q8wrFlA Kq4MuNxuRo51SXLAygbOPFQMYXcc7Vz7KxZURWSwrcg/kljxWBJxrlOcXguiXK7y fiWmiOnGMoGc8pVaW+++c4WcH+J4vpCKWzcC+vxQd+t5FyTBGWVuBX8iDBXj1Uw= =e0rz -----END PGP SIGNATURE----- --=-=-=--