From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6B016431FD0 for ; Fri, 26 Aug 2011 09:47:50 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iO8nKXGCU2ZC for ; Fri, 26 Aug 2011 09:47:50 -0700 (PDT) Received: from mail-gw0-f53.google.com (mail-gw0-f53.google.com [74.125.83.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id EE1FD431FB6 for ; Fri, 26 Aug 2011 09:47:49 -0700 (PDT) Received: by gwj20 with SMTP id 20so3443288gwj.26 for ; Fri, 26 Aug 2011 09:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=LbJlPoN+WtDfwOsacNW+Qdh3ByGlC6CDw1u0DXGEgHQ=; b=d7cJL/QlB3g3TPHNprjJfmovUV5Oon+U8YSD06/JXqeDT+7smTSit1FeVx+c6wUK3B RVUKvABMM3I4Uwd/wcLtgeMhURGy8WVLT8UOzNajkLY7+3nifPeIXQCf0rhGOAOWdKSZ 8qp4RJSVGRC29OAwfBMpi+H8cKw0ehEMp8vrM= Received: by 10.236.115.98 with SMTP id d62mr8195595yhh.70.1314377269251; Fri, 26 Aug 2011 09:47:49 -0700 (PDT) Received: from localhost ([208.187.197.85]) by mx.google.com with ESMTPS id x42sm1036227yhm.79.2011.08.26.09.47.45 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Aug 2011 09:47:46 -0700 (PDT) From: richardmurri@gmail.com To: David Bremner , notmuch@notmuchmail.org Subject: Re: Fix for emacs 24 In-Reply-To: <878vqgz6fw.fsf@zancas.localnet> References: <877h6x6oor.fsf@veracitynetworks.com> <878vqgz6fw.fsf@zancas.localnet> User-Agent: Notmuch/0.6.1-73-g20aa9b1 (http://notmuchmail.org) Emacs/24.0.50.1 (i686-pc-linux-gnu) Date: Fri, 26 Aug 2011 10:47:44 -0600 Message-ID: <8762lkjf0v.fsf@veracitynetworks.com> MIME-Version: 1.0 Content-Type: text/plain X-Mailman-Approved-At: Fri, 26 Aug 2011 14:29:27 -0700 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2011 16:47:50 -0000 On Fri, 26 Aug 2011 09:46:27 -0300, David Bremner wrote: > Thanks for sending a patch. I'm sure we need lots of help to get notmuch > working well with emacs24. Some comments about your patch > > - It would be nice to have a bit more informative single line summary to > start the patch. > > - I don't really understand from the long commit message what problem > this fixes. I take it some function outside of notmuch is calling > notmuch-mua-mail? > > - The convention on the notmuch list is to use "git send-email" if you > can. This makes it easier to apply patches. Any discussion not meant > to be part of the commit message can go after the --- at the end of the > commit message (and I admit that isn't very obvious). > > Thanks again, and welcome to the team ;) Here is the following snippet from the emacs changelog for emacs 24: ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and passes it to the mail user agent function. This argument specifies an action for returning to the caller after finishing with the mail. This is currently used by Rmail to delete a mail window. compose-mail is run when creating a new email. It breaks horribly without a spot for the optional argument, however most mail agents don't use the argument at all. By just including the extra argument, most everything works well with notmuch in emacs 24.