* [PATCH] Emacs: Add variable to toggle message indentation in a thread
@ 2011-07-11 8:42 Felix Geller
2011-07-11 8:53 ` Dmitry Kurochkin
` (2 more replies)
0 siblings, 3 replies; 35+ messages in thread
From: Felix Geller @ 2011-07-11 8:42 UTC (permalink / raw)
To: notmuch
[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]
Hi,
I added a variable to toggle message indentation in Emacs.
Please let me know what you think.
Cheers,
Felix
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a433dec..8101c27 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -90,6 +90,11 @@ any given message."
:group 'notmuch
:type 'boolean)
+(defcustom notmuch-show-indent-messages-in-thread nil
+ "Should the messages in a thread be indented according to their respective depth in the thread?"
+ :group 'notmuch
+ :type 'boolean)
+
(defcustom notmuch-show-indent-multipart nil
"Should the sub-parts of a multipart/* part be indented?"
;; dme: Not sure which is a good default.
@@ -237,7 +242,9 @@ unchanged ADDRESS if parsing fails."
"Insert a notmuch style headerline based on HEADERS for a
message at DEPTH in the current thread."
(let ((start (point)))
- (insert (notmuch-show-spaces-n depth)
+ (insert (if notmuch-show-indent-messages-in-thread
+ (notmuch-show-spaces-n depth)
+ "")
(notmuch-show-clean-address (plist-get headers :From))
" ("
date
@@ -733,7 +740,8 @@ current buffer, if possible."
(setq content-end (point-marker))
;; Indent according to the depth in the thread.
- (indent-rigidly content-start content-end depth)
+ (when notmuch-show-indent-messages-in-thread
+ (indent-rigidly content-start content-end depth))
(setq message-end (point-max-marker))
[-- Attachment #2: Type: application/pgp-signature, Size: 202 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-11 8:42 [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
@ 2011-07-11 8:53 ` Dmitry Kurochkin
2011-07-11 9:24 ` Felix Geller
2011-07-11 8:57 ` Daniel Schoepe
2011-07-11 16:32 ` Jameson Graef Rollins
2 siblings, 1 reply; 35+ messages in thread
From: Dmitry Kurochkin @ 2011-07-11 8:53 UTC (permalink / raw)
To: Felix Geller, notmuch
Hi Felix.
On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller <fgeller@gmail.com> wrote:
> Hi,
>
> I added a variable to toggle message indentation in Emacs.
>
> Please let me know what you think.
>
I like the change. Though I do not think I would use it without
chronological sorting.
Comments on the code below.
Regards,
Dmitry
>
> Cheers,
> Felix
>
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index a433dec..8101c27 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -90,6 +90,11 @@ any given message."
> :group 'notmuch
> :type 'boolean)
>
> +(defcustom notmuch-show-indent-messages-in-thread nil
> + "Should the messages in a thread be indented according to their respective depth in the thread?"
This line is too long and should be split.
> + :group 'notmuch
> + :type 'boolean)
> +
> (defcustom notmuch-show-indent-multipart nil
> "Should the sub-parts of a multipart/* part be indented?"
> ;; dme: Not sure which is a good default.
> @@ -237,7 +242,9 @@ unchanged ADDRESS if parsing fails."
> "Insert a notmuch style headerline based on HEADERS for a
> message at DEPTH in the current thread."
> (let ((start (point)))
> - (insert (notmuch-show-spaces-n depth)
> + (insert (if notmuch-show-indent-messages-in-thread
> + (notmuch-show-spaces-n depth)
> + "")
(if notmuch-show-indent-messages-in-thread
(insert (notmuch-show-spaces-n depth)))
Is cleaner and avoids useless empty string insert.
> (notmuch-show-clean-address (plist-get headers :From))
> " ("
> date
> @@ -733,7 +740,8 @@ current buffer, if possible."
> (setq content-end (point-marker))
>
> ;; Indent according to the depth in the thread.
> - (indent-rigidly content-start content-end depth)
> + (when notmuch-show-indent-messages-in-thread
> + (indent-rigidly content-start content-end depth))
Not a big deal, but I would prefer `if' instead of `when' here.
Regards,
Dmitry
>
> (setq message-end (point-max-marker))
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-11 8:42 [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
2011-07-11 8:53 ` Dmitry Kurochkin
@ 2011-07-11 8:57 ` Daniel Schoepe
2011-07-11 16:32 ` Jameson Graef Rollins
2 siblings, 0 replies; 35+ messages in thread
From: Daniel Schoepe @ 2011-07-11 8:57 UTC (permalink / raw)
To: Felix Geller, notmuch
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Hi Felix,
On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller <fgeller@gmail.com> wrote:
> +(defcustom notmuch-show-indent-messages-in-thread nil
> + "Should the messages in a thread be indented according to their respective depth in the thread?"
> + :group 'notmuch
> + :type 'boolean)
> +
I think this should default to t, so it doesn't change the current
default behavior (which I find quite helpful).
Cheers,
Daniel
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-11 8:53 ` Dmitry Kurochkin
@ 2011-07-11 9:24 ` Felix Geller
2011-07-11 9:55 ` Dmitry Kurochkin
0 siblings, 1 reply; 35+ messages in thread
From: Felix Geller @ 2011-07-11 9:24 UTC (permalink / raw)
To: Dmitry Kurochkin, notmuch
[-- Attachment #1: Type: text/plain, Size: 4523 bytes --]
Hi Dmitry,
thank you for the comments. I included an updated patch that also
includes Daniel's comment regarding the default value.
I didn't change the "when" though--not because of personal reasons
;)--but because it is used for determining indentation of multi-parts.
Cheers,
Felix
On Mon, 11 Jul 2011 12:53:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Hi Felix.
>
> On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller <fgeller@gmail.com> wrote:
> > Hi,
> >
> > I added a variable to toggle message indentation in Emacs.
> >
> > Please let me know what you think.
> >
>
> I like the change. Though I do not think I would use it without
> chronological sorting.
>
> Comments on the code below.
>
> Regards,
> Dmitry
>
> >
> > Cheers,
> > Felix
> >
> >
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > index a433dec..8101c27 100644
> > --- a/emacs/notmuch-show.el
> > +++ b/emacs/notmuch-show.el
> > @@ -90,6 +90,11 @@ any given message."
> > :group 'notmuch
> > :type 'boolean)
> >
> > +(defcustom notmuch-show-indent-messages-in-thread nil
> > + "Should the messages in a thread be indented according to their respective depth in the thread?"
>
> This line is too long and should be split.
>
> > + :group 'notmuch
> > + :type 'boolean)
> > +
> > (defcustom notmuch-show-indent-multipart nil
> > "Should the sub-parts of a multipart/* part be indented?"
> > ;; dme: Not sure which is a good default.
> > @@ -237,7 +242,9 @@ unchanged ADDRESS if parsing fails."
> > "Insert a notmuch style headerline based on HEADERS for a
> > message at DEPTH in the current thread."
> > (let ((start (point)))
> > - (insert (notmuch-show-spaces-n depth)
> > + (insert (if notmuch-show-indent-messages-in-thread
> > + (notmuch-show-spaces-n depth)
> > + "")
>
> (if notmuch-show-indent-messages-in-thread
> (insert (notmuch-show-spaces-n depth)))
>
> Is cleaner and avoids useless empty string insert.
>
> > (notmuch-show-clean-address (plist-get headers :From))
> > " ("
> > date
> > @@ -733,7 +740,8 @@ current buffer, if possible."
> > (setq content-end (point-marker))
> >
> > ;; Indent according to the depth in the thread.
> > - (indent-rigidly content-start content-end depth)
> > + (when notmuch-show-indent-messages-in-thread
> > + (indent-rigidly content-start content-end depth))
>
> Not a big deal, but I would prefer `if' instead of `when' here.
>
> Regards,
> Dmitry
>
> >
> > (setq message-end (point-max-marker))
> >
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch
commit f90fafdc0545a825ea4b69db5e51c2e866a4ff5e
Author: Felix Geller <fgeller@gmail.com>
Date: Mon Jul 11 10:39:00 2011 +0200
Added a variable to toggle message indentation for thread view in emacs.
- includes adjustments according to comments from ML
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index a433dec..1834066 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -90,6 +90,11 @@ any given message."
:group 'notmuch
:type 'boolean)
+(defcustom notmuch-show-indent-messages-in-thread t
+ "Should messages be indented according to their depth in a thread?"
+ :group 'notmuch
+ :type 'boolean)
+
(defcustom notmuch-show-indent-multipart nil
"Should the sub-parts of a multipart/* part be indented?"
;; dme: Not sure which is a good default.
@@ -237,8 +242,9 @@ unchanged ADDRESS if parsing fails."
"Insert a notmuch style headerline based on HEADERS for a
message at DEPTH in the current thread."
(let ((start (point)))
- (insert (notmuch-show-spaces-n depth)
- (notmuch-show-clean-address (plist-get headers :From))
+ (when notmuch-show-indent-messages-in-thread
+ (insert (notmuch-show-spaces-n depth)))
+ (insert (notmuch-show-clean-address (plist-get headers :From))
" ("
date
") ("
@@ -733,7 +739,8 @@ current buffer, if possible."
(setq content-end (point-marker))
;; Indent according to the depth in the thread.
- (indent-rigidly content-start content-end depth)
+ (when notmuch-show-indent-messages-in-thread
+ (indent-rigidly content-start content-end depth))
(setq message-end (point-max-marker))
[-- Attachment #2: Type: application/pgp-signature, Size: 202 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-11 9:24 ` Felix Geller
@ 2011-07-11 9:55 ` Dmitry Kurochkin
2011-07-11 10:09 ` Felix Geller
0 siblings, 1 reply; 35+ messages in thread
From: Dmitry Kurochkin @ 2011-07-11 9:55 UTC (permalink / raw)
To: Felix Geller, notmuch
On Mon, 11 Jul 2011 11:24:57 +0200, Felix Geller <fgeller@gmail.com> wrote:
> Hi Dmitry,
>
> thank you for the comments. I included an updated patch that also
> includes Daniel's comment regarding the default value.
>
Another thing that would be nice to have is a test for this feature.
Regards,
Dmitry
> I didn't change the "when" though--not because of personal reasons
> ;)--but because it is used for determining indentation of multi-parts.
>
>
> Cheers,
> Felix
>
>
>
> On Mon, 11 Jul 2011 12:53:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Hi Felix.
> >
> > On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller <fgeller@gmail.com> wrote:
> > > Hi,
> > >
> > > I added a variable to toggle message indentation in Emacs.
> > >
> > > Please let me know what you think.
> > >
> >
> > I like the change. Though I do not think I would use it without
> > chronological sorting.
> >
> > Comments on the code below.
> >
> > Regards,
> > Dmitry
> >
> > >
> > > Cheers,
> > > Felix
> > >
> > >
> > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > > index a433dec..8101c27 100644
> > > --- a/emacs/notmuch-show.el
> > > +++ b/emacs/notmuch-show.el
> > > @@ -90,6 +90,11 @@ any given message."
> > > :group 'notmuch
> > > :type 'boolean)
> > >
> > > +(defcustom notmuch-show-indent-messages-in-thread nil
> > > + "Should the messages in a thread be indented according to their respective depth in the thread?"
> >
> > This line is too long and should be split.
> >
> > > + :group 'notmuch
> > > + :type 'boolean)
> > > +
> > > (defcustom notmuch-show-indent-multipart nil
> > > "Should the sub-parts of a multipart/* part be indented?"
> > > ;; dme: Not sure which is a good default.
> > > @@ -237,7 +242,9 @@ unchanged ADDRESS if parsing fails."
> > > "Insert a notmuch style headerline based on HEADERS for a
> > > message at DEPTH in the current thread."
> > > (let ((start (point)))
> > > - (insert (notmuch-show-spaces-n depth)
> > > + (insert (if notmuch-show-indent-messages-in-thread
> > > + (notmuch-show-spaces-n depth)
> > > + "")
> >
> > (if notmuch-show-indent-messages-in-thread
> > (insert (notmuch-show-spaces-n depth)))
> >
> > Is cleaner and avoids useless empty string insert.
> >
> > > (notmuch-show-clean-address (plist-get headers :From))
> > > " ("
> > > date
> > > @@ -733,7 +740,8 @@ current buffer, if possible."
> > > (setq content-end (point-marker))
> > >
> > > ;; Indent according to the depth in the thread.
> > > - (indent-rigidly content-start content-end depth)
> > > + (when notmuch-show-indent-messages-in-thread
> > > + (indent-rigidly content-start content-end depth))
> >
> > Not a big deal, but I would prefer `if' instead of `when' here.
> >
> > Regards,
> > Dmitry
> >
> > >
> > > (setq message-end (point-max-marker))
> > >
> > > _______________________________________________
> > > notmuch mailing list
> > > notmuch@notmuchmail.org
> > > http://notmuchmail.org/mailman/listinfo/notmuch
>
>
> commit f90fafdc0545a825ea4b69db5e51c2e866a4ff5e
> Author: Felix Geller <fgeller@gmail.com>
> Date: Mon Jul 11 10:39:00 2011 +0200
>
> Added a variable to toggle message indentation for thread view in emacs.
> - includes adjustments according to comments from ML
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index a433dec..1834066 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -90,6 +90,11 @@ any given message."
> :group 'notmuch
> :type 'boolean)
>
> +(defcustom notmuch-show-indent-messages-in-thread t
> + "Should messages be indented according to their depth in a thread?"
> + :group 'notmuch
> + :type 'boolean)
> +
> (defcustom notmuch-show-indent-multipart nil
> "Should the sub-parts of a multipart/* part be indented?"
> ;; dme: Not sure which is a good default.
> @@ -237,8 +242,9 @@ unchanged ADDRESS if parsing fails."
> "Insert a notmuch style headerline based on HEADERS for a
> message at DEPTH in the current thread."
> (let ((start (point)))
> - (insert (notmuch-show-spaces-n depth)
> - (notmuch-show-clean-address (plist-get headers :From))
> + (when notmuch-show-indent-messages-in-thread
> + (insert (notmuch-show-spaces-n depth)))
> + (insert (notmuch-show-clean-address (plist-get headers :From))
> " ("
> date
> ") ("
> @@ -733,7 +739,8 @@ current buffer, if possible."
> (setq content-end (point-marker))
>
> ;; Indent according to the depth in the thread.
> - (indent-rigidly content-start content-end depth)
> + (when notmuch-show-indent-messages-in-thread
> + (indent-rigidly content-start content-end depth))
>
> (setq message-end (point-max-marker))
>
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-11 9:55 ` Dmitry Kurochkin
@ 2011-07-11 10:09 ` Felix Geller
0 siblings, 0 replies; 35+ messages in thread
From: Felix Geller @ 2011-07-11 10:09 UTC (permalink / raw)
To: Dmitry Kurochkin, notmuch
[-- Attachment #1: Type: text/plain, Size: 5411 bytes --]
On Mon, 11 Jul 2011 13:55:24 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> On Mon, 11 Jul 2011 11:24:57 +0200, Felix Geller <fgeller@gmail.com> wrote:
> > Hi Dmitry,
> >
> > thank you for the comments. I included an updated patch that also
> > includes Daniel's comment regarding the default value.
> >
>
> Another thing that would be nice to have is a test for this feature.
I'll look into it :)
Cheers,
Felix
>
>
> Regards,
> Dmitry
>
> > I didn't change the "when" though--not because of personal reasons
> > ;)--but because it is used for determining indentation of multi-parts.
> >
> >
> > Cheers,
> > Felix
> >
> >
> >
> > On Mon, 11 Jul 2011 12:53:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > Hi Felix.
> > >
> > > On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller <fgeller@gmail.com> wrote:
> > > > Hi,
> > > >
> > > > I added a variable to toggle message indentation in Emacs.
> > > >
> > > > Please let me know what you think.
> > > >
> > >
> > > I like the change. Though I do not think I would use it without
> > > chronological sorting.
> > >
> > > Comments on the code below.
> > >
> > > Regards,
> > > Dmitry
> > >
> > > >
> > > > Cheers,
> > > > Felix
> > > >
> > > >
> > > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > > > index a433dec..8101c27 100644
> > > > --- a/emacs/notmuch-show.el
> > > > +++ b/emacs/notmuch-show.el
> > > > @@ -90,6 +90,11 @@ any given message."
> > > > :group 'notmuch
> > > > :type 'boolean)
> > > >
> > > > +(defcustom notmuch-show-indent-messages-in-thread nil
> > > > + "Should the messages in a thread be indented according to their respective depth in the thread?"
> > >
> > > This line is too long and should be split.
> > >
> > > > + :group 'notmuch
> > > > + :type 'boolean)
> > > > +
> > > > (defcustom notmuch-show-indent-multipart nil
> > > > "Should the sub-parts of a multipart/* part be indented?"
> > > > ;; dme: Not sure which is a good default.
> > > > @@ -237,7 +242,9 @@ unchanged ADDRESS if parsing fails."
> > > > "Insert a notmuch style headerline based on HEADERS for a
> > > > message at DEPTH in the current thread."
> > > > (let ((start (point)))
> > > > - (insert (notmuch-show-spaces-n depth)
> > > > + (insert (if notmuch-show-indent-messages-in-thread
> > > > + (notmuch-show-spaces-n depth)
> > > > + "")
> > >
> > > (if notmuch-show-indent-messages-in-thread
> > > (insert (notmuch-show-spaces-n depth)))
> > >
> > > Is cleaner and avoids useless empty string insert.
> > >
> > > > (notmuch-show-clean-address (plist-get headers :From))
> > > > " ("
> > > > date
> > > > @@ -733,7 +740,8 @@ current buffer, if possible."
> > > > (setq content-end (point-marker))
> > > >
> > > > ;; Indent according to the depth in the thread.
> > > > - (indent-rigidly content-start content-end depth)
> > > > + (when notmuch-show-indent-messages-in-thread
> > > > + (indent-rigidly content-start content-end depth))
> > >
> > > Not a big deal, but I would prefer `if' instead of `when' here.
> > >
> > > Regards,
> > > Dmitry
> > >
> > > >
> > > > (setq message-end (point-max-marker))
> > > >
> > > > _______________________________________________
> > > > notmuch mailing list
> > > > notmuch@notmuchmail.org
> > > > http://notmuchmail.org/mailman/listinfo/notmuch
> >
> >
> > commit f90fafdc0545a825ea4b69db5e51c2e866a4ff5e
> > Author: Felix Geller <fgeller@gmail.com>
> > Date: Mon Jul 11 10:39:00 2011 +0200
> >
> > Added a variable to toggle message indentation for thread view in emacs.
> > - includes adjustments according to comments from ML
> >
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > index a433dec..1834066 100644
> > --- a/emacs/notmuch-show.el
> > +++ b/emacs/notmuch-show.el
> > @@ -90,6 +90,11 @@ any given message."
> > :group 'notmuch
> > :type 'boolean)
> >
> > +(defcustom notmuch-show-indent-messages-in-thread t
> > + "Should messages be indented according to their depth in a thread?"
> > + :group 'notmuch
> > + :type 'boolean)
> > +
> > (defcustom notmuch-show-indent-multipart nil
> > "Should the sub-parts of a multipart/* part be indented?"
> > ;; dme: Not sure which is a good default.
> > @@ -237,8 +242,9 @@ unchanged ADDRESS if parsing fails."
> > "Insert a notmuch style headerline based on HEADERS for a
> > message at DEPTH in the current thread."
> > (let ((start (point)))
> > - (insert (notmuch-show-spaces-n depth)
> > - (notmuch-show-clean-address (plist-get headers :From))
> > + (when notmuch-show-indent-messages-in-thread
> > + (insert (notmuch-show-spaces-n depth)))
> > + (insert (notmuch-show-clean-address (plist-get headers :From))
> > " ("
> > date
> > ") ("
> > @@ -733,7 +739,8 @@ current buffer, if possible."
> > (setq content-end (point-marker))
> >
> > ;; Indent according to the depth in the thread.
> > - (indent-rigidly content-start content-end depth)
> > + (when notmuch-show-indent-messages-in-thread
> > + (indent-rigidly content-start content-end depth))
> >
> > (setq message-end (point-max-marker))
> >
[-- Attachment #2: Type: application/pgp-signature, Size: 202 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-11 8:42 [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
2011-07-11 8:53 ` Dmitry Kurochkin
2011-07-11 8:57 ` Daniel Schoepe
@ 2011-07-11 16:32 ` Jameson Graef Rollins
2011-07-12 23:46 ` Felix Geller
2 siblings, 1 reply; 35+ messages in thread
From: Jameson Graef Rollins @ 2011-07-11 16:32 UTC (permalink / raw)
To: Felix Geller, notmuch
[-- Attachment #1: Type: text/plain, Size: 1588 bytes --]
On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller <fgeller@gmail.com> wrote:
> I added a variable to toggle message indentation in Emacs.
Hi, Felix. Thanks for submitting this patch. I think it's a good idea.
I have a couple of comments below, a couple of which echo what Dmitry
has already pointed out.
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
This patch doesn't include a commit log, which is something we generally
require. The preferred way to send patches is with git format-patch or
send-email, both of which format patches in such a way that they can be
immediately applied to a git repo, including with the commit log.
> +(defcustom notmuch-show-indent-messages-in-thread nil
> + "Should the messages in a thread be indented according to their respective depth in the thread?"
> + :group 'notmuch
> + :type 'boolean)
I agres with Dmitry that this should default to 't', to be consistent
with the current default behavior.
> - (insert (notmuch-show-spaces-n depth)
> + (insert (if notmuch-show-indent-messages-in-thread
> + (notmuch-show-spaces-n depth)
> + "")
I also agree with Dmitry's suggestion here to use the following slightly
simpler construct:
(if notmuch-show-indent-messages-in-thread
(insert (notmuch-show-spaces-n depth)))
Finally, as Dmitry also points out, you'll almost certainly need to
construct a test for this feature, since it constitutes a pretty big
formatting change. It should probably test for both cases of the
customization variable. Check out the tests in tests/emacs for
guidance.
hth.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-11 16:32 ` Jameson Graef Rollins
@ 2011-07-12 23:46 ` Felix Geller
2011-07-16 13:25 ` Felix Geller
2011-07-18 18:30 ` Jameson Graef Rollins
0 siblings, 2 replies; 35+ messages in thread
From: Felix Geller @ 2011-07-12 23:46 UTC (permalink / raw)
To: Jameson Graef Rollins, notmuch
[-- Attachment #1.1: Type: text/plain, Size: 2488 bytes --]
On Mon, 11 Jul 2011 09:32:45 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller <fgeller@gmail.com> wrote:
> > I added a variable to toggle message indentation in Emacs.
>
> Hi, Felix. Thanks for submitting this patch. I think it's a good idea.
> I have a couple of comments below, a couple of which echo what Dmitry
> has already pointed out.
>
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
>
> This patch doesn't include a commit log, which is something we generally
> require. The preferred way to send patches is with git format-patch or
> send-email, both of which format patches in such a way that they can be
> immediately applied to a git repo, including with the commit log.
Ok, tried again :)
I attached two commits. One that includes the changes (which have most
comments incorporated, only that I stick to when rather than if) and one
that includes a test. I still can't run the tests myself, I attached an
excerpt of what errors come up for the emacs subset, so I haven't tested
the test itself :( However, it is a simple copy of an existing one, but
I use a let to change the value of the new variable and adapted one of
the existing expected outputs to lack indentation. I'd be grateful if
someone could test it...
Didn't know about format-patch, thanks :)
Cheers,
Felix
>
>
> > +(defcustom notmuch-show-indent-messages-in-thread nil
> > + "Should the messages in a thread be indented according to their respective depth in the thread?"
> > + :group 'notmuch
> > + :type 'boolean)
>
> I agres with Dmitry that this should default to 't', to be consistent
> with the current default behavior.
>
> > - (insert (notmuch-show-spaces-n depth)
> > + (insert (if notmuch-show-indent-messages-in-thread
> > + (notmuch-show-spaces-n depth)
> > + "")
>
> I also agree with Dmitry's suggestion here to use the following slightly
> simpler construct:
>
> (if notmuch-show-indent-messages-in-thread
> (insert (notmuch-show-spaces-n depth)))
>
> Finally, as Dmitry also points out, you'll almost certainly need to
> construct a test for this feature, since it constitutes a pretty big
> formatting change. It should probably test for both cases of the
> customization variable. Check out the tests in tests/emacs for
> guidance.
>
> hth.
>
> jamie.
Non-text part: application/pgp-signature
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Added-variable-to-toggle-message-indendation-in-Emac.patch --]
[-- Type: text/x-patch, Size: 1782 bytes --]
From 94570ada2eae1ff1a1feebbda5dff04d223da6b4 Mon Sep 17 00:00:00 2001
From: Felix Geller <fgeller@gmail.com>
Date: Wed, 13 Jul 2011 01:30:51 +0200
Subject: [PATCH 1/2] Added variable to toggle message indendation in Emacs'
notmuch-show
---
emacs/notmuch-show.el | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f96743b..48df4c5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -90,6 +90,11 @@ any given message."
:group 'notmuch
:type 'boolean)
+(defcustom notmuch-show-indent-messages-in-thread t
+ "Should messages be indented according to their depth in a thread?"
+ :group 'notmuch
+ :type 'boolean)
+
(defcustom notmuch-show-indent-multipart nil
"Should the sub-parts of a multipart/* part be indented?"
;; dme: Not sure which is a good default.
@@ -237,8 +242,9 @@ unchanged ADDRESS if parsing fails."
"Insert a notmuch style headerline based on HEADERS for a
message at DEPTH in the current thread."
(let ((start (point)))
- (insert (notmuch-show-spaces-n depth)
- (notmuch-show-clean-address (plist-get headers :From))
+ (when notmuch-show-indent-messages-in-thread
+ (insert (notmuch-show-spaces-n depth)))
+ (insert (notmuch-show-clean-address (plist-get headers :From))
" ("
date
") ("
@@ -733,7 +739,8 @@ current buffer, if possible."
(setq content-end (point-marker))
;; Indent according to the depth in the thread.
- (indent-rigidly content-start content-end depth)
+ (when notmuch-show-indent-messages-in-thread
+ (indent-rigidly content-start content-end depth))
(setq message-end (point-max-marker))
--
1.7.6
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.3: 0002-Test-for-toggling-message-indentation.patch --]
[-- Type: text/x-patch, Size: 9209 bytes --]
From 016ee41930eed6b53e10c35c62c40fa6bb35b79e Mon Sep 17 00:00:00 2001
From: Felix Geller <fgeller@gmail.com>
Date: Wed, 13 Jul 2011 01:32:14 +0200
Subject: [PATCH 2/2] Test for toggling message indentation
---
test/emacs | 7 +
...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
diff --git a/test/emacs b/test/emacs
index 53f455a..c65d6d8 100755
--- a/test/emacs
+++ b/test/emacs
@@ -55,6 +55,13 @@ test_emacs "(notmuch-show \"$maildir_storage_thread\")
(test-output)"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs without indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-show-indent-messages-in-thread nil))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
new file mode 100644
index 0000000..cdc8fbd
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+
+Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+See the patch just posted here.
+
+[ 2-line signature. Click/Enter to show. ]
+--
+http://fossarchy.blogspot.com/
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Mikhail Gusarov <dottedmag@dottedmag.net>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> See the patch just posted here.
+
+Is the list archived anywhere? The obvious archives
+(http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+think I subscribed too late to get the patch (I only just saw the
+discussion about it).
+
+It doesn't look like the patch is in git yet.
+
+-- Lars
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+ikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+ubject: [notmuch] Working with Maildir storage?
+o: notmuch@notmuchmail.org
+ate: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+was brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+LK> Is the list archived anywhere? The obvious archives
+LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+LK> think I subscribed too late to get the patch (I only just saw the
+LK> discussion about it).
+
+LK> It doesn't look like the patch is in git yet.
+
+ust has been pushed
+
+ 10-line signature. Click/Enter to show. ]
+-
+ttp://fossarchy.blogspot.com/
+------------- next part --------------
+ non-text attachment was scrubbed...
+ame: not available
+ype: application/pgp-signature
+ize: 834 bytes
+esc: not available
+RL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+eith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+ubject: [notmuch] Working with Maildir storage?
+o: notmuch@notmuchmail.org
+ate: Tue, 17 Nov 2009 13:24:13 -0800
+
+n Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+ > See the patch just posted here.
+
+'ve also pushed a slightly more complicated (and complete) fix to my
+rivate notmuch repository
+
+it://keithp.com/git/notmuch
+
+ Is the list archived anywhere?
+
+ops. Looks like Carl's mail server is broken. He's traveling to
+arcelona today and so it won't get fixed for a while.
+
+hanks to everyone for trying out notmuch!
+
+keith
+
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Keith Packard <keithp@keithp.com>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> I've also pushed a slightly more complicated (and complete) fix to my
+> private notmuch repository
+
+The version of lib/messages.cc in your repo doesn't build because it's
+missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> I saw the LWN article and decided to take a look at notmuch. I'm
+> currently using mutt and mairix to index and read a collection of
+> Maildir mail folders (around 40,000 messages total).
+
+Welcome, Lars!
+
+I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+That's very interesting. So, thanks for coming and trying out notmuch.
+
+> Error opening
+> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+> Too many open files
+
+Sadly, the lwn article coincided with me having just introduced this
+bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+fairly quickly, but there was quite a bit of latency before I could push
+the fix out. It should be fixed now.
+
+> I'm curious if this is expected behavior (i.e., notmuch does not work
+> with Maildir) or if something else is going on.
+
+Notmuch works just fine with maildir---it's one of the things that it
+likes the best.
+
+Happy hacking,
+
+-Carl
+
--
1.7.6
[-- Attachment #2: Type: application/pgp-signature, Size: 202 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-12 23:46 ` Felix Geller
@ 2011-07-16 13:25 ` Felix Geller
2011-07-18 18:30 ` Jameson Graef Rollins
1 sibling, 0 replies; 35+ messages in thread
From: Felix Geller @ 2011-07-16 13:25 UTC (permalink / raw)
To: Jameson Graef Rollins, notmuch
[-- Attachment #1.1: Type: text/plain, Size: 873 bytes --]
On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller <fgeller@gmail.com> wrote:
> I attached two commits. One that includes the changes (which have most
> comments incorporated, only that I stick to when rather than if) and one
> that includes a test. I still can't run the tests myself, I attached an
> excerpt of what errors come up for the emacs subset, so I haven't tested
> the test itself :( However, it is a simple copy of an existing one, but
> I use a let to change the value of the new variable and adapted one of
> the existing expected outputs to lack indentation. I'd be grateful if
> someone could test it...
Got the test suite to run on my machine and I fixed a editing typo of
the expected output. After that the test runs fine on my machine. The
patch that has the actual changes needs no changing. Let me know if
something's wrong/missing.
Cheers,
Felix
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Test-for-toggling-message-indentation.patch --]
[-- Type: text/x-patch, Size: 9244 bytes --]
From 3b3145ad0411dec9f1c6f93635184a1a308471a7 Mon Sep 17 00:00:00 2001
From: Felix Geller <fgeller@gmail.com>
Date: Wed, 13 Jul 2011 01:32:14 +0200
Subject: [PATCH] Test for toggling message indentation
---
test/emacs | 7 +
...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
diff --git a/test/emacs b/test/emacs
index 53f455a..c65d6d8 100755
--- a/test/emacs
+++ b/test/emacs
@@ -55,6 +55,13 @@ test_emacs "(notmuch-show \"$maildir_storage_thread\")
(test-output)"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs without indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-show-indent-messages-in-thread nil))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
new file mode 100644
index 0000000..00bd006
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+
+Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+See the patch just posted here.
+
+[ 2-line signature. Click/Enter to show. ]
+--
+ http://fossarchy.blogspot.com/
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Mikhail Gusarov <dottedmag@dottedmag.net>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> See the patch just posted here.
+
+Is the list archived anywhere? The obvious archives
+(http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+think I subscribed too late to get the patch (I only just saw the
+discussion about it).
+
+It doesn't look like the patch is in git yet.
+
+-- Lars
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+Twas brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+ LK> Is the list archived anywhere? The obvious archives
+ LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ LK> think I subscribed too late to get the patch (I only just saw the
+ LK> discussion about it).
+
+ LK> It doesn't look like the patch is in git yet.
+
+Just has been pushed
+
+[ 10-line signature. Click/Enter to show. ]
+--
+ http://fossarchy.blogspot.com/
+-------------- next part --------------
+A non-text attachment was scrubbed...
+Name: not available
+Type: application/pgp-signature
+Size: 834 bytes
+Desc: not available
+URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 13:24:13 -0800
+
+On Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> > See the patch just posted here.
+
+I've also pushed a slightly more complicated (and complete) fix to my
+private notmuch repository
+
+git://keithp.com/git/notmuch
+
+> Is the list archived anywhere?
+
+Oops. Looks like Carl's mail server is broken. He's traveling to
+Barcelona today and so it won't get fixed for a while.
+
+Thanks to everyone for trying out notmuch!
+
+-keith
+
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Keith Packard <keithp@keithp.com>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> I've also pushed a slightly more complicated (and complete) fix to my
+> private notmuch repository
+
+The version of lib/messages.cc in your repo doesn't build because it's
+missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> I saw the LWN article and decided to take a look at notmuch. I'm
+> currently using mutt and mairix to index and read a collection of
+> Maildir mail folders (around 40,000 messages total).
+
+Welcome, Lars!
+
+I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+That's very interesting. So, thanks for coming and trying out notmuch.
+
+> Error opening
+> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+> Too many open files
+
+Sadly, the lwn article coincided with me having just introduced this
+bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+fairly quickly, but there was quite a bit of latency before I could push
+the fix out. It should be fixed now.
+
+> I'm curious if this is expected behavior (i.e., notmuch does not work
+> with Maildir) or if something else is going on.
+
+Notmuch works just fine with maildir---it's one of the things that it
+likes the best.
+
+Happy hacking,
+
+-Carl
+
--
1.7.6
[-- Attachment #1.3: Type: text/plain, Size: 12870 bytes --]
>
>
> Didn't know about format-patch, thanks :)
>
>
> Cheers,
> Felix
>
>
> >
> >
> > > +(defcustom notmuch-show-indent-messages-in-thread nil
> > > + "Should the messages in a thread be indented according to their respective depth in the thread?"
> > > + :group 'notmuch
> > > + :type 'boolean)
> >
> > I agres with Dmitry that this should default to 't', to be consistent
> > with the current default behavior.
> >
> > > - (insert (notmuch-show-spaces-n depth)
> > > + (insert (if notmuch-show-indent-messages-in-thread
> > > + (notmuch-show-spaces-n depth)
> > > + "")
> >
> > I also agree with Dmitry's suggestion here to use the following slightly
> > simpler construct:
> >
> > (if notmuch-show-indent-messages-in-thread
> > (insert (notmuch-show-spaces-n depth)))
> >
> > Finally, as Dmitry also points out, you'll almost certainly need to
> > construct a test for this feature, since it constitutes a pretty big
> > formatting change. It should probably test for both cases of the
> > customization variable. Check out the tests in tests/emacs for
> > guidance.
> >
> > hth.
> >
> > jamie.
> Non-text part: application/pgp-signature
>
> From 94570ada2eae1ff1a1feebbda5dff04d223da6b4 Mon Sep 17 00:00:00 2001
> From: Felix Geller <fgeller@gmail.com>
> Date: Wed, 13 Jul 2011 01:30:51 +0200
> Subject: [PATCH 1/2] Added variable to toggle message indendation in Emacs'
> notmuch-show
>
> ---
> emacs/notmuch-show.el | 13 ++++++++++---
> 1 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index f96743b..48df4c5 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -90,6 +90,11 @@ any given message."
> :group 'notmuch
> :type 'boolean)
>
> +(defcustom notmuch-show-indent-messages-in-thread t
> + "Should messages be indented according to their depth in a thread?"
> + :group 'notmuch
> + :type 'boolean)
> +
> (defcustom notmuch-show-indent-multipart nil
> "Should the sub-parts of a multipart/* part be indented?"
> ;; dme: Not sure which is a good default.
> @@ -237,8 +242,9 @@ unchanged ADDRESS if parsing fails."
> "Insert a notmuch style headerline based on HEADERS for a
> message at DEPTH in the current thread."
> (let ((start (point)))
> - (insert (notmuch-show-spaces-n depth)
> - (notmuch-show-clean-address (plist-get headers :From))
> + (when notmuch-show-indent-messages-in-thread
> + (insert (notmuch-show-spaces-n depth)))
> + (insert (notmuch-show-clean-address (plist-get headers :From))
> " ("
> date
> ") ("
> @@ -733,7 +739,8 @@ current buffer, if possible."
> (setq content-end (point-marker))
>
> ;; Indent according to the depth in the thread.
> - (indent-rigidly content-start content-end depth)
> + (when notmuch-show-indent-messages-in-thread
> + (indent-rigidly content-start content-end depth))
>
> (setq message-end (point-max-marker))
>
> --
> 1.7.6
>
> From 016ee41930eed6b53e10c35c62c40fa6bb35b79e Mon Sep 17 00:00:00 2001
> From: Felix Geller <fgeller@gmail.com>
> Date: Wed, 13 Jul 2011 01:32:14 +0200
> Subject: [PATCH 2/2] Test for toggling message indentation
>
> ---
> test/emacs | 7 +
> ...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
> 2 files changed, 222 insertions(+), 0 deletions(-)
> create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
>
> diff --git a/test/emacs b/test/emacs
> index 53f455a..c65d6d8 100755
> --- a/test/emacs
> +++ b/test/emacs
> @@ -55,6 +55,13 @@ test_emacs "(notmuch-show \"$maildir_storage_thread\")
> (test-output)"
> test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
>
> +test_begin_subtest "Basic notmuch-show view in emacs without indentation"
> +maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
> +test_emacs "(let ((notmuch-show-indent-messages-in-thread nil))
> + (notmuch-show \"$maildir_storage_thread\")
> + (test-output))"
> +test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
> +
> test_begin_subtest "notmuch-show for message with invalid From"
> add_message "[subject]=\"message-with-invalid-from\"" \
> "[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
> diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
> new file mode 100644
> index 0000000..cdc8fbd
> --- /dev/null
> +++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
> @@ -0,0 +1,215 @@
> +Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
> +Subject: [notmuch] Working with Maildir storage?
> +To: notmuch@notmuchmail.org
> +Date: Tue, 17 Nov 2009 14:00:54 -0500
> +
> +[ multipart/mixed ]
> +[ multipart/signed ]
> +[ text/plain ]
> +I saw the LWN article and decided to take a look at notmuch. I'm
> +currently using mutt and mairix to index and read a collection of
> +Maildir mail folders (around 40,000 messages total).
> +
> +notmuch indexed the messages without complaint, but my attempt at
> +searching bombed out. Running, for example:
> +
> + notmuch search storage
> +
> +Resulted in 4604 lines of errors along the lines of:
> +
> + Error opening
> + /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
> + Too many open files
> +
> +I'm curious if this is expected behavior (i.e., notmuch does not work
> +with Maildir) or if something else is going on.
> +
> +Cheers,
> +
> +[ 5-line signature. Click/Enter to show. ]
> +--
> +Lars Kellogg-Stedman <lars@seas.harvard.edu>
> +Senior Technologist, Computing and Information Technology
> +Harvard University School of Engineering and Applied Sciences
> +
> +[ application/pgp-signature ]
> +[ text/plain ]
> +[ 4-line signature. Click/Enter to show. ]
> +_______________________________________________
> +notmuch mailing list
> +notmuch@notmuchmail.org
> +http://notmuchmail.org/mailman/listinfo/notmuch
> +Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
> +Subject: Re: [notmuch] Working with Maildir storage?
> +To: notmuch@notmuchmail.org
> +Date: Wed, 18 Nov 2009 01:02:38 +0600
> +
> +[ multipart/mixed ]
> +[ multipart/signed ]
> +[ text/plain ]
> +
> +Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
> +
> + LK> Resulted in 4604 lines of errors along the lines of:
> +
> + LK> Error opening
> + LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
> + LK> Too many open files
> +
> +See the patch just posted here.
> +
> +[ 2-line signature. Click/Enter to show. ]
> +--
> +http://fossarchy.blogspot.com/
> +[ application/pgp-signature ]
> +[ text/plain ]
> +[ 4-line signature. Click/Enter to show. ]
> +_______________________________________________
> +notmuch mailing list
> +notmuch@notmuchmail.org
> +http://notmuchmail.org/mailman/listinfo/notmuch
> +Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
> +Subject: Re: [notmuch] Working with Maildir storage?
> +To: Mikhail Gusarov <dottedmag@dottedmag.net>
> +Cc: notmuch@notmuchmail.org
> +Date: Tue, 17 Nov 2009 15:33:01 -0500
> +
> +[ multipart/mixed ]
> +[ multipart/signed ]
> +[ text/plain ]
> +> See the patch just posted here.
> +
> +Is the list archived anywhere? The obvious archives
> +(http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
> +think I subscribed too late to get the patch (I only just saw the
> +discussion about it).
> +
> +It doesn't look like the patch is in git yet.
> +
> +-- Lars
> +
> +[ 5-line signature. Click/Enter to show. ]
> +--
> +Lars Kellogg-Stedman <lars@seas.harvard.edu>
> +Senior Technologist, Computing and Information Technology
> +Harvard University School of Engineering and Applied Sciences
> +
> +[ application/pgp-signature ]
> +[ text/plain ]
> +[ 4-line signature. Click/Enter to show. ]
> +_______________________________________________
> +notmuch mailing list
> +notmuch@notmuchmail.org
> +http://notmuchmail.org/mailman/listinfo/notmuch
> +ikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
> +ubject: [notmuch] Working with Maildir storage?
> +o: notmuch@notmuchmail.org
> +ate: Wed, 18 Nov 2009 02:50:48 +0600
> +
> +
> +was brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
> +
> +LK> Is the list archived anywhere? The obvious archives
> +LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
> +LK> think I subscribed too late to get the patch (I only just saw the
> +LK> discussion about it).
> +
> +LK> It doesn't look like the patch is in git yet.
> +
> +ust has been pushed
> +
> + 10-line signature. Click/Enter to show. ]
> +-
> +ttp://fossarchy.blogspot.com/
> +------------- next part --------------
> + non-text attachment was scrubbed...
> +ame: not available
> +ype: application/pgp-signature
> +ize: 834 bytes
> +esc: not available
> +RL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
> +
> +eith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
> +ubject: [notmuch] Working with Maildir storage?
> +o: notmuch@notmuchmail.org
> +ate: Tue, 17 Nov 2009 13:24:13 -0800
> +
> +n Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
> + > See the patch just posted here.
> +
> +'ve also pushed a slightly more complicated (and complete) fix to my
> +rivate notmuch repository
> +
> +it://keithp.com/git/notmuch
> +
> + Is the list archived anywhere?
> +
> +ops. Looks like Carl's mail server is broken. He's traveling to
> +arcelona today and so it won't get fixed for a while.
> +
> +hanks to everyone for trying out notmuch!
> +
> +keith
> +
> +Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
> +Subject: Re: [notmuch] Working with Maildir storage?
> +To: Keith Packard <keithp@keithp.com>
> +Cc: notmuch@notmuchmail.org
> +Date: Tue, 17 Nov 2009 19:50:40 -0500
> +
> +[ multipart/mixed ]
> +[ multipart/signed ]
> +[ text/plain ]
> +> I've also pushed a slightly more complicated (and complete) fix to my
> +> private notmuch repository
> +
> +The version of lib/messages.cc in your repo doesn't build because it's
> +missing "#include <stdint.h>" (for the uint32_t on line 466).
> +
> +[ 5-line signature. Click/Enter to show. ]
> +--
> +Lars Kellogg-Stedman <lars@seas.harvard.edu>
> +Senior Technologist, Computing and Information Technology
> +Harvard University School of Engineering and Applied Sciences
> +
> +[ application/pgp-signature ]
> +[ text/plain ]
> +[ 4-line signature. Click/Enter to show. ]
> +_______________________________________________
> +notmuch mailing list
> +notmuch@notmuchmail.org
> +http://notmuchmail.org/mailman/listinfo/notmuch
> +Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
> +Subject: [notmuch] Working with Maildir storage?
> +To: notmuch@notmuchmail.org
> +Date: Wed, 18 Nov 2009 02:08:10 -0800
> +
> +On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
> +> I saw the LWN article and decided to take a look at notmuch. I'm
> +> currently using mutt and mairix to index and read a collection of
> +> Maildir mail folders (around 40,000 messages total).
> +
> +Welcome, Lars!
> +
> +I hadn't even seen that Keith's blog post had been picked up by lwn.net.
> +That's very interesting. So, thanks for coming and trying out notmuch.
> +
> +> Error opening
> +> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
> +> Too many open files
> +
> +Sadly, the lwn article coincided with me having just introduced this
> +bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
> +fairly quickly, but there was quite a bit of latency before I could push
> +the fix out. It should be fixed now.
> +
> +> I'm curious if this is expected behavior (i.e., notmuch does not work
> +> with Maildir) or if something else is going on.
> +
> +Notmuch works just fine with maildir---it's one of the things that it
> +likes the best.
> +
> +Happy hacking,
> +
> +-Carl
> +
> --
> 1.7.6
>
Non-text part: application/pgp-signature
[-- Attachment #2: Type: application/pgp-signature, Size: 202 bytes --]
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-12 23:46 ` Felix Geller
2011-07-16 13:25 ` Felix Geller
@ 2011-07-18 18:30 ` Jameson Graef Rollins
2011-07-18 18:57 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Felix Geller
2011-07-18 19:04 ` [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
1 sibling, 2 replies; 35+ messages in thread
From: Jameson Graef Rollins @ 2011-07-18 18:30 UTC (permalink / raw)
To: Felix Geller, notmuch
[-- Attachment #1: Type: text/plain, Size: 446 bytes --]
On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller <fgeller@gmail.com> wrote:
> Ok, tried again :)
Hey, Felix. It looks like the two attachments to your email are
actually the emails generated by format-patch that should have been sent
to the list. Instead of attaching them to other emails, send them to
the list directly. You might take a look at the git send-email command,
which can handle sending them directly for you.
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show
2011-07-18 18:30 ` Jameson Graef Rollins
@ 2011-07-18 18:57 ` Felix Geller
2011-07-18 18:57 ` [PATCH 2/2] Test for toggling message indentation Felix Geller
2011-07-18 19:14 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Jameson Graef Rollins
2011-07-18 19:04 ` [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
1 sibling, 2 replies; 35+ messages in thread
From: Felix Geller @ 2011-07-18 18:57 UTC (permalink / raw)
To: notmuch
---
emacs/notmuch-show.el | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f96743b..48df4c5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -90,6 +90,11 @@ any given message."
:group 'notmuch
:type 'boolean)
+(defcustom notmuch-show-indent-messages-in-thread t
+ "Should messages be indented according to their depth in a thread?"
+ :group 'notmuch
+ :type 'boolean)
+
(defcustom notmuch-show-indent-multipart nil
"Should the sub-parts of a multipart/* part be indented?"
;; dme: Not sure which is a good default.
@@ -237,8 +242,9 @@ unchanged ADDRESS if parsing fails."
"Insert a notmuch style headerline based on HEADERS for a
message at DEPTH in the current thread."
(let ((start (point)))
- (insert (notmuch-show-spaces-n depth)
- (notmuch-show-clean-address (plist-get headers :From))
+ (when notmuch-show-indent-messages-in-thread
+ (insert (notmuch-show-spaces-n depth)))
+ (insert (notmuch-show-clean-address (plist-get headers :From))
" ("
date
") ("
@@ -733,7 +739,8 @@ current buffer, if possible."
(setq content-end (point-marker))
;; Indent according to the depth in the thread.
- (indent-rigidly content-start content-end depth)
+ (when notmuch-show-indent-messages-in-thread
+ (indent-rigidly content-start content-end depth))
(setq message-end (point-max-marker))
--
1.7.6
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 2/2] Test for toggling message indentation
2011-07-18 18:57 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Felix Geller
@ 2011-07-18 18:57 ` Felix Geller
2011-07-18 19:14 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Jameson Graef Rollins
1 sibling, 0 replies; 35+ messages in thread
From: Felix Geller @ 2011-07-18 18:57 UTC (permalink / raw)
To: notmuch
---
test/emacs | 7 +
...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
diff --git a/test/emacs b/test/emacs
index 53f455a..c65d6d8 100755
--- a/test/emacs
+++ b/test/emacs
@@ -55,6 +55,13 @@ test_emacs "(notmuch-show \"$maildir_storage_thread\")
(test-output)"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs without indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-show-indent-messages-in-thread nil))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
new file mode 100644
index 0000000..00bd006
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+
+Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+See the patch just posted here.
+
+[ 2-line signature. Click/Enter to show. ]
+--
+ http://fossarchy.blogspot.com/
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Mikhail Gusarov <dottedmag@dottedmag.net>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> See the patch just posted here.
+
+Is the list archived anywhere? The obvious archives
+(http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+think I subscribed too late to get the patch (I only just saw the
+discussion about it).
+
+It doesn't look like the patch is in git yet.
+
+-- Lars
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+Twas brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+ LK> Is the list archived anywhere? The obvious archives
+ LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ LK> think I subscribed too late to get the patch (I only just saw the
+ LK> discussion about it).
+
+ LK> It doesn't look like the patch is in git yet.
+
+Just has been pushed
+
+[ 10-line signature. Click/Enter to show. ]
+--
+ http://fossarchy.blogspot.com/
+-------------- next part --------------
+A non-text attachment was scrubbed...
+Name: not available
+Type: application/pgp-signature
+Size: 834 bytes
+Desc: not available
+URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 13:24:13 -0800
+
+On Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> > See the patch just posted here.
+
+I've also pushed a slightly more complicated (and complete) fix to my
+private notmuch repository
+
+git://keithp.com/git/notmuch
+
+> Is the list archived anywhere?
+
+Oops. Looks like Carl's mail server is broken. He's traveling to
+Barcelona today and so it won't get fixed for a while.
+
+Thanks to everyone for trying out notmuch!
+
+-keith
+
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Keith Packard <keithp@keithp.com>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> I've also pushed a slightly more complicated (and complete) fix to my
+> private notmuch repository
+
+The version of lib/messages.cc in your repo doesn't build because it's
+missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> I saw the LWN article and decided to take a look at notmuch. I'm
+> currently using mutt and mairix to index and read a collection of
+> Maildir mail folders (around 40,000 messages total).
+
+Welcome, Lars!
+
+I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+That's very interesting. So, thanks for coming and trying out notmuch.
+
+> Error opening
+> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+> Too many open files
+
+Sadly, the lwn article coincided with me having just introduced this
+bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+fairly quickly, but there was quite a bit of latency before I could push
+the fix out. It should be fixed now.
+
+> I'm curious if this is expected behavior (i.e., notmuch does not work
+> with Maildir) or if something else is going on.
+
+Notmuch works just fine with maildir---it's one of the things that it
+likes the best.
+
+Happy hacking,
+
+-Carl
+
--
1.7.6
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-18 18:30 ` Jameson Graef Rollins
2011-07-18 18:57 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Felix Geller
@ 2011-07-18 19:04 ` Felix Geller
2011-07-18 19:10 ` David Bremner
1 sibling, 1 reply; 35+ messages in thread
From: Felix Geller @ 2011-07-18 19:04 UTC (permalink / raw)
To: Jameson Graef Rollins, notmuch
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Mon, 18 Jul 2011 11:30:53 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
Non-text part: multipart/signed
> On Wed, 13 Jul 2011 01:46:24 +0200, Felix Geller <fgeller@gmail.com> wrote:
> > Ok, tried again :)
>
> Hey, Felix. It looks like the two attachments to your email are
> actually the emails generated by format-patch that should have been sent
> to the list. Instead of attaching them to other emails, send them to
> the list directly. You might take a look at the git send-email command,
> which can handle sending them directly for you.
Used git send-email this time, did that turn out correctly? :)
Cheers, Felix
[-- Attachment #2: Type: application/pgp-signature, Size: 202 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH] Emacs: Add variable to toggle message indentation in a thread
2011-07-18 19:04 ` [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
@ 2011-07-18 19:10 ` David Bremner
0 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2011-07-18 19:10 UTC (permalink / raw)
To: Felix Geller, notmuch
On Mon, 18 Jul 2011 21:04:17 +0200, Felix Geller <fgeller@gmail.com> wrote:
>
> Used git send-email this time, did that turn out correctly? :)
>
It looks good, except you need some commit messages. Have a look at the
existing commits to get an idea of what the standards are. Particularly
look at cworth's commits and you'll know what he thinks ;)
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show
2011-07-18 18:57 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Felix Geller
2011-07-18 18:57 ` [PATCH 2/2] Test for toggling message indentation Felix Geller
@ 2011-07-18 19:14 ` Jameson Graef Rollins
2011-07-18 22:28 ` [PATCH] Emacs: Toggle message indentation for threads in notmuch-show Felix Geller
1 sibling, 1 reply; 35+ messages in thread
From: Jameson Graef Rollins @ 2011-07-18 19:14 UTC (permalink / raw)
To: Felix Geller, notmuch
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
Hi, Felix. Thanks for resubmitting these patches. A couple more
comments:
Remember to include a longer log message with you patch. Beyond just
the single line commit message, the patch should also include a longer
commit message, separated from the first line by a blank line, that
explains what exactly the patch is doing and why.
We've also been trying to get in the habit of sending patches to the
test suite *first*, before the patch that actually implements the
change. The reason being that we can apply the test-suite patch first,
see that the feature or bug fix you're trying to implement is not
implemented, then apply the fix and see that everything is working
again.
Now is probably a good time to remind everyone to look at the GIT patch
submission guidlines, which notmuch has been trying to follow (also
linked from http://notmuchmail.org):
http://repo.or.cz/w/git.git?a=blob;f=Documentation/SubmittingPatches;hb=HEAD
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH] Emacs: Toggle message indentation for threads in notmuch-show
2011-07-18 19:14 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Jameson Graef Rollins
@ 2011-07-18 22:28 ` Felix Geller
2011-07-18 22:28 ` [PATCH 1/2] Emacs: Test for turning off indentation of messages in threads Felix Geller
2011-07-18 22:28 ` [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show Felix Geller
0 siblings, 2 replies; 35+ messages in thread
From: Felix Geller @ 2011-07-18 22:28 UTC (permalink / raw)
To: notmuch
Yet another attempt at submitting a trivial patch for toggling message
indentation in Emacs' notmuch-show buffers and a test for such
functionality.
Signed-off-by: Felix Geller <fgeller@gmail.com>
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 1/2] Emacs: Test for turning off indentation of messages in threads
2011-07-18 22:28 ` [PATCH] Emacs: Toggle message indentation for threads in notmuch-show Felix Geller
@ 2011-07-18 22:28 ` Felix Geller
2011-07-18 22:28 ` [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show Felix Geller
1 sibling, 0 replies; 35+ messages in thread
From: Felix Geller @ 2011-07-18 22:28 UTC (permalink / raw)
To: notmuch
In Emacs, notmuch indents messages according to their thread
depth. This leads to unused space and sometimes strange
formatting of paragraphs with long lines. Therefore I would like
to turn it off and have the message thread look more like a
conversation, as on GMail for example.
This commit contains a test for such functionality. It tests
notmuch-show for a message thread without the indentation to
indicate thread depth of messages.
---
test/emacs | 7 +
...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
diff --git a/test/emacs b/test/emacs
index 53f455a..c65d6d8 100755
--- a/test/emacs
+++ b/test/emacs
@@ -55,6 +55,13 @@ test_emacs "(notmuch-show \"$maildir_storage_thread\")
(test-output)"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs without indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-show-indent-messages-in-thread nil))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
new file mode 100644
index 0000000..00bd006
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+
+Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+See the patch just posted here.
+
+[ 2-line signature. Click/Enter to show. ]
+--
+ http://fossarchy.blogspot.com/
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Mikhail Gusarov <dottedmag@dottedmag.net>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> See the patch just posted here.
+
+Is the list archived anywhere? The obvious archives
+(http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+think I subscribed too late to get the patch (I only just saw the
+discussion about it).
+
+It doesn't look like the patch is in git yet.
+
+-- Lars
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+Twas brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+ LK> Is the list archived anywhere? The obvious archives
+ LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ LK> think I subscribed too late to get the patch (I only just saw the
+ LK> discussion about it).
+
+ LK> It doesn't look like the patch is in git yet.
+
+Just has been pushed
+
+[ 10-line signature. Click/Enter to show. ]
+--
+ http://fossarchy.blogspot.com/
+-------------- next part --------------
+A non-text attachment was scrubbed...
+Name: not available
+Type: application/pgp-signature
+Size: 834 bytes
+Desc: not available
+URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 13:24:13 -0800
+
+On Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> > See the patch just posted here.
+
+I've also pushed a slightly more complicated (and complete) fix to my
+private notmuch repository
+
+git://keithp.com/git/notmuch
+
+> Is the list archived anywhere?
+
+Oops. Looks like Carl's mail server is broken. He's traveling to
+Barcelona today and so it won't get fixed for a while.
+
+Thanks to everyone for trying out notmuch!
+
+-keith
+
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Keith Packard <keithp@keithp.com>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> I've also pushed a slightly more complicated (and complete) fix to my
+> private notmuch repository
+
+The version of lib/messages.cc in your repo doesn't build because it's
+missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> I saw the LWN article and decided to take a look at notmuch. I'm
+> currently using mutt and mairix to index and read a collection of
+> Maildir mail folders (around 40,000 messages total).
+
+Welcome, Lars!
+
+I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+That's very interesting. So, thanks for coming and trying out notmuch.
+
+> Error opening
+> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+> Too many open files
+
+Sadly, the lwn article coincided with me having just introduced this
+bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+fairly quickly, but there was quite a bit of latency before I could push
+the fix out. It should be fixed now.
+
+> I'm curious if this is expected behavior (i.e., notmuch does not work
+> with Maildir) or if something else is going on.
+
+Notmuch works just fine with maildir---it's one of the things that it
+likes the best.
+
+Happy hacking,
+
+-Carl
+
--
1.7.6
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show
2011-07-18 22:28 ` [PATCH] Emacs: Toggle message indentation for threads in notmuch-show Felix Geller
2011-07-18 22:28 ` [PATCH 1/2] Emacs: Test for turning off indentation of messages in threads Felix Geller
@ 2011-07-18 22:28 ` Felix Geller
2011-07-19 10:50 ` configure indentation width instead? (was: Re: [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show) Gregor Zattler
1 sibling, 1 reply; 35+ messages in thread
From: Felix Geller @ 2011-07-18 22:28 UTC (permalink / raw)
To: notmuch
Add customizable variable notmuch-show-indent-messages-in-thread
to toggle indentation of messages in a thread in a notmuch-show
buffer.
---
emacs/notmuch-show.el | 13 ++++++++++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index f96743b..48df4c5 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -90,6 +90,11 @@ any given message."
:group 'notmuch
:type 'boolean)
+(defcustom notmuch-show-indent-messages-in-thread t
+ "Should messages be indented according to their depth in a thread?"
+ :group 'notmuch
+ :type 'boolean)
+
(defcustom notmuch-show-indent-multipart nil
"Should the sub-parts of a multipart/* part be indented?"
;; dme: Not sure which is a good default.
@@ -237,8 +242,9 @@ unchanged ADDRESS if parsing fails."
"Insert a notmuch style headerline based on HEADERS for a
message at DEPTH in the current thread."
(let ((start (point)))
- (insert (notmuch-show-spaces-n depth)
- (notmuch-show-clean-address (plist-get headers :From))
+ (when notmuch-show-indent-messages-in-thread
+ (insert (notmuch-show-spaces-n depth)))
+ (insert (notmuch-show-clean-address (plist-get headers :From))
" ("
date
") ("
@@ -733,7 +739,8 @@ current buffer, if possible."
(setq content-end (point-marker))
;; Indent according to the depth in the thread.
- (indent-rigidly content-start content-end depth)
+ (when notmuch-show-indent-messages-in-thread
+ (indent-rigidly content-start content-end depth))
(setq message-end (point-max-marker))
--
1.7.6
^ permalink raw reply related [flat|nested] 35+ messages in thread
* configure indentation width instead? (was: Re: [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show)
2011-07-18 22:28 ` [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show Felix Geller
@ 2011-07-19 10:50 ` Gregor Zattler
2011-08-16 20:24 ` Michal Sojka
0 siblings, 1 reply; 35+ messages in thread
From: Gregor Zattler @ 2011-07-19 10:50 UTC (permalink / raw)
To: notmuch
Hi Felix, notmuch develpers,
Felix introduces a boolean configuration variable in order to
disable/enable indentation. Wouldn't it be more helpful and
powerful to customise the indentation width with "0" meaning no
indentation, "1" being the current behaviour, "2" meaning double
indentation, "3" threefold indentation ... ?
Just my 2 Euro-cents, Gregor
^ permalink raw reply [flat|nested] 35+ messages in thread
* Re: configure indentation width instead? (was: Re: [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show)
2011-07-19 10:50 ` configure indentation width instead? (was: Re: [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show) Gregor Zattler
@ 2011-08-16 20:24 ` Michal Sojka
2011-10-23 16:43 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) Gregor Zattler
0 siblings, 1 reply; 35+ messages in thread
From: Michal Sojka @ 2011-08-16 20:24 UTC (permalink / raw)
To: Gregor Zattler, notmuch
On Tue, 19 Jul 2011, Gregor Zattler wrote:
> Hi Felix, notmuch develpers,
>
> Felix introduces a boolean configuration variable in order to
> disable/enable indentation. Wouldn't it be more helpful and
> powerful to customise the indentation width with "0" meaning no
> indentation, "1" being the current behaviour, "2" meaning double
> indentation, "3" threefold indentation ... ?
+1
Sometimes I find indenting by one character too small to find the
replied message in long threads.
-Michal
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?)
2011-08-16 20:24 ` Michal Sojka
@ 2011-10-23 16:43 ` Gregor Zattler
2011-10-23 16:52 ` [PATCH 1/2] emacs: add customisation for message indentation width Gregor Zattler
` (2 more replies)
0 siblings, 3 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-10-23 16:43 UTC (permalink / raw)
To: notmuch
Hi Michal, Felix, notmuch developers,
* Michal Sojka <sojkam1@fel.cvut.cz> [16. Aug. 2011]:
> On Tue, 19 Jul 2011, Gregor Zattler wrote:
>> Felix introduces a boolean configuration variable in order to
>> disable/enable indentation. Wouldn't it be more helpful and
>> powerful to customise the indentation width with "0" meaning no
>> indentation, "1" being the current behaviour, "2" meaning double
>> indentation, "3" threefold indentation ... ?
>
> +1
>
> Sometimes I find indenting by one character too small to find the
> replied message in long threads.
I also need more indentation in order to not get lost in long
threads and displays are wide today.
I now altered Felix' patches from dis/enabling indentation to
making indentation customisable. I actually have no clue of
elisp and the test suite, I really only altered his patches.
The actual patch makes message indentation customisable by
introducing a variable `notmuch-indent-messages-width' which
defaults to `1', which is the same as before. Felix could set
this variable to `0' in order to disable indentation, I tested it
with a value of `4' for a clearer separation of messages in a
thread. This patch works for me.
I also altered Felix test to use this new variable. I don't know
how to run the test suite and therefore don't know if it really
tests zero indentation.
HTH and thanks for notmuch and notmuch-Emacs which perhaps helps
me to use Emacs as a MUA, Gregor
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 1/2] emacs: add customisation for message indentation width
2011-10-23 16:43 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) Gregor Zattler
@ 2011-10-23 16:52 ` Gregor Zattler
2011-10-23 17:00 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) David Bremner
2011-10-23 17:00 ` [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation Gregor Zattler
2 siblings, 0 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-10-23 16:52 UTC (permalink / raw)
To: notmuch
Messages are shown indented according to their depth in message
threads. Previously indentation width was hardcoded to `1'
space. This patch adds a new variable `notmuch-indent-messages-width'
which governs how many spaces are used per level of indentation.
Defaults to `1' for compatibility with previous behaviour.
---
emacs/notmuch-show.el | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 8db5435..897b492 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -90,6 +90,16 @@ any given message."
:group 'notmuch
:type 'boolean)
+(defcustom notmuch-indent-messages-width 1
+ "Width of message indentation in threads.
+
+Messages are shown indented according to their depth in a thread.
+This variable determines the width of this indentation measured
+in number of blanks. Defaults to `1', choose `0' to disable
+indentation."
+ :group 'notmuch
+ :type 'integer)
+
(defcustom notmuch-show-indent-multipart nil
"Should the sub-parts of a multipart/* part be indented?"
;; dme: Not sure which is a good default.
@@ -237,7 +247,7 @@ unchanged ADDRESS if parsing fails."
"Insert a notmuch style headerline based on HEADERS for a
message at DEPTH in the current thread."
(let ((start (point)))
- (insert (notmuch-show-spaces-n depth)
+ (insert (notmuch-show-spaces-n (* notmuch-indent-messages-width depth))
(notmuch-show-clean-address (plist-get headers :From))
" ("
date
@@ -738,7 +748,7 @@ current buffer, if possible."
(setq content-end (point-marker))
;; Indent according to the depth in the thread.
- (indent-rigidly content-start content-end depth)
+ (indent-rigidly content-start content-end (* notmuch-indent-messages-width depth))
(setq message-end (point-max-marker))
--
1.7.7
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?)
2011-10-23 16:43 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) Gregor Zattler
2011-10-23 16:52 ` [PATCH 1/2] emacs: add customisation for message indentation width Gregor Zattler
@ 2011-10-23 17:00 ` David Bremner
2011-10-23 17:00 ` [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation Gregor Zattler
2 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2011-10-23 17:00 UTC (permalink / raw)
To: Gregor Zattler, notmuch
On Sun, 23 Oct 2011 18:43:24 +0200, Gregor Zattler <telegraph@gmx.net> wrote:
>
> I also altered Felix test to use this new variable. I don't know
> how to run the test suite and therefore don't know if it really
> tests zero indentation.
>
Perhaps I misunderstand you, but running test suite is documented in
test/README.
Of course, whether a particular feature is tested is a different
question and requires examining (in this case) test/emacs.
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation
2011-10-23 16:43 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) Gregor Zattler
2011-10-23 16:52 ` [PATCH 1/2] emacs: add customisation for message indentation width Gregor Zattler
2011-10-23 17:00 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) David Bremner
@ 2011-10-23 17:00 ` Gregor Zattler
2011-10-23 19:09 ` sorry, this test does not work (was: Re: [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation) Gregor Zattler
2 siblings, 1 reply; 35+ messages in thread
From: Gregor Zattler @ 2011-10-23 17:00 UTC (permalink / raw)
To: notmuch
In Emacs, notmuch indents messages according to their thread
depth. This leads to unused space and sometimes strange
formatting of paragraphs with long lines. Therefore I would like
to turn it off and have the message thread look more like a
conversation, as on GMail for example.
This commit contains a test for such functionality. It tests
notmuch-show for a message thread without the indentation to
indicate thread depth of messages by setting
notmuch-indent-messages-width to `0'.
---
I send this test as second patch since it depends on the
notmuch-indent-messages-width variable introduced by the first
one.
test/emacs | 7 +
...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/notmuch-show-thread-maildir-storage-without-indentation
diff --git a/test/emacs b/test/emacs
index 0303d7d..6e201ba 100755
--- a/test/emacs
+++ b/test/emacs
@@ -50,6 +50,13 @@ test_emacs "(notmuch-show \"$maildir_storage_thread\")
(test-output)"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs without indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-indent-messages-width 0))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/notmuch-show-thread-maildir-storage-without-indentation b/test/notmuch-show-thread-maildir-storage-without-indentation
new file mode 100644
index 0000000..00bd006
--- /dev/null
+++ b/test/notmuch-show-thread-maildir-storage-without-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+
+Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+See the patch just posted here.
+
+[ 2-line signature. Click/Enter to show. ]
+--
+ http://fossarchy.blogspot.com/
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Mikhail Gusarov <dottedmag@dottedmag.net>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> See the patch just posted here.
+
+Is the list archived anywhere? The obvious archives
+(http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+think I subscribed too late to get the patch (I only just saw the
+discussion about it).
+
+It doesn't look like the patch is in git yet.
+
+-- Lars
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+Twas brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+ LK> Is the list archived anywhere? The obvious archives
+ LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ LK> think I subscribed too late to get the patch (I only just saw the
+ LK> discussion about it).
+
+ LK> It doesn't look like the patch is in git yet.
+
+Just has been pushed
+
+[ 10-line signature. Click/Enter to show. ]
+--
+ http://fossarchy.blogspot.com/
+-------------- next part --------------
+A non-text attachment was scrubbed...
+Name: not available
+Type: application/pgp-signature
+Size: 834 bytes
+Desc: not available
+URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 13:24:13 -0800
+
+On Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> > See the patch just posted here.
+
+I've also pushed a slightly more complicated (and complete) fix to my
+private notmuch repository
+
+git://keithp.com/git/notmuch
+
+> Is the list archived anywhere?
+
+Oops. Looks like Carl's mail server is broken. He's traveling to
+Barcelona today and so it won't get fixed for a while.
+
+Thanks to everyone for trying out notmuch!
+
+-keith
+
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Keith Packard <keithp@keithp.com>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> I've also pushed a slightly more complicated (and complete) fix to my
+> private notmuch repository
+
+The version of lib/messages.cc in your repo doesn't build because it's
+missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> I saw the LWN article and decided to take a look at notmuch. I'm
+> currently using mutt and mairix to index and read a collection of
+> Maildir mail folders (around 40,000 messages total).
+
+Welcome, Lars!
+
+I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+That's very interesting. So, thanks for coming and trying out notmuch.
+
+> Error opening
+> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+> Too many open files
+
+Sadly, the lwn article coincided with me having just introduced this
+bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+fairly quickly, but there was quite a bit of latency before I could push
+the fix out. It should be fixed now.
+
+> I'm curious if this is expected behavior (i.e., notmuch does not work
+> with Maildir) or if something else is going on.
+
+Notmuch works just fine with maildir---it's one of the things that it
+likes the best.
+
+Happy hacking,
+
+-Carl
+
--
1.7.7
^ permalink raw reply related [flat|nested] 35+ messages in thread
* sorry, this test does not work (was: Re: [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation)
2011-10-23 17:00 ` [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation Gregor Zattler
@ 2011-10-23 19:09 ` Gregor Zattler
2011-10-23 19:38 ` [PATCH 2a/2] emacs: test notmuch-indent-messages-width default Gregor Zattler
` (2 more replies)
0 siblings, 3 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-10-23 19:09 UTC (permalink / raw)
To: notmuch
Hi David, notmuch developers,
thanks to David (id:8762jfabih.fsf@zancas.localnet), I now know
that the test in the parent message does not work.
Sorry for the noise, I'll provide a functional test.
* Gregor Zattler <telegraph@gmx.net> [23. Oct. 2011]:
> In Emacs, notmuch indents messages according to their thread
> depth. This leads to unused space and sometimes strange
> formatting of paragraphs with long lines. Therefore I would like
> to turn it off and have the message thread look more like a
> conversation, as on GMail for example.
>
> This commit contains a test for such functionality. It tests
> notmuch-show for a message thread without the indentation to
> indicate thread depth of messages by setting
> notmuch-indent-messages-width to `0'.
> ---
> I send this test as second patch since it depends on the
> notmuch-indent-messages-width variable introduced by the first
> one.
>
> test/emacs | 7 +
> ...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
> 2 files changed, 222 insertions(+), 0 deletions(-)
> create mode 100644 test/notmuch-show-thread-maildir-storage-without-indentation
Gregor
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 2a/2] emacs: test notmuch-indent-messages-width default
2011-10-23 19:09 ` sorry, this test does not work (was: Re: [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation) Gregor Zattler
@ 2011-10-23 19:38 ` Gregor Zattler
2011-11-24 13:13 ` David Bremner
2011-10-23 19:41 ` [PATCH 2b/2] emacs: test: notmuch show without indentation Gregor Zattler
2011-10-23 19:42 ` [PATCH 2c/2] emacs: test notmuch show with fourfold message indentation Gregor Zattler
2 siblings, 1 reply; 35+ messages in thread
From: Gregor Zattler @ 2011-10-23 19:38 UTC (permalink / raw)
To: notmuch
From e9cbb995c2d51cb3de3baa485e9a6861f6c36b0a Mon Sep 17 00:00:00 2001
From: Gregor Zattler <telegraph@gmx.net>
Date: Sun, 23 Oct 2011 21:10:18 +0200
Subject: [PATCH] emacs: test notmuch-indent-messages-width default
Previous behaviour was to indent messages in a thread according
to depth by one space per level. This is still the case with
notmuch-indent-messages-width default value `1'. This test
succeeds if output with default value is same as in "Basic
notmuch-show view in emacs".
---
test/emacs | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 0303d7d..3571214 100755
--- a/test/emacs
+++ b/test/emacs
@@ -50,6 +50,13 @@ test_emacs "(notmuch-show \"$maildir_storage_thread\")
(test-output)"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs default indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-indent-messages-width 1))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
--
1.7.7
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 2b/2] emacs: test: notmuch show without indentation
2011-10-23 19:09 ` sorry, this test does not work (was: Re: [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation) Gregor Zattler
2011-10-23 19:38 ` [PATCH 2a/2] emacs: test notmuch-indent-messages-width default Gregor Zattler
@ 2011-10-23 19:41 ` Gregor Zattler
2011-10-23 19:42 ` [PATCH 2c/2] emacs: test notmuch show with fourfold message indentation Gregor Zattler
2 siblings, 0 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-10-23 19:41 UTC (permalink / raw)
To: notmuch
From f4b52f67f08880fca41932fe70db72cdf2729ad2 Mon Sep 17 00:00:00 2001
From: Gregor Zattler <telegraph@gmx.net>
Date: Sun, 23 Oct 2011 21:21:47 +0200
Subject: [PATCH] emacs: test: notmuch show without indentation
Previous behaviour was to indent messages in a thread according
to depth by one space per level. In
id:1311028119-50637-1-git-send-email-fgeller@gmail.com Felix
Geller proposed a patch in order to turn indentation off. This
commit tests if instead setting notmuch-indent-messages-width to
`0' does turn off indentation.
---
test/emacs | 7 +
...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
diff --git a/test/emacs b/test/emacs
index 3571214..6fa0fd4 100755
--- a/test/emacs
+++ b/test/emacs
@@ -57,6 +57,13 @@ test_emacs "(let ((notmuch-indent-messages-width 1))
(test-output))"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs without indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-indent-messages-width 0))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
new file mode 100644
index 0000000..fa2108e
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+
+Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+See the patch just posted here.
+
+[ 2-line signature. Click/Enter to show. ]
+--
+http://fossarchy.blogspot.com/
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Mikhail Gusarov <dottedmag@dottedmag.net>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> See the patch just posted here.
+
+Is the list archived anywhere? The obvious archives
+(http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+think I subscribed too late to get the patch (I only just saw the
+discussion about it).
+
+It doesn't look like the patch is in git yet.
+
+-- Lars
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+Twas brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+ LK> Is the list archived anywhere? The obvious archives
+ LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ LK> think I subscribed too late to get the patch (I only just saw the
+ LK> discussion about it).
+
+ LK> It doesn't look like the patch is in git yet.
+
+Just has been pushed
+
+[ 10-line signature. Click/Enter to show. ]
+--
+http://fossarchy.blogspot.com/
+-------------- next part --------------
+A non-text attachment was scrubbed...
+Name: not available
+Type: application/pgp-signature
+Size: 834 bytes
+Desc: not available
+URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 13:24:13 -0800
+
+On Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> > See the patch just posted here.
+
+I've also pushed a slightly more complicated (and complete) fix to my
+private notmuch repository
+
+git://keithp.com/git/notmuch
+
+> Is the list archived anywhere?
+
+Oops. Looks like Carl's mail server is broken. He's traveling to
+Barcelona today and so it won't get fixed for a while.
+
+Thanks to everyone for trying out notmuch!
+
+-keith
+
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Keith Packard <keithp@keithp.com>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> I've also pushed a slightly more complicated (and complete) fix to my
+> private notmuch repository
+
+The version of lib/messages.cc in your repo doesn't build because it's
+missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> I saw the LWN article and decided to take a look at notmuch. I'm
+> currently using mutt and mairix to index and read a collection of
+> Maildir mail folders (around 40,000 messages total).
+
+Welcome, Lars!
+
+I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+That's very interesting. So, thanks for coming and trying out notmuch.
+
+> Error opening
+> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+> Too many open files
+
+Sadly, the lwn article coincided with me having just introduced this
+bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+fairly quickly, but there was quite a bit of latency before I could push
+the fix out. It should be fixed now.
+
+> I'm curious if this is expected behavior (i.e., notmuch does not work
+> with Maildir) or if something else is going on.
+
+Notmuch works just fine with maildir---it's one of the things that it
+likes the best.
+
+Happy hacking,
+
+-Carl
+
--
1.7.7
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 2c/2] emacs: test notmuch show with fourfold message indentation
2011-10-23 19:09 ` sorry, this test does not work (was: Re: [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation) Gregor Zattler
2011-10-23 19:38 ` [PATCH 2a/2] emacs: test notmuch-indent-messages-width default Gregor Zattler
2011-10-23 19:41 ` [PATCH 2b/2] emacs: test: notmuch show without indentation Gregor Zattler
@ 2011-10-23 19:42 ` Gregor Zattler
2 siblings, 0 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-10-23 19:42 UTC (permalink / raw)
To: notmuch
From b5d459eb961ff218042e7bd134346ce2c2357dca Mon Sep 17 00:00:00 2001
From: Gregor Zattler <telegraph@gmx.net>
Date: Sun, 23 Oct 2011 21:28:09 +0200
Subject: [PATCH] emacs: test notmuch show with fourfold message indentation
Previous behaviour was to indent messages in a thread according
to depth by one space per level. This commit tests if setting
notmuch-indent-messages-width to `4' provides a message thread
with four spaces of indentation thread depth.
---
test/emacs | 7 +
...hread-maildir-storage-with-fourfold-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
diff --git a/test/emacs b/test/emacs
index 6fa0fd4..5ca720e 100755
--- a/test/emacs
+++ b/test/emacs
@@ -64,6 +64,13 @@ test_emacs "(let ((notmuch-indent-messages-width 0))
(test-output))"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+test_begin_subtest "Basic notmuch-show view in emacs with fourfold indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-indent-messages-width 4))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-with-fourfold-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
new file mode 100644
index 0000000..41e2aaa
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+ Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+ Subject: Re: [notmuch] Working with Maildir storage?
+ To: notmuch@notmuchmail.org
+ Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+ [ multipart/mixed ]
+ [ multipart/signed ]
+ [ text/plain ]
+
+ Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+ See the patch just posted here.
+
+ [ 2-line signature. Click/Enter to show. ]
+ --
+ http://fossarchy.blogspot.com/
+ [ application/pgp-signature ]
+ [ text/plain ]
+ [ 4-line signature. Click/Enter to show. ]
+ _______________________________________________
+ notmuch mailing list
+ notmuch@notmuchmail.org
+ http://notmuchmail.org/mailman/listinfo/notmuch
+ Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+ Subject: Re: [notmuch] Working with Maildir storage?
+ To: Mikhail Gusarov <dottedmag@dottedmag.net>
+ Cc: notmuch@notmuchmail.org
+ Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+ [ multipart/mixed ]
+ [ multipart/signed ]
+ [ text/plain ]
+ > See the patch just posted here.
+
+ Is the list archived anywhere? The obvious archives
+ (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ think I subscribed too late to get the patch (I only just saw the
+ discussion about it).
+
+ It doesn't look like the patch is in git yet.
+
+ -- Lars
+
+ [ 5-line signature. Click/Enter to show. ]
+ --
+ Lars Kellogg-Stedman <lars@seas.harvard.edu>
+ Senior Technologist, Computing and Information Technology
+ Harvard University School of Engineering and Applied Sciences
+
+ [ application/pgp-signature ]
+ [ text/plain ]
+ [ 4-line signature. Click/Enter to show. ]
+ _______________________________________________
+ notmuch mailing list
+ notmuch@notmuchmail.org
+ http://notmuchmail.org/mailman/listinfo/notmuch
+ Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+ Subject: [notmuch] Working with Maildir storage?
+ To: notmuch@notmuchmail.org
+ Date: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+ Twas brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+ LK> Is the list archived anywhere? The obvious archives
+ LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ LK> think I subscribed too late to get the patch (I only just saw the
+ LK> discussion about it).
+
+ LK> It doesn't look like the patch is in git yet.
+
+ Just has been pushed
+
+ [ 10-line signature. Click/Enter to show. ]
+ --
+ http://fossarchy.blogspot.com/
+ -------------- next part --------------
+ A non-text attachment was scrubbed...
+ Name: not available
+ Type: application/pgp-signature
+ Size: 834 bytes
+ Desc: not available
+ URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+ Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+ Subject: [notmuch] Working with Maildir storage?
+ To: notmuch@notmuchmail.org
+ Date: Tue, 17 Nov 2009 13:24:13 -0800
+
+ On Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+ > > See the patch just posted here.
+
+ I've also pushed a slightly more complicated (and complete) fix to my
+ private notmuch repository
+
+ git://keithp.com/git/notmuch
+
+ > Is the list archived anywhere?
+
+ Oops. Looks like Carl's mail server is broken. He's traveling to
+ Barcelona today and so it won't get fixed for a while.
+
+ Thanks to everyone for trying out notmuch!
+
+ -keith
+
+ Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+ Subject: Re: [notmuch] Working with Maildir storage?
+ To: Keith Packard <keithp@keithp.com>
+ Cc: notmuch@notmuchmail.org
+ Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+ [ multipart/mixed ]
+ [ multipart/signed ]
+ [ text/plain ]
+ > I've also pushed a slightly more complicated (and complete) fix to my
+ > private notmuch repository
+
+ The version of lib/messages.cc in your repo doesn't build because it's
+ missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+ [ 5-line signature. Click/Enter to show. ]
+ --
+ Lars Kellogg-Stedman <lars@seas.harvard.edu>
+ Senior Technologist, Computing and Information Technology
+ Harvard University School of Engineering and Applied Sciences
+
+ [ application/pgp-signature ]
+ [ text/plain ]
+ [ 4-line signature. Click/Enter to show. ]
+ _______________________________________________
+ notmuch mailing list
+ notmuch@notmuchmail.org
+ http://notmuchmail.org/mailman/listinfo/notmuch
+ Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+ Subject: [notmuch] Working with Maildir storage?
+ To: notmuch@notmuchmail.org
+ Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+ On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+ > I saw the LWN article and decided to take a look at notmuch. I'm
+ > currently using mutt and mairix to index and read a collection of
+ > Maildir mail folders (around 40,000 messages total).
+
+ Welcome, Lars!
+
+ I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+ That's very interesting. So, thanks for coming and trying out notmuch.
+
+ > Error opening
+ > /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ > Too many open files
+
+ Sadly, the lwn article coincided with me having just introduced this
+ bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+ fairly quickly, but there was quite a bit of latency before I could push
+ the fix out. It should be fixed now.
+
+ > I'm curious if this is expected behavior (i.e., notmuch does not work
+ > with Maildir) or if something else is going on.
+
+ Notmuch works just fine with maildir---it's one of the things that it
+ likes the best.
+
+ Happy hacking,
+
+ -Carl
+
--
1.7.7
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default
2011-10-23 19:38 ` [PATCH 2a/2] emacs: test notmuch-indent-messages-width default Gregor Zattler
@ 2011-11-24 13:13 ` David Bremner
2011-11-24 22:03 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) Gregor Zattler
0 siblings, 1 reply; 35+ messages in thread
From: David Bremner @ 2011-11-24 13:13 UTC (permalink / raw)
To: Gregor Zattler, notmuch
On Sun, 23 Oct 2011 21:38:43 +0200, Gregor Zattler <telegraph@gmx.net> wrote:
> From e9cbb995c2d51cb3de3baa485e9a6861f6c36b0a Mon Sep 17 00:00:00 2001
> From: Gregor Zattler <telegraph@gmx.net>
> Date: Sun, 23 Oct 2011 21:10:18 +0200
> Subject: [PATCH] emacs: test notmuch-indent-messages-width default
Hi Gregor;
The extra copy of the patch header messes up the log messages with the 3
test related patches in this series are applied. Can you resend with
git-send-email?
d
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default)
2011-11-24 13:13 ` David Bremner
@ 2011-11-24 22:03 ` Gregor Zattler
2011-11-24 22:03 ` [PATCH 1/4] emacs: make message indentation width customisable Gregor Zattler
` (4 more replies)
0 siblings, 5 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-11-24 22:03 UTC (permalink / raw)
To: notmuch
Dear David, notmuch developers,
* David Bremner <david@tethera.net> [24. Nov. 2011]:
> On Sun, 23 Oct 2011 21:38:43 +0200, Gregor Zattler <telegraph@gmx.net> wrote:
> The extra copy of the patch header messes up the log messages with the 3
> test related patches in this series are applied. Can you resend with
> git-send-email?
Sure.
Felix Geller started this thread by proposing a patch to turn off
message indentation in notmuch show. I instead wanted more
indentation. I propose this patch set which
a) makes indentation width configurable, therefore Felix may set
it to `0' which turns indentation off, I set it to `4' since I
want clearer indication of thread level, while default is `1'
which is the same as before.
b) contains three tests fore the above mentioned indentation width
values.
Thanks for notmuch, gregor
Gregor Zattler (4):
emacs: make message indentation width customisable
emacs: test notmuch-indent-messages-width default
emacs: test: notmuch show without indentation
emacs: test notmuch show with fourfold message indentation
emacs/notmuch-show.el | 14 +-
test/emacs | 21 ++
...hread-maildir-storage-with-fourfold-indentation | 215 ++++++++++++++++++++
...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
4 files changed, 463 insertions(+), 2 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
--
1.7.7.3
^ permalink raw reply [flat|nested] 35+ messages in thread
* [PATCH 1/4] emacs: make message indentation width customisable
2011-11-24 22:03 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) Gregor Zattler
@ 2011-11-24 22:03 ` Gregor Zattler
2011-11-24 22:03 ` [PATCH 2/4] emacs: test notmuch-indent-messages-width default Gregor Zattler
` (3 subsequent siblings)
4 siblings, 0 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-11-24 22:03 UTC (permalink / raw)
To: notmuch
Till now Emacs UI indents messages according to their respecive
depth of neting in the thread. The actual width of indentation
per level is hardcoded to `1' space.
This patch makes message indentation customisable by introducing
a variable `notmuch-indent-messages-width' which defaults to `1',
which is the same as before. Felix could set this variable to
`0' in order to disable indentation, I tested it with a value of
`4' for a clearer separation of messages in a thread.
---
emacs/notmuch-show.el | 14 ++++++++++++--
1 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 7be88f8..d7fbbca 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -91,6 +91,16 @@ any given message."
:group 'notmuch
:type 'boolean)
+(defcustom notmuch-indent-messages-width 1
+ "Width of message indentation in threads.
+
+Messages are shown indented according to their depth in a thread.
+This variable determines the width of this indentation measured
+in number of blanks. Defaults to `1', choose `0' to disable
+indentation."
+ :group 'notmuch
+ :type 'integer)
+
(defcustom notmuch-show-indent-multipart nil
"Should the sub-parts of a multipart/* part be indented?"
;; dme: Not sure which is a good default.
@@ -238,7 +248,7 @@ unchanged ADDRESS if parsing fails."
"Insert a notmuch style headerline based on HEADERS for a
message at DEPTH in the current thread."
(let ((start (point)))
- (insert (notmuch-show-spaces-n depth)
+ (insert (notmuch-show-spaces-n (* notmuch-indent-messages-width depth))
(notmuch-show-clean-address (plist-get headers :From))
" ("
date
@@ -739,7 +749,7 @@ current buffer, if possible."
(setq content-end (point-marker))
;; Indent according to the depth in the thread.
- (indent-rigidly content-start content-end depth)
+ (indent-rigidly content-start content-end (* notmuch-indent-messages-width depth))
(setq message-end (point-max-marker))
--
1.7.7.3
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 2/4] emacs: test notmuch-indent-messages-width default
2011-11-24 22:03 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) Gregor Zattler
2011-11-24 22:03 ` [PATCH 1/4] emacs: make message indentation width customisable Gregor Zattler
@ 2011-11-24 22:03 ` Gregor Zattler
2011-11-24 22:03 ` [PATCH 3/4] emacs: test: notmuch show without indentation Gregor Zattler
` (2 subsequent siblings)
4 siblings, 0 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-11-24 22:03 UTC (permalink / raw)
To: notmuch
Previous behaviour was to indent messages in a thread according
to depth by one space per level. This is still the case with
notmuch-indent-messages-width default value `1'. This test
succeeds if output with default value is same as in "Basic
notmuch-show view in emacs".
---
test/emacs | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 3bf2e29..20d52d8 100755
--- a/test/emacs
+++ b/test/emacs
@@ -50,6 +50,13 @@ test_emacs "(notmuch-show \"$maildir_storage_thread\")
(test-output)"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs default indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-indent-messages-width 1))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
--
1.7.7.3
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 3/4] emacs: test: notmuch show without indentation
2011-11-24 22:03 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) Gregor Zattler
2011-11-24 22:03 ` [PATCH 1/4] emacs: make message indentation width customisable Gregor Zattler
2011-11-24 22:03 ` [PATCH 2/4] emacs: test notmuch-indent-messages-width default Gregor Zattler
@ 2011-11-24 22:03 ` Gregor Zattler
2011-11-24 22:03 ` [PATCH 4/4] emacs: test notmuch show with fourfold message indentation Gregor Zattler
2011-11-26 5:18 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) David Bremner
4 siblings, 0 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-11-24 22:03 UTC (permalink / raw)
To: notmuch
Previous behaviour was to indent messages in a thread according
to depth by one space per level. In
id:1311028119-50637-1-git-send-email-fgeller@gmail.com Felix
Geller proposed a patch in order to turn indentation off. This
commit tests if instead setting notmuch-indent-messages-width to
`0' does turn off indentation.
---
test/emacs | 7 +
...show-thread-maildir-storage-without-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
diff --git a/test/emacs b/test/emacs
index 20d52d8..da6d22b 100755
--- a/test/emacs
+++ b/test/emacs
@@ -57,6 +57,13 @@ test_emacs "(let ((notmuch-indent-messages-width 1))
(test-output))"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage
+test_begin_subtest "Basic notmuch-show view in emacs without indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-indent-messages-width 0))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
new file mode 100644
index 0000000..fa2108e
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-without-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+
+Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+See the patch just posted here.
+
+[ 2-line signature. Click/Enter to show. ]
+--
+http://fossarchy.blogspot.com/
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Mikhail Gusarov <dottedmag@dottedmag.net>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> See the patch just posted here.
+
+Is the list archived anywhere? The obvious archives
+(http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+think I subscribed too late to get the patch (I only just saw the
+discussion about it).
+
+It doesn't look like the patch is in git yet.
+
+-- Lars
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+Twas brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+ LK> Is the list archived anywhere? The obvious archives
+ LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ LK> think I subscribed too late to get the patch (I only just saw the
+ LK> discussion about it).
+
+ LK> It doesn't look like the patch is in git yet.
+
+Just has been pushed
+
+[ 10-line signature. Click/Enter to show. ]
+--
+http://fossarchy.blogspot.com/
+-------------- next part --------------
+A non-text attachment was scrubbed...
+Name: not available
+Type: application/pgp-signature
+Size: 834 bytes
+Desc: not available
+URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 13:24:13 -0800
+
+On Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> > See the patch just posted here.
+
+I've also pushed a slightly more complicated (and complete) fix to my
+private notmuch repository
+
+git://keithp.com/git/notmuch
+
+> Is the list archived anywhere?
+
+Oops. Looks like Carl's mail server is broken. He's traveling to
+Barcelona today and so it won't get fixed for a while.
+
+Thanks to everyone for trying out notmuch!
+
+-keith
+
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+Subject: Re: [notmuch] Working with Maildir storage?
+To: Keith Packard <keithp@keithp.com>
+Cc: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+> I've also pushed a slightly more complicated (and complete) fix to my
+> private notmuch repository
+
+The version of lib/messages.cc in your repo doesn't build because it's
+missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+> I saw the LWN article and decided to take a look at notmuch. I'm
+> currently using mutt and mairix to index and read a collection of
+> Maildir mail folders (around 40,000 messages total).
+
+Welcome, Lars!
+
+I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+That's very interesting. So, thanks for coming and trying out notmuch.
+
+> Error opening
+> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+> Too many open files
+
+Sadly, the lwn article coincided with me having just introduced this
+bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+fairly quickly, but there was quite a bit of latency before I could push
+the fix out. It should be fixed now.
+
+> I'm curious if this is expected behavior (i.e., notmuch does not work
+> with Maildir) or if something else is going on.
+
+Notmuch works just fine with maildir---it's one of the things that it
+likes the best.
+
+Happy hacking,
+
+-Carl
+
--
1.7.7.3
^ permalink raw reply related [flat|nested] 35+ messages in thread
* [PATCH 4/4] emacs: test notmuch show with fourfold message indentation
2011-11-24 22:03 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) Gregor Zattler
` (2 preceding siblings ...)
2011-11-24 22:03 ` [PATCH 3/4] emacs: test: notmuch show without indentation Gregor Zattler
@ 2011-11-24 22:03 ` Gregor Zattler
2011-11-26 5:18 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) David Bremner
4 siblings, 0 replies; 35+ messages in thread
From: Gregor Zattler @ 2011-11-24 22:03 UTC (permalink / raw)
To: notmuch
Previous behaviour was to indent messages in a thread according
to depth by one space per level. This commit tests if setting
notmuch-indent-messages-width to `4' provides a message thread
with four spaces of indentation thread depth.
---
test/emacs | 7 +
...hread-maildir-storage-with-fourfold-indentation | 215 ++++++++++++++++++++
2 files changed, 222 insertions(+), 0 deletions(-)
create mode 100644 test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
diff --git a/test/emacs b/test/emacs
index da6d22b..198c27b 100755
--- a/test/emacs
+++ b/test/emacs
@@ -64,6 +64,13 @@ test_emacs "(let ((notmuch-indent-messages-width 0))
(test-output))"
test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-without-indentation
+test_begin_subtest "Basic notmuch-show view in emacs with fourfold indentation"
+maildir_storage_thread=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu)
+test_emacs "(let ((notmuch-indent-messages-width 4))
+ (notmuch-show \"$maildir_storage_thread\")
+ (test-output))"
+test_expect_equal_file OUTPUT $EXPECTED/notmuch-show-thread-maildir-storage-with-fourfold-indentation
+
test_begin_subtest "notmuch-show for message with invalid From"
add_message "[subject]=\"message-with-invalid-from\"" \
"[from]=\"\\\"Invalid \\\" From\\\" <test_suite@notmuchmail.org>\""
diff --git a/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
new file mode 100644
index 0000000..41e2aaa
--- /dev/null
+++ b/test/emacs.expected-output/notmuch-show-thread-maildir-storage-with-fourfold-indentation
@@ -0,0 +1,215 @@
+Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed)
+Subject: [notmuch] Working with Maildir storage?
+To: notmuch@notmuchmail.org
+Date: Tue, 17 Nov 2009 14:00:54 -0500
+
+[ multipart/mixed ]
+[ multipart/signed ]
+[ text/plain ]
+I saw the LWN article and decided to take a look at notmuch. I'm
+currently using mutt and mairix to index and read a collection of
+Maildir mail folders (around 40,000 messages total).
+
+notmuch indexed the messages without complaint, but my attempt at
+searching bombed out. Running, for example:
+
+ notmuch search storage
+
+Resulted in 4604 lines of errors along the lines of:
+
+ Error opening
+ /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ Too many open files
+
+I'm curious if this is expected behavior (i.e., notmuch does not work
+with Maildir) or if something else is going on.
+
+Cheers,
+
+[ 5-line signature. Click/Enter to show. ]
+--
+Lars Kellogg-Stedman <lars@seas.harvard.edu>
+Senior Technologist, Computing and Information Technology
+Harvard University School of Engineering and Applied Sciences
+
+[ application/pgp-signature ]
+[ text/plain ]
+[ 4-line signature. Click/Enter to show. ]
+_______________________________________________
+notmuch mailing list
+notmuch@notmuchmail.org
+http://notmuchmail.org/mailman/listinfo/notmuch
+ Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox signed unread)
+ Subject: Re: [notmuch] Working with Maildir storage?
+ To: notmuch@notmuchmail.org
+ Date: Wed, 18 Nov 2009 01:02:38 +0600
+
+ [ multipart/mixed ]
+ [ multipart/signed ]
+ [ text/plain ]
+
+ Twas brillig at 14:00:54 17.11.2009 UTC-05 when lars@seas.harvard.edu did gyre and gimble:
+
+ LK> Resulted in 4604 lines of errors along the lines of:
+
+ LK> Error opening
+ LK> /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ LK> Too many open files
+
+ See the patch just posted here.
+
+ [ 2-line signature. Click/Enter to show. ]
+ --
+ http://fossarchy.blogspot.com/
+ [ application/pgp-signature ]
+ [ text/plain ]
+ [ 4-line signature. Click/Enter to show. ]
+ _______________________________________________
+ notmuch mailing list
+ notmuch@notmuchmail.org
+ http://notmuchmail.org/mailman/listinfo/notmuch
+ Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-17) (inbox signed unread)
+ Subject: Re: [notmuch] Working with Maildir storage?
+ To: Mikhail Gusarov <dottedmag@dottedmag.net>
+ Cc: notmuch@notmuchmail.org
+ Date: Tue, 17 Nov 2009 15:33:01 -0500
+
+ [ multipart/mixed ]
+ [ multipart/signed ]
+ [ text/plain ]
+ > See the patch just posted here.
+
+ Is the list archived anywhere? The obvious archives
+ (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ think I subscribed too late to get the patch (I only just saw the
+ discussion about it).
+
+ It doesn't look like the patch is in git yet.
+
+ -- Lars
+
+ [ 5-line signature. Click/Enter to show. ]
+ --
+ Lars Kellogg-Stedman <lars@seas.harvard.edu>
+ Senior Technologist, Computing and Information Technology
+ Harvard University School of Engineering and Applied Sciences
+
+ [ application/pgp-signature ]
+ [ text/plain ]
+ [ 4-line signature. Click/Enter to show. ]
+ _______________________________________________
+ notmuch mailing list
+ notmuch@notmuchmail.org
+ http://notmuchmail.org/mailman/listinfo/notmuch
+ Mikhail Gusarov <dottedmag@dottedmag.net> (2009-11-17) (inbox unread)
+ Subject: [notmuch] Working with Maildir storage?
+ To: notmuch@notmuchmail.org
+ Date: Wed, 18 Nov 2009 02:50:48 +0600
+
+
+ Twas brillig at 15:33:01 17.11.2009 UTC-05 when lars at seas.harvard.edu did gyre and gimble:
+
+ LK> Is the list archived anywhere? The obvious archives
+ LK> (http://notmuchmail.org/pipermail/notmuch/) aren't available, and I
+ LK> think I subscribed too late to get the patch (I only just saw the
+ LK> discussion about it).
+
+ LK> It doesn't look like the patch is in git yet.
+
+ Just has been pushed
+
+ [ 10-line signature. Click/Enter to show. ]
+ --
+ http://fossarchy.blogspot.com/
+ -------------- next part --------------
+ A non-text attachment was scrubbed...
+ Name: not available
+ Type: application/pgp-signature
+ Size: 834 bytes
+ Desc: not available
+ URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20091118/0e33d964/attachment.pgp>
+
+ Keith Packard <keithp@keithp.com> (2009-11-17) (inbox unread)
+ Subject: [notmuch] Working with Maildir storage?
+ To: notmuch@notmuchmail.org
+ Date: Tue, 17 Nov 2009 13:24:13 -0800
+
+ On Tue, 17 Nov 2009 15:33:01 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+ > > See the patch just posted here.
+
+ I've also pushed a slightly more complicated (and complete) fix to my
+ private notmuch repository
+
+ git://keithp.com/git/notmuch
+
+ > Is the list archived anywhere?
+
+ Oops. Looks like Carl's mail server is broken. He's traveling to
+ Barcelona today and so it won't get fixed for a while.
+
+ Thanks to everyone for trying out notmuch!
+
+ -keith
+
+ Lars Kellogg-Stedman <lars@seas.harvard.edu> (2009-11-18) (inbox signed unread)
+ Subject: Re: [notmuch] Working with Maildir storage?
+ To: Keith Packard <keithp@keithp.com>
+ Cc: notmuch@notmuchmail.org
+ Date: Tue, 17 Nov 2009 19:50:40 -0500
+
+ [ multipart/mixed ]
+ [ multipart/signed ]
+ [ text/plain ]
+ > I've also pushed a slightly more complicated (and complete) fix to my
+ > private notmuch repository
+
+ The version of lib/messages.cc in your repo doesn't build because it's
+ missing "#include <stdint.h>" (for the uint32_t on line 466).
+
+ [ 5-line signature. Click/Enter to show. ]
+ --
+ Lars Kellogg-Stedman <lars@seas.harvard.edu>
+ Senior Technologist, Computing and Information Technology
+ Harvard University School of Engineering and Applied Sciences
+
+ [ application/pgp-signature ]
+ [ text/plain ]
+ [ 4-line signature. Click/Enter to show. ]
+ _______________________________________________
+ notmuch mailing list
+ notmuch@notmuchmail.org
+ http://notmuchmail.org/mailman/listinfo/notmuch
+ Carl Worth <cworth@cworth.org> (2009-11-18) (inbox unread)
+ Subject: [notmuch] Working with Maildir storage?
+ To: notmuch@notmuchmail.org
+ Date: Wed, 18 Nov 2009 02:08:10 -0800
+
+ On Tue, 17 Nov 2009 14:00:54 -0500, Lars Kellogg-Stedman <lars at seas.harvard.edu> wrote:
+ > I saw the LWN article and decided to take a look at notmuch. I'm
+ > currently using mutt and mairix to index and read a collection of
+ > Maildir mail folders (around 40,000 messages total).
+
+ Welcome, Lars!
+
+ I hadn't even seen that Keith's blog post had been picked up by lwn.net.
+ That's very interesting. So, thanks for coming and trying out notmuch.
+
+ > Error opening
+ > /home/lars/Mail/read-messages.2008/cur/1246413773.24928_27334.hostname,U=3026:2,S:
+ > Too many open files
+
+ Sadly, the lwn article coincided with me having just introduced this
+ bug, and then getting on a Trans-Atlantic flight. So I fixed the bug
+ fairly quickly, but there was quite a bit of latency before I could push
+ the fix out. It should be fixed now.
+
+ > I'm curious if this is expected behavior (i.e., notmuch does not work
+ > with Maildir) or if something else is going on.
+
+ Notmuch works just fine with maildir---it's one of the things that it
+ likes the best.
+
+ Happy hacking,
+
+ -Carl
+
--
1.7.7.3
^ permalink raw reply related [flat|nested] 35+ messages in thread
* Re: [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default)
2011-11-24 22:03 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) Gregor Zattler
` (3 preceding siblings ...)
2011-11-24 22:03 ` [PATCH 4/4] emacs: test notmuch show with fourfold message indentation Gregor Zattler
@ 2011-11-26 5:18 ` David Bremner
4 siblings, 0 replies; 35+ messages in thread
From: David Bremner @ 2011-11-26 5:18 UTC (permalink / raw)
To: Gregor Zattler, notmuch
On Thu, 24 Nov 2011 23:03:20 +0100, Gregor Zattler <telegraph@gmx.net> wrote:
> Dear David, notmuch developers,
>
> * David Bremner <david@tethera.net> [24. Nov. 2011]:
> > On Sun, 23 Oct 2011 21:38:43 +0200, Gregor Zattler <telegraph@gmx.net> wrote:
> > The extra copy of the patch header messes up the log messages with the 3
> > test related patches in this series are applied. Can you resend with
> > git-send-email?
>
> Sure.
>
Pushed to master
d
^ permalink raw reply [flat|nested] 35+ messages in thread
end of thread, other threads:[~2011-11-26 5:18 UTC | newest]
Thread overview: 35+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-11 8:42 [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
2011-07-11 8:53 ` Dmitry Kurochkin
2011-07-11 9:24 ` Felix Geller
2011-07-11 9:55 ` Dmitry Kurochkin
2011-07-11 10:09 ` Felix Geller
2011-07-11 8:57 ` Daniel Schoepe
2011-07-11 16:32 ` Jameson Graef Rollins
2011-07-12 23:46 ` Felix Geller
2011-07-16 13:25 ` Felix Geller
2011-07-18 18:30 ` Jameson Graef Rollins
2011-07-18 18:57 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Felix Geller
2011-07-18 18:57 ` [PATCH 2/2] Test for toggling message indentation Felix Geller
2011-07-18 19:14 ` [PATCH 1/2] Added variable to toggle message indendation in Emacs' notmuch-show Jameson Graef Rollins
2011-07-18 22:28 ` [PATCH] Emacs: Toggle message indentation for threads in notmuch-show Felix Geller
2011-07-18 22:28 ` [PATCH 1/2] Emacs: Test for turning off indentation of messages in threads Felix Geller
2011-07-18 22:28 ` [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show Felix Geller
2011-07-19 10:50 ` configure indentation width instead? (was: Re: [PATCH 2/2] Emacs: Add variable to toggle thread indentation to notmuch-show) Gregor Zattler
2011-08-16 20:24 ` Michal Sojka
2011-10-23 16:43 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) Gregor Zattler
2011-10-23 16:52 ` [PATCH 1/2] emacs: add customisation for message indentation width Gregor Zattler
2011-10-23 17:00 ` [PATCH] emacs: make message indentation width customisable (was: Re: configure indentation width instead?) David Bremner
2011-10-23 17:00 ` [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation Gregor Zattler
2011-10-23 19:09 ` sorry, this test does not work (was: Re: [PATCH 2/2] Emacs: test: notmuch-show for a message thread without the indentation) Gregor Zattler
2011-10-23 19:38 ` [PATCH 2a/2] emacs: test notmuch-indent-messages-width default Gregor Zattler
2011-11-24 13:13 ` David Bremner
2011-11-24 22:03 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) Gregor Zattler
2011-11-24 22:03 ` [PATCH 1/4] emacs: make message indentation width customisable Gregor Zattler
2011-11-24 22:03 ` [PATCH 2/4] emacs: test notmuch-indent-messages-width default Gregor Zattler
2011-11-24 22:03 ` [PATCH 3/4] emacs: test: notmuch show without indentation Gregor Zattler
2011-11-24 22:03 ` [PATCH 4/4] emacs: test notmuch show with fourfold message indentation Gregor Zattler
2011-11-26 5:18 ` [PATCH 0/4] emacs: make message indentation width customisable (was: Re: [PATCH 2a/2] emacs: test notmuch-indent-messages-width default) David Bremner
2011-10-23 19:41 ` [PATCH 2b/2] emacs: test: notmuch show without indentation Gregor Zattler
2011-10-23 19:42 ` [PATCH 2c/2] emacs: test notmuch show with fourfold message indentation Gregor Zattler
2011-07-18 19:04 ` [PATCH] Emacs: Add variable to toggle message indentation in a thread Felix Geller
2011-07-18 19:10 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).