From: Florian Friesdorf <flo@chaoflow.net>
To: Chris Gray <chrismgray@gmail.com>, David Edmondson <dme@dme.org>,
notmuch@notmuchmail.org
Subject: Re: [RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run.
Date: Mon, 23 Jan 2012 15:43:08 +0100 [thread overview]
Message-ID: <8762g2qy2r.fsf@eve.chaoflow.net> (raw)
In-Reply-To: <8762hbkas3.fsf@gmail.com>
On Mon, 19 Dec 2011 23:38:36 -0700, Chris Gray <chrismgray@gmail.com> wrote:
> > +;; Nonsense required to have the new gnus `shr' HTML display code
> > +;; work.
> > +(defvar gnus-summary-buffer)
> > +(defvar gnus-inhibit-images)
>
> I believe that gnus-inhibit-images is defined in gnus-art.el. Perhaps
> that file should just be require'd rather than having this workaround.
With notmuch-0.11 (require 'gnus-art') "fixes" the void
gnus-inhibit-images error.
> > +(if (not (fboundp 'gnus-blocked-images))
> > + (defun gnus-blocked-images () nil))
> > +
> > (defun notmuch-show-mm-display-part-inline (msg part nth content-type)
> > "Use the mm-decode/mm-view functions to display a part in the
> > current buffer, if possible."
> > @@ -331,7 +338,12 @@ current buffer, if possible."
> > (let ((content (notmuch-show-get-bodypart-content msg part nth)))
> > (insert content)
> > (set-buffer display-buffer)
> > - (mm-display-part handle)
> > +
> > + ;; Nonsense required to have the new gnus `shr' HTML
> > + ;; display code work.
> > + (let ((gnus-inhibit-images nil))
> > + (makunbound 'gnus-summary-buffer) ; Blech.
>
> This is working around a bug in gnus. I think the better solution would
> be for gnus to fix the bug. The following patch against gnus works for
> me. (I have tried submitting it to the gnus bug list, but have not been
> able to check if it got through.)
emacs git master has a fix for that, so you seem to have got through.
--
Florian Friesdorf <flo@chaoflow.net>
GPG FPR: 7A13 5EEE 1421 9FC2 108D BAAF 38F8 99A3 0C45 F083
Jabber/XMPP: flo@chaoflow.net
IRC: chaoflow on freenode,ircnet,blafasel,OFTC
next prev parent reply other threads:[~2012-01-23 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 15:45 [RFC][PATCH] emacs: Provide scaffolding so that the new `shr' HTML renderer can run David Edmondson
2011-12-19 17:50 ` Aaron Ecay
2011-12-20 6:38 ` Chris Gray
2011-12-20 8:35 ` David Edmondson
2011-12-20 14:27 ` Chris Gray
2011-12-20 14:33 ` David Edmondson
2011-12-20 16:09 ` Chris Gray
2011-12-20 8:40 ` Aaron Ecay
2011-12-20 17:06 ` Chris Gray
2012-01-23 14:43 ` Florian Friesdorf [this message]
2012-01-23 17:14 ` Chris Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762g2qy2r.fsf@eve.chaoflow.net \
--to=flo@chaoflow.net \
--cc=chrismgray@gmail.com \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).